[INFO] fetching crate job-security-client 0.1.3... [INFO] checking job-security-client-0.1.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate job-security-client 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate job-security-client 0.1.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate job-security-client 0.1.3 [INFO] finished tweaking crates.io crate job-security-client 0.1.3 [INFO] tweaked toml for crates.io crate job-security-client 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cfg_aliases v0.1.1 (available: v0.2.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding memoffset v0.7.1 (available: v0.9.1) [INFO] [stderr] Adding nix v0.26.4 (available: v0.29.0) [INFO] [stderr] Adding nix v0.28.0 (available: v0.29.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding withfd v0.1.2 (available: v0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4786e5f1b8ce7b173175fd848acfdc930975300bca150f09b7369fa308de8f6 [INFO] running `Command { std: "docker" "start" "-a" "c4786e5f1b8ce7b173175fd848acfdc930975300bca150f09b7369fa308de8f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4786e5f1b8ce7b173175fd848acfdc930975300bca150f09b7369fa308de8f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4786e5f1b8ce7b173175fd848acfdc930975300bca150f09b7369fa308de8f6", kill_on_drop: false }` [INFO] [stdout] c4786e5f1b8ce7b173175fd848acfdc930975300bca150f09b7369fa308de8f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2769b43953825b61f843c75498b8fc78d389e026657d0e96a4c7fe90a753fbe8 [INFO] running `Command { std: "docker" "start" "-a" "2769b43953825b61f843c75498b8fc78d389e026657d0e96a4c7fe90a753fbe8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling cstr v0.2.12 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking withfd v0.1.2 [INFO] [stderr] Checking job-security-protocol v0.1.1 [INFO] [stderr] Checking job-security-client v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Framed, impl Encoder + Decoder>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 103 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let mut conn = tokio_util::codec::Framed::new(conn.with_fd(), protocol::client_codec()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 208 | / select! { [INFO] [stdout] 209 | | event = conn.next() => { [INFO] [stdout] 210 | | tracing::info!("event: {:?}", event); [INFO] [stdout] 211 | | let Some(event) = event else { [INFO] [stdout] ... | [INFO] [stdout] 264 | | } [INFO] [stdout] 265 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `job-security-client` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Framed, impl Encoder + Decoder>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 103 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let mut conn = tokio_util::codec::Framed::new(conn.with_fd(), protocol::client_codec()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 208 | / select! { [INFO] [stdout] 209 | | event = conn.next() => { [INFO] [stdout] 210 | | tracing::info!("event: {:?}", event); [INFO] [stdout] 211 | | let Some(event) = event else { [INFO] [stdout] ... | [INFO] [stdout] 264 | | } [INFO] [stdout] 265 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `job-security-client` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "2769b43953825b61f843c75498b8fc78d389e026657d0e96a4c7fe90a753fbe8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2769b43953825b61f843c75498b8fc78d389e026657d0e96a4c7fe90a753fbe8", kill_on_drop: false }` [INFO] [stdout] 2769b43953825b61f843c75498b8fc78d389e026657d0e96a4c7fe90a753fbe8