[INFO] fetching crate jbonsai 0.1.1... [INFO] checking jbonsai-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate jbonsai 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate jbonsai 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate jbonsai 0.1.1 [INFO] removed 2 missing examples [INFO] finished tweaking crates.io crate jbonsai 0.1.1 [INFO] tweaked toml for crates.io crate jbonsai 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate jbonsai 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b2cb4da59372cb7b53099cc26a9fedb2f044edda7f718660c3845b21e07dcc3 [INFO] running `Command { std: "docker" "start" "-a" "1b2cb4da59372cb7b53099cc26a9fedb2f044edda7f718660c3845b21e07dcc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b2cb4da59372cb7b53099cc26a9fedb2f044edda7f718660c3845b21e07dcc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b2cb4da59372cb7b53099cc26a9fedb2f044edda7f718660c3845b21e07dcc3", kill_on_drop: false }` [INFO] [stdout] 1b2cb4da59372cb7b53099cc26a9fedb2f044edda7f718660c3845b21e07dcc3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b41c2af5b035f8f5fa4bae5e364d5ec0c152423278b12cfcb774ea6d0bd2e5da [INFO] running `Command { std: "docker" "start" "-a" "b41c2af5b035f8f5fa4bae5e364d5ec0c152423278b12cfcb774ea6d0bd2e5da", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking jlabel v0.1.4 [INFO] [stderr] Checking jlabel-question v0.1.4 [INFO] [stderr] Checking jbonsai v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `impl Fn(&[u8]) -> std::result::Result<(&[u8], &[u8]), nom::Err>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/base.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 140 | fn parse_template<'a, F, E>(self, cond: F) -> IResult [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | take_while(|c| cond(c as char))(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Fn(&[u8]) -> std::result::Result<(&[u8], &[u8]), nom::Err>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/base.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 148 | fn parse_template1<'a, F, E>(self, cond: F) -> IResult [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | take_while1(|c| cond(c as char))(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(S, std::string::String)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/model/question.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 62 | .and_then(|(rest, (name, question))| { [INFO] [stdout] | ------------------------ [INFO] [stdout] | | | | [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Ok((rest, (name.parse_ascii_to_string()?.1, question))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(S, std::string::String)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/model/tree.rs:100:36 [INFO] [stdout] | [INFO] [stdout] 95 | .and_then(|(rest, (id, question_name, no, yes))| { [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | question_name: question_name.parse_ascii_to_string()?.1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Fn(&[u8]) -> std::result::Result<(&[u8], &[u8]), nom::Err>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/base.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 140 | fn parse_template<'a, F, E>(self, cond: F) -> IResult [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | take_while(|c| cond(c as char))(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Fn(&[u8]) -> std::result::Result<(&[u8], &[u8]), nom::Err>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/base.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 148 | fn parse_template1<'a, F, E>(self, cond: F) -> IResult [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | take_while1(|c| cond(c as char))(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl FnMut(S) -> std::result::Result<(S, Window), nom::Err>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/window.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 26 | let (i, n) = digit1(i)?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | map(many_m_n(n, n, preceded(space1, double)), Window::new)(i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(S, std::string::String)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/model/question.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 62 | .and_then(|(rest, (name, question))| { [INFO] [stdout] | ------------------------ [INFO] [stdout] | | | | [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Ok((rest, (name.parse_ascii_to_string()?.1, question))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(S, std::string::String)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/model/tree.rs:100:36 [INFO] [stdout] | [INFO] [stdout] 95 | .and_then(|(rest, (id, question_name, no, yes))| { [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | question_name: question_name.parse_ascii_to_string()?.1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jbonsai` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `impl FnMut(S) -> std::result::Result<(S, Window), nom::Err>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/parser/window.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 26 | let (i, n) = digit1(i)?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | map(many_m_n(n, n, preceded(space1, double)), Window::new)(i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a module [INFO] [stdout] --> src/model/mod.rs:167:1 [INFO] [stdout] | [INFO] [stdout] 167 | pub mod tests { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![deny(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a function [INFO] [stdout] --> src/model/mod.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | pub fn load_models() -> Models<'static> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jbonsai` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "b41c2af5b035f8f5fa4bae5e364d5ec0c152423278b12cfcb774ea6d0bd2e5da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b41c2af5b035f8f5fa4bae5e364d5ec0c152423278b12cfcb774ea6d0bd2e5da", kill_on_drop: false }` [INFO] [stdout] b41c2af5b035f8f5fa4bae5e364d5ec0c152423278b12cfcb774ea6d0bd2e5da