[INFO] fetching crate isla 0.2.0... [INFO] checking isla-0.2.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate isla 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate isla 0.2.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate isla 0.2.0 [INFO] finished tweaking crates.io crate isla 0.2.0 [INFO] tweaked toml for crates.io crate isla 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate isla 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4653f1652e49ec3bbe713bef3ee8c91b309e75139bca33f94ffde7d813a46c41 [INFO] running `Command { std: "docker" "start" "-a" "4653f1652e49ec3bbe713bef3ee8c91b309e75139bca33f94ffde7d813a46c41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4653f1652e49ec3bbe713bef3ee8c91b309e75139bca33f94ffde7d813a46c41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4653f1652e49ec3bbe713bef3ee8c91b309e75139bca33f94ffde7d813a46c41", kill_on_drop: false }` [INFO] [stdout] 4653f1652e49ec3bbe713bef3ee8c91b309e75139bca33f94ffde7d813a46c41 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93d87583f6f78e0624dc9d5fcc9bd49c6d71fe335938b299b85d27b237359bce [INFO] running `Command { std: "docker" "start" "-a" "93d87583f6f78e0624dc9d5fcc9bd49c6d71fe335938b299b85d27b237359bce", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling indexmap v1.6.1 [INFO] [stderr] Compiling once_cell v1.7.0 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling hashbrown v0.9.1 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling thread_local v1.1.3 [INFO] [stderr] Compiling regex-syntax v0.6.22 [INFO] [stderr] Compiling siphasher v0.3.3 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling aho-corasick v0.7.15 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling fixedbitset v0.2.0 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling dirs v1.0.5 [INFO] [stderr] Compiling string_cache v0.8.1 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling itertools v0.9.0 [INFO] [stderr] Compiling term v0.5.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling bit-set v0.5.2 [INFO] [stderr] Compiling petgraph v0.5.1 [INFO] [stderr] Compiling ena v0.14.0 [INFO] [stderr] Compiling diff v0.1.12 [INFO] [stderr] Compiling ascii-canvas v2.0.0 [INFO] [stderr] Compiling pico-args v0.3.4 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling regex v1.4.3 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking z3-sys v0.5.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling isla v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling lalrpop-util v0.19.4 [INFO] [stderr] Compiling lalrpop v0.19.4 [INFO] [stderr] Compiling scroll_derive v0.10.5 [INFO] [stderr] Checking scroll v0.10.2 [INFO] [stderr] Checking goblin v0.2.3 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking bincode v1.3.2 [INFO] [stderr] Compiling isla-cat v0.2.0 [INFO] [stderr] Compiling isla-lib v0.2.0 [INFO] [stderr] Compiling isla-axiomatic v0.2.0 [INFO] [stdout] error: this value of type `Result<(), Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preprocess.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 57 | let (matches, arch) = opts::parse::(&mut hasher, &opts); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | if let Err(e) = write_output(&output, arch, &symtab) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `num_threads` and `isa_config` are never read [INFO] [stdout] --> src/opts.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 103 | pub struct CommonOpts<'ir, B> { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 104 | pub num_threads: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 107 | pub isa_config: ISAConfig, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/axiomatic.rs:603:25 [INFO] [stdout] | [INFO] [stdout] 601 | fn parse_result_line(lines: &mut Lines>, expected: AxResult) -> Result> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 602 | use RefsError::*; [INFO] [stdout] 603 | if let Some(line) = lines.next() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `isla` (bin "isla-preprocess") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `isla` (bin "isla-axiomatic") due to 2 previous errors [INFO] [stdout] error: this value of type `Result<(), Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preprocess.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 57 | let (matches, arch) = opts::parse::(&mut hasher, &opts); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | if let Err(e) = write_output(&output, arch, &symtab) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `num_threads` and `isa_config` are never read [INFO] [stdout] --> src/opts.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 103 | pub struct CommonOpts<'ir, B> { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 104 | pub num_threads: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 107 | pub isa_config: ISAConfig, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `isla` (bin "isla-preprocess" test) due to 2 previous errors; 1 warning emitted [INFO] [stdout] error: this value of type `Result, std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:245:11 [INFO] [stdout] | [INFO] [stdout] 229 | let (matches, arch) = opts::parse(&mut hasher, &opts); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let CommonOpts { num_threads, mut arch, symtab, isa_config } = [INFO] [stdout] | -------- ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let Initialized { regs, lets, shared_state } = [INFO] [stdout] | ---- ---- ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | let mut stream = match UnixStream::connect(&socket_path) { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | match interact(&mut stream, num_threads, &shared_state, ®s, &lets, &isa_config) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `isla` (bin "isla-client" test) due to 2 previous errors [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/axiomatic.rs:603:25 [INFO] [stdout] | [INFO] [stdout] 601 | fn parse_result_line(lines: &mut Lines>, expected: AxResult) -> Result> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 602 | use RefsError::*; [INFO] [stdout] 603 | if let Some(line) = lines.next() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `isla` (bin "isla-axiomatic" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "93d87583f6f78e0624dc9d5fcc9bd49c6d71fe335938b299b85d27b237359bce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93d87583f6f78e0624dc9d5fcc9bd49c6d71fe335938b299b85d27b237359bce", kill_on_drop: false }` [INFO] [stdout] 93d87583f6f78e0624dc9d5fcc9bd49c6d71fe335938b299b85d27b237359bce