[INFO] fetching crate iroh-quinn-proto 0.11.6... [INFO] checking iroh-quinn-proto-0.11.6 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate iroh-quinn-proto 0.11.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate iroh-quinn-proto 0.11.6 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iroh-quinn-proto 0.11.6 [INFO] finished tweaking crates.io crate iroh-quinn-proto 0.11.6 [INFO] tweaked toml for crates.io crate iroh-quinn-proto 0.11.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 106 packages to latest compatible versions [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding jni v0.19.0 (available: v0.21.1) [INFO] [stderr] Adding jni-sys v0.3.0 (available: v0.4.0) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding rustls-native-certs v0.7.3 (available: v0.8.0) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0318c2ffddb9094e9de7d7c1fe2f0c10554cb3917c2f8415e9ac2c0d6889655f [INFO] running `Command { std: "docker" "start" "-a" "0318c2ffddb9094e9de7d7c1fe2f0c10554cb3917c2f8415e9ac2c0d6889655f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0318c2ffddb9094e9de7d7c1fe2f0c10554cb3917c2f8415e9ac2c0d6889655f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0318c2ffddb9094e9de7d7c1fe2f0c10554cb3917c2f8415e9ac2c0d6889655f", kill_on_drop: false }` [INFO] [stdout] 0318c2ffddb9094e9de7d7c1fe2f0c10554cb3917c2f8415e9ac2c0d6889655f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9115e3f401803835bfd5a42c1013e3c8ec699b709e5ac9101115b838f0a515ce [INFO] running `Command { std: "docker" "start" "-a" "9115e3f401803835bfd5a42c1013e3c8ec699b709e5ac9101115b838f0a515ce", kill_on_drop: false }` [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling rustls v0.23.13 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rcgen v0.13.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking iroh-quinn-proto v0.11.6 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result<(), ConnectionError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/endpoint.rs:658:15 [INFO] [stdout] | [INFO] [stdout] 556 | mut incoming: Incoming, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 563 | let incoming_buffer = self.incoming_buffers.remove(incoming.incoming_idx); [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 640 | let mut conn = self.add_connection( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 658 | match conn.handle_first_packet( [INFO] [stdout] | _______________^ [INFO] [stdout] 659 | | now, [INFO] [stdout] 660 | | incoming.addresses.remote, [INFO] [stdout] 661 | | incoming.ecn, [INFO] [stdout] ... | [INFO] [stdout] 664 | | incoming.rest, [INFO] [stdout] 665 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iroh-quinn-proto` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result<(), datagrams::SendDatagramError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:1868:11 [INFO] [stdout] | [INFO] [stdout] 1855 | let _guard = subscribe(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1863 | let mut pair = Pair::new(Default::default(), server); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1868 | match pair.client_datagrams(client_ch).send(Bytes::new(), true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `recv::Chunks<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:2035:13 [INFO] [stdout] | [INFO] [stdout] 2013 | let _guard = subscribe(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2021 | let mut pair = Pair::new(Default::default(), server); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2035 | let mut chunks = recv.read(false).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tests::util::Pair` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:2227:13 [INFO] [stdout] | [INFO] [stdout] 2223 | let _guard = subscribe(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2227 | let mut pair = Pair::default(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `bytes::Bytes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:3079:13 [INFO] [stdout] | [INFO] [stdout] 3058 | let _guard = subscribe(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 3059 | let mut pair = Pair::default(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3079 | / pair.server_datagrams(server_ch) [INFO] [stdout] 3080 | | .recv() [INFO] [stdout] 3081 | | .expect("datagram lost") [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), connection::ConnectionError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/endpoint.rs:658:15 [INFO] [stdout] | [INFO] [stdout] 556 | mut incoming: Incoming, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 563 | let incoming_buffer = self.incoming_buffers.remove(incoming.incoming_idx); [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 640 | let mut conn = self.add_connection( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 658 | match conn.handle_first_packet( [INFO] [stdout] | _______________^ [INFO] [stdout] 659 | | now, [INFO] [stdout] 660 | | incoming.addresses.remote, [INFO] [stdout] 661 | | incoming.ecn, [INFO] [stdout] ... | [INFO] [stdout] 664 | | incoming.rest, [INFO] [stdout] 665 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iroh-quinn-proto` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "9115e3f401803835bfd5a42c1013e3c8ec699b709e5ac9101115b838f0a515ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9115e3f401803835bfd5a42c1013e3c8ec699b709e5ac9101115b838f0a515ce", kill_on_drop: false }` [INFO] [stdout] 9115e3f401803835bfd5a42c1013e3c8ec699b709e5ac9101115b838f0a515ce