[INFO] fetching crate iroh-quinn 0.11.3... [INFO] checking iroh-quinn-0.11.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate iroh-quinn 0.11.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate iroh-quinn 0.11.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iroh-quinn 0.11.3 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate iroh-quinn 0.11.3 [INFO] tweaked toml for crates.io crate iroh-quinn 0.11.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate iroh-quinn 0.11.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 48ba9969d283a177a7f679dd372c6742313c7a46124379504a1c94bdd47426d9 [INFO] running `Command { std: "docker" "start" "-a" "48ba9969d283a177a7f679dd372c6742313c7a46124379504a1c94bdd47426d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "48ba9969d283a177a7f679dd372c6742313c7a46124379504a1c94bdd47426d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48ba9969d283a177a7f679dd372c6742313c7a46124379504a1c94bdd47426d9", kill_on_drop: false }` [INFO] [stdout] 48ba9969d283a177a7f679dd372c6742313c7a46124379504a1c94bdd47426d9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1e81c76f5bd1f50ad20a52e32e7e86ea91f5c5582fd8aa3f04e31b98c881a807 [INFO] running `Command { std: "docker" "start" "-a" "1e81c76f5bd1f50ad20a52e32e7e86ea91f5c5582fd8aa3f04e31b98c881a807", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustls-native-certs v0.7.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Compiling anyhow v1.0.83 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking bencher v0.1.5 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling syn v2.0.64 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking iroh-quinn-udp v0.5.4 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking rcgen v0.13.1 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking rustls-platform-verifier v0.3.3 [INFO] [stderr] Checking iroh-quinn-proto v0.11.6 [INFO] [stderr] Checking iroh-quinn v0.11.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<(), iroh_quinn_proto::SendDatagramError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:442:15 [INFO] [stdout] | [INFO] [stdout] 437 | let conn = &mut *self.0.state.lock("send_datagram"); [INFO] [stdout] | ---------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 442 | match conn.inner.datagrams().send(data, true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), iroh_quinn_proto::SendDatagramError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:833:15 [INFO] [stdout] | [INFO] [stdout] 828 | let mut state = this.conn.state.lock("SendDatagram::poll"); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 833 | match state [INFO] [stdout] | _______________^ [INFO] [stdout] 834 | | .inner [INFO] [stdout] 835 | | .datagrams() [INFO] [stdout] 836 | | .send(this.data.take().unwrap(), false) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(ConnectionHandle, iroh_quinn_proto::Connection), AcceptError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/endpoint.rs:416:15 [INFO] [stdout] | [INFO] [stdout] 413 | let mut state = self.state.lock().unwrap(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | match state [INFO] [stdout] | _______________^ [INFO] [stdout] 417 | | .inner [INFO] [stdout] 418 | | .accept(incoming, now, &mut response_buffer, server_config) [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iroh-quinn` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result<(), iroh_quinn_proto::SendDatagramError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:442:15 [INFO] [stdout] | [INFO] [stdout] 437 | let conn = &mut *self.0.state.lock("send_datagram"); [INFO] [stdout] | ---------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 442 | match conn.inner.datagrams().send(data, true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), iroh_quinn_proto::SendDatagramError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:833:15 [INFO] [stdout] | [INFO] [stdout] 828 | let mut state = this.conn.state.lock("SendDatagram::poll"); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 833 | match state [INFO] [stdout] | _______________^ [INFO] [stdout] 834 | | .inner [INFO] [stdout] 835 | | .datagrams() [INFO] [stdout] 836 | | .send(this.data.take().unwrap(), false) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(ConnectionHandle, iroh_quinn_proto::Connection), AcceptError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/endpoint.rs:416:15 [INFO] [stdout] | [INFO] [stdout] 413 | let mut state = self.state.lock().unwrap(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | match state [INFO] [stdout] | _______________^ [INFO] [stdout] 417 | | .inner [INFO] [stdout] 418 | | .accept(incoming, now, &mut response_buffer, server_config) [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:103:11 [INFO] [stdout] | [INFO] [stdout] 73 | let _guard = subscribe(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let cert = rcgen::generate_simple_self_signed(vec!["localhost".into()]).unwrap(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let mut endpoint = [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | match conn.await { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iroh-quinn` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "1e81c76f5bd1f50ad20a52e32e7e86ea91f5c5582fd8aa3f04e31b98c881a807", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e81c76f5bd1f50ad20a52e32e7e86ea91f5c5582fd8aa3f04e31b98c881a807", kill_on_drop: false }` [INFO] [stdout] 1e81c76f5bd1f50ad20a52e32e7e86ea91f5c5582fd8aa3f04e31b98c881a807