[INFO] fetching crate ipaddress 0.1.3... [INFO] checking ipaddress-0.1.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ipaddress 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ipaddress 0.1.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ipaddress 0.1.3 [INFO] finished tweaking crates.io crate ipaddress 0.1.3 [INFO] tweaked toml for crates.io crate ipaddress 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 382b3e494902515f49c4f7858242f4adec7674f8b2b956941e97ff2a44b8cdd2 [INFO] running `Command { std: "docker" "start" "-a" "382b3e494902515f49c4f7858242f4adec7674f8b2b956941e97ff2a44b8cdd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "382b3e494902515f49c4f7858242f4adec7674f8b2b956941e97ff2a44b8cdd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "382b3e494902515f49c4f7858242f4adec7674f8b2b956941e97ff2a44b8cdd2", kill_on_drop: false }` [INFO] [stdout] 382b3e494902515f49c4f7858242f4adec7674f8b2b956941e97ff2a44b8cdd2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d8ad069840b0c29bdc99ab5d8b937f0fd4942803f7ba7e4960dd840f05e10b4 [INFO] running `Command { std: "docker" "start" "-a" "0d8ad069840b0c29bdc99ab5d8b937f0fd4942803f7ba7e4960dd840f05e10b4", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking ipaddress v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/prefix.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | ip_bits: self.ip_bits.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IpBits` does not implement `Clone`, so calling `clone` on `&IpBits` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 30 - ip_bits: self.ip_bits.clone(), [INFO] [stdout] 30 + ip_bits: self.ip_bits, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IpBits`, implement `Clone` for it [INFO] [stdout] --> src/ip_bits.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Clone)] [INFO] [stdout] 27 | pub struct IpBits { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/prefix.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | ip_bits: self.ip_bits.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IpBits` does not implement `Clone`, so calling `clone` on `&IpBits` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 30 - ip_bits: self.ip_bits.clone(), [INFO] [stdout] 30 + ip_bits: self.ip_bits, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IpBits`, implement `Clone` for it [INFO] [stdout] --> src/ip_bits.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Clone)] [INFO] [stdout] 27 | pub struct IpBits { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ipaddress.rs:61:34 [INFO] [stdout] | [INFO] [stdout] 61 | ip_bits: self.ip_bits.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IpBits` does not implement `Clone`, so calling `clone` on `&IpBits` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 61 - ip_bits: self.ip_bits.clone(), [INFO] [stdout] 61 + ip_bits: self.ip_bits, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IpBits`, implement `Clone` for it [INFO] [stdout] --> src/ip_bits.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Clone)] [INFO] [stdout] 27 | pub struct IpBits { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ipaddress.rs:163:34 [INFO] [stdout] | [INFO] [stdout] 163 | ip_bits: self.ip_bits.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IpBits` does not implement `Clone`, so calling `clone` on `&IpBits` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 163 - ip_bits: self.ip_bits.clone(), [INFO] [stdout] 163 + ip_bits: self.ip_bits, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IpBits`, implement `Clone` for it [INFO] [stdout] --> src/ip_bits.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Clone)] [INFO] [stdout] 27 | pub struct IpBits { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ipaddress.rs:61:34 [INFO] [stdout] | [INFO] [stdout] 61 | ip_bits: self.ip_bits.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IpBits` does not implement `Clone`, so calling `clone` on `&IpBits` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 61 - ip_bits: self.ip_bits.clone(), [INFO] [stdout] 61 + ip_bits: self.ip_bits, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IpBits`, implement `Clone` for it [INFO] [stdout] --> src/ip_bits.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Clone)] [INFO] [stdout] 27 | pub struct IpBits { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ipaddress.rs:163:34 [INFO] [stdout] | [INFO] [stdout] 163 | ip_bits: self.ip_bits.clone(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IpBits` does not implement `Clone`, so calling `clone` on `&IpBits` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 163 - ip_bits: self.ip_bits.clone(), [INFO] [stdout] 163 + ip_bits: self.ip_bits, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IpBits`, implement `Clone` for it [INFO] [stdout] --> src/ip_bits.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Clone)] [INFO] [stdout] 27 | pub struct IpBits { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::IntoIter<&str, BigUint>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/test_ipv6_mapped.rs:68:27 [INFO] [stdout] | [INFO] [stdout] 58 | let s = setup(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | for (ip, u128) in s.valid_mapped_ipv6 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ipaddress` (test "test_ipv6_mapped") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `[IPAddress; 3]` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/test_ipv4.rs:508:17 [INFO] [stdout] | [INFO] [stdout] 479 | let ip4 = IPAddress::parse("10.1.1.1/8").unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | let mut res = [ip1, ip2, ip3]; [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 508 | let mut res = [ip1, ip2, ip3]; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ipaddress` (test "test_ipv4") due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "0d8ad069840b0c29bdc99ab5d8b937f0fd4942803f7ba7e4960dd840f05e10b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d8ad069840b0c29bdc99ab5d8b937f0fd4942803f7ba7e4960dd840f05e10b4", kill_on_drop: false }` [INFO] [stdout] 0d8ad069840b0c29bdc99ab5d8b937f0fd4942803f7ba7e4960dd840f05e10b4