[INFO] fetching crate indymilter 0.3.0... [INFO] checking indymilter-0.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate indymilter 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate indymilter 0.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate indymilter 0.3.0 [INFO] finished tweaking crates.io crate indymilter 0.3.0 [INFO] tweaked toml for crates.io crate indymilter 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate indymilter 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 708e127ee5da08b33e2a16deb1bde8de1657215054afcb842f53aef54e1b1ba1 [INFO] running `Command { std: "docker" "start" "-a" "708e127ee5da08b33e2a16deb1bde8de1657215054afcb842f53aef54e1b1ba1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "708e127ee5da08b33e2a16deb1bde8de1657215054afcb842f53aef54e1b1ba1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "708e127ee5da08b33e2a16deb1bde8de1657215054afcb842f53aef54e1b1ba1", kill_on_drop: false }` [INFO] [stdout] 708e127ee5da08b33e2a16deb1bde8de1657215054afcb842f53aef54e1b1ba1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d98986742d64b7b4fa495bce9c8a53ec47ec89cfd2c7cfabd657d577b35c289 [INFO] running `Command { std: "docker" "start" "-a" "4d98986742d64b7b4fa495bce9c8a53ec47ec89cfd2c7cfabd657d577b35c289", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.7.3 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling byte-strings-proc_macros v0.3.1 [INFO] [stderr] Checking byte-strings v0.3.1 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking indymilter v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::sync::watch::Sender` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:10 [INFO] [stdout] | [INFO] [stdout] 146 | let (shutdown_sessions, _) = watch::channel(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 157 | let result = select! { [INFO] [stdout] | __________________- [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] 158 | | res = run_milter(listener, callbacks, config, &shutdown_sessions) => { [INFO] [stdout] 159 | | let e = res.unwrap_err(); [INFO] [stdout] 160 | | error!("milter exited with error, shutting down: {e}"); [INFO] [stdout] ... | [INFO] [stdout] 166 | | } [INFO] [stdout] 167 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::watch::Sender` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:10 [INFO] [stdout] | [INFO] [stdout] 146 | let (shutdown_sessions, _) = watch::channel(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 157 | let result = select! { [INFO] [stdout] | __________________- [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] | |__________________| [INFO] [stdout] 158 | | res = run_milter(listener, callbacks, config, &shutdown_sessions) => { [INFO] [stdout] 159 | | let e = res.unwrap_err(); [INFO] [stdout] 160 | | error!("milter exited with error, shutting down: {e}"); [INFO] [stdout] ... | [INFO] [stdout] 166 | | } [INFO] [stdout] 167 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `indymilter` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `indymilter` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "4d98986742d64b7b4fa495bce9c8a53ec47ec89cfd2c7cfabd657d577b35c289", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d98986742d64b7b4fa495bce9c8a53ec47ec89cfd2c7cfabd657d577b35c289", kill_on_drop: false }` [INFO] [stdout] 4d98986742d64b7b4fa495bce9c8a53ec47ec89cfd2c7cfabd657d577b35c289