[INFO] fetching crate ic-certification 2.6.0... [INFO] checking ic-certification-2.6.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ic-certification 2.6.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ic-certification 2.6.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ic-certification 2.6.0 [INFO] finished tweaking crates.io crate ic-certification 2.6.0 [INFO] tweaked toml for crates.io crate ic-certification 2.6.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 45 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding rstest v0.18.2 (available: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.18.2 (available: v0.22.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e99a18c79c33ae9e296421068978aeb06c9c471355bf48d97408a5a3ccc9cf01 [INFO] running `Command { std: "docker" "start" "-a" "e99a18c79c33ae9e296421068978aeb06c9c471355bf48d97408a5a3ccc9cf01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e99a18c79c33ae9e296421068978aeb06c9c471355bf48d97408a5a3ccc9cf01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e99a18c79c33ae9e296421068978aeb06c9c471355bf48d97408a5a3ccc9cf01", kill_on_drop: false }` [INFO] [stdout] e99a18c79c33ae9e296421068978aeb06c9c471355bf48d97408a5a3ccc9cf01 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f08a186b403dc7a671ac3c57c6229859045306034a5d9c01b2e48faf31016540 [INFO] running `Command { std: "docker" "start" "-a" "f08a186b403dc7a671ac3c57c6229859045306034a5d9c01b2e48faf31016540", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking ic-certification v2.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(hash_tree::HashTreeNode>, hash_tree::HashTreeNode>, hash_tree::HashTreeNode>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rb_tree/mod.rs:885:11 [INFO] [stdout] | [INFO] [stdout] 884 | fn three_way_fork(l: HashTree, m: HashTree, r: HashTree) -> HashTree { [INFO] [stdout] | - - - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 885 | match (l.root, m.root, r.root) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(hash_tree::HashTreeNode>, hash_tree::HashTreeNode>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nested_rb_tree.rs:147:11 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn merge_hash_trees(lhs: HashTree, rhs: HashTree) -> HashTree { [INFO] [stdout] | --- --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | match (lhs.root, rhs.root) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-certification` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `(hash_tree::HashTreeNode>, hash_tree::HashTreeNode>, hash_tree::HashTreeNode>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rb_tree/mod.rs:885:11 [INFO] [stdout] | [INFO] [stdout] 884 | fn three_way_fork(l: HashTree, m: HashTree, r: HashTree) -> HashTree { [INFO] [stdout] | - - - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 885 | match (l.root, m.root, r.root) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `hash_tree::HashTree>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rb_tree/tests.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 51 | let mut t = TreeOfBytes::new(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let ht = t.witness(&witness_key[..]); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(hash_tree::HashTreeNode>, hash_tree::HashTreeNode>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nested_rb_tree.rs:147:11 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn merge_hash_trees(lhs: HashTree, rhs: HashTree) -> HashTree { [INFO] [stdout] | --- --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | match (lhs.root, rhs.root) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `hash_tree::HashTree>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nested_rb_tree.rs:422:20 [INFO] [stdout] | [INFO] [stdout] 420 | #[case] merged: HashTree, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | ) { [INFO] [stdout] 422 | assert_eq!(merge_hash_trees(lhs, rhs), merged); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-certification` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "f08a186b403dc7a671ac3c57c6229859045306034a5d9c01b2e48faf31016540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f08a186b403dc7a671ac3c57c6229859045306034a5d9c01b2e48faf31016540", kill_on_drop: false }` [INFO] [stdout] f08a186b403dc7a671ac3c57c6229859045306034a5d9c01b2e48faf31016540