[INFO] fetching crate i2p_client 0.2.9... [INFO] checking i2p_client-0.2.9 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate i2p_client 0.2.9 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate i2p_client 0.2.9 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate i2p_client 0.2.9 [INFO] finished tweaking crates.io crate i2p_client 0.2.9 [INFO] tweaked toml for crates.io crate i2p_client 0.2.9 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate i2p_client 0.2.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5064f7c5748038f9b3c67730ace1887387a197b9cff0d2a16c2b109151ef74a7 [INFO] running `Command { std: "docker" "start" "-a" "5064f7c5748038f9b3c67730ace1887387a197b9cff0d2a16c2b109151ef74a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5064f7c5748038f9b3c67730ace1887387a197b9cff0d2a16c2b109151ef74a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5064f7c5748038f9b3c67730ace1887387a197b9cff0d2a16c2b109151ef74a7", kill_on_drop: false }` [INFO] [stdout] 5064f7c5748038f9b3c67730ace1887387a197b9cff0d2a16c2b109151ef74a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34869a3b1c4edf72a960f88a7419e5c7fe24314b98a0e52d4b3a542910bb48f9 [INFO] running `Command { std: "docker" "start" "-a" "34869a3b1c4edf72a960f88a7419e5c7fe24314b98a0e52d4b3a542910bb48f9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling serde v1.0.105 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling escargot v0.3.1 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking nom v2.2.1 [INFO] [stderr] Checking base64 v0.12.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking predicates v1.0.3 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking simple_logger v1.6.0 [INFO] [stderr] Checking i2p_client v0.2.9 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result, std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:183:15 [INFO] [stdout] | [INFO] [stdout] 175 | let mut conn = SamConnection { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | match conn.handshake() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:66:22 [INFO] [stdout] | [INFO] [stdout] 66 | let new_vec = vec.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[(&str, &str)]` does not implement `Clone`, so calling `clone` on `&[(&str, &str)]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:68:49 [INFO] [stdout] | [INFO] [stdout] 68 | let res = map.get("RESULT").unwrap_or(&"OK").clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:69:48 [INFO] [stdout] | [INFO] [stdout] 69 | let msg = map.get("MESSAGE").unwrap_or(&"").clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:84:22 [INFO] [stdout] | [INFO] [stdout] 84 | let new_vec = vec.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[(&str, &str)]` does not implement `Clone`, so calling `clone` on `&[(&str, &str)]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:86:49 [INFO] [stdout] | [INFO] [stdout] 86 | let res = map.get("RESULT").unwrap_or(&"OK").clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:87:48 [INFO] [stdout] | [INFO] [stdout] 87 | let msg = map.get("MESSAGE").unwrap_or(&"").clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `i2p_client` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "34869a3b1c4edf72a960f88a7419e5c7fe24314b98a0e52d4b3a542910bb48f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34869a3b1c4edf72a960f88a7419e5c7fe24314b98a0e52d4b3a542910bb48f9", kill_on_drop: false }` [INFO] [stdout] 34869a3b1c4edf72a960f88a7419e5c7fe24314b98a0e52d4b3a542910bb48f9