[INFO] fetching crate hugr-passes 0.8.1... [INFO] checking hugr-passes-0.8.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate hugr-passes 0.8.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate hugr-passes 0.8.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hugr-passes 0.8.1 [INFO] finished tweaking crates.io crate hugr-passes 0.8.1 [INFO] tweaked toml for crates.io crate hugr-passes 0.8.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 84 packages to latest compatible versions [INFO] [stderr] Adding approx v0.4.0 (available: v0.5.1) [INFO] [stderr] Adding delegate v0.12.0 (available: v0.13.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding radium v0.7.0 (available: v1.1.0) [INFO] [stderr] Adding smol_str v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding wyz v0.5.1 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 701f870a28f4bfcd3b91c817b56d3fa755f8906e7fc4ac84593750e6cae88973 [INFO] running `Command { std: "docker" "start" "-a" "701f870a28f4bfcd3b91c817b56d3fa755f8906e7fc4ac84593750e6cae88973", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "701f870a28f4bfcd3b91c817b56d3fa755f8906e7fc4ac84593750e6cae88973", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "701f870a28f4bfcd3b91c817b56d3fa755f8906e7fc4ac84593750e6cae88973", kill_on_drop: false }` [INFO] [stdout] 701f870a28f4bfcd3b91c817b56d3fa755f8906e7fc4ac84593750e6cae88973 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f400963ced7aa99c29fad672ea9e543a94b63d1909aa34446fad7b7b4950b7f [INFO] running `Command { std: "docker" "start" "-a" "8f400963ced7aa99c29fad672ea9e543a94b63d1909aa34446fad7b7b4950b7f", kill_on_drop: false }` [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Compiling rstest_macros v0.22.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling typetag-impl v0.2.18 [INFO] [stderr] Compiling delegate v0.12.0 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking context-iterators v0.2.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling delegate v0.13.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking typetag v0.2.18 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking portgraph v0.12.2 [INFO] [stderr] Checking hugr-core v0.9.1 [INFO] [stderr] Checking rstest v0.22.0 [INFO] [stderr] Checking hugr-passes v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nest_cfgs.rs:192:42 [INFO] [stdout] | [INFO] [stdout] 189 | fn all_edges<'a, T: Copy + Clone + PartialEq + Eq + Hash + 'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 192 | ) -> impl Iterator> + '_ { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Map<::PortLinks<'_>, fn((hugr_core::Node, Port)) -> (hugr_core::Node, OutgoingPort)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/non_local.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 16 | hugr.in_value_types(node).filter_map(move |(in_p, _)| { [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let parent = hugr.get_parent(node); [INFO] [stdout] 18 | hugr.linked_outputs(node, in_p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/nest_cfgs.rs:192:42 [INFO] [stdout] | [INFO] [stdout] 189 | fn all_edges<'a, T: Copy + Clone + PartialEq + Eq + Hash + 'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 192 | ) -> impl Iterator> + '_ { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 67 | let expected_edge = Some(EdgeKind::StateOrder); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | optype.other_input(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Map<::PortLinks<'_>, fn((hugr_core::Node, Port)) -> (hugr_core::Node, OutgoingPort)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/non_local.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 16 | hugr.in_value_types(node).filter_map(move |(in_p, _)| { [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let parent = hugr.get_parent(node); [INFO] [stdout] 18 | hugr.linked_outputs(node, in_p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hugr-passes` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `hugr_core::ops::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold/test.rs:262:30 [INFO] [stdout] | [INFO] [stdout] 250 | let reg = [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | ExtensionRegistry::try_new([PRELUDE.to_owned(), logic::EXTENSION.to_owned()]).unwrap(); [INFO] [stdout] 252 | let mut h = build.finish_hugr_with_outputs(r.outputs(), ®).unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | assert_fully_folded(&h, &Value::true_val()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 67 | let expected_edge = Some(EdgeKind::StateOrder); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | optype.other_input(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `hugr_core::Hugr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lower.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 129 | fn test_lower(noop_hugr: Hugr, identity_hugr: Hugr) { [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let mut h = noop_hugr; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hugr-passes` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8f400963ced7aa99c29fad672ea9e543a94b63d1909aa34446fad7b7b4950b7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f400963ced7aa99c29fad672ea9e543a94b63d1909aa34446fad7b7b4950b7f", kill_on_drop: false }` [INFO] [stdout] 8f400963ced7aa99c29fad672ea9e543a94b63d1909aa34446fad7b7b4950b7f