[INFO] fetching crate hoard 0.6.1... [INFO] checking hoard-0.6.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate hoard 0.6.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate hoard 0.6.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hoard 0.6.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate hoard 0.6.1 [INFO] tweaked toml for crates.io crate hoard 0.6.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate hoard 0.6.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bdd7a73cc2621fc869c510deac73d70c818875e0b8707a4d46e2487d4d2e8f98 [INFO] running `Command { std: "docker" "start" "-a" "bdd7a73cc2621fc869c510deac73d70c818875e0b8707a4d46e2487d4d2e8f98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bdd7a73cc2621fc869c510deac73d70c818875e0b8707a4d46e2487d4d2e8f98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bdd7a73cc2621fc869c510deac73d70c818875e0b8707a4d46e2487d4d2e8f98", kill_on_drop: false }` [INFO] [stdout] bdd7a73cc2621fc869c510deac73d70c818875e0b8707a4d46e2487d4d2e8f98 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 23159c99cb077bb4b72bfd7c4fb0180d0bd4ebb6ea4af662a1bdfe99ca8a5b69 [INFO] running `Command { std: "docker" "start" "-a" "23159c99cb077bb4b72bfd7c4fb0180d0bd4ebb6ea4af662a1bdfe99ca8a5b69", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.157 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking path-clean v0.1.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking sdd v3.0.2 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking scc v2.1.16 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking hostname v0.4.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling serial_test_derive v3.1.1 [INFO] [stderr] Checking serial_test v3.1.1 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pty_closure v0.1.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking open_cmd v0.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde_test v1.0.177 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking hoard v0.6.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hoard/iter/all_files.rs:419:32 [INFO] [stdout] | [INFO] [stdout] 418 | let stream = async_stream::try_stream! { [INFO] [stdout] | __________________- [INFO] [stdout] | |__________________| [INFO] [stdout] 419 | | while let Some(item) = all_files.next_item().await { [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 420 | | yield item?; [INFO] [stdout] 421 | | } [INFO] [stdout] 422 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hoard/iter/all_files.rs:419:32 [INFO] [stdout] | [INFO] [stdout] 418 | let stream = async_stream::try_stream! { [INFO] [stdout] | __________________- [INFO] [stdout] | |__________________| [INFO] [stdout] 419 | | while let Some(item) = all_files.next_item().await { [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 420 | | yield item?; [INFO] [stdout] 421 | | } [INFO] [stdout] 422 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::iter::Zip, std::vec::IntoIter>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkers/history/operation/v2.rs:528:35 [INFO] [stdout] | [INFO] [stdout] 526 | let mut file_set = HashSet::new(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 527 | [INFO] [stdout] 528 | for (op_v1, op_v2) in ops_v1.into_iter().zip(ops_v2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `environment::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/builder/environment/mod.rs:262:17 [INFO] [stdout] | [INFO] [stdout] 256 | let err = condition [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | err => panic!("unexpected error: {err}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `environment::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/builder/environment/mod.rs:286:17 [INFO] [stdout] | [INFO] [stdout] 281 | let err = condition [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | err => panic!("unexpected error: {err}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `environment::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/builder/environment/mod.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 323 | let err = condition [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | err => panic!("unexpected error: {err}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `environment::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/builder/environment/mod.rs:352:17 [INFO] [stdout] | [INFO] [stdout] 347 | let err = condition [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | err => panic!("unexpected error: {err}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hoard` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: missing documentation for an enum [INFO] [stdout] --> src/test.rs:49:1 [INFO] [stdout] | [INFO] [stdout] 49 | pub enum Error { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | missing_docs, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a variant [INFO] [stdout] --> src/test.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | IO(#[from] io::Error), [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a variant [INFO] [stdout] --> src/test.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | Uuid(#[from] uuid::Error), [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a struct [INFO] [stdout] --> src/test.rs:57:1 [INFO] [stdout] | [INFO] [stdout] 57 | pub struct Tester { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hoard` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "23159c99cb077bb4b72bfd7c4fb0180d0bd4ebb6ea4af662a1bdfe99ca8a5b69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23159c99cb077bb4b72bfd7c4fb0180d0bd4ebb6ea4af662a1bdfe99ca8a5b69", kill_on_drop: false }` [INFO] [stdout] 23159c99cb077bb4b72bfd7c4fb0180d0bd4ebb6ea4af662a1bdfe99ca8a5b69