[INFO] fetching crate hipstr 0.5.1... [INFO] checking hipstr-0.5.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate hipstr 0.5.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate hipstr 0.5.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hipstr 0.5.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate hipstr 0.5.1 [INFO] tweaked toml for crates.io crate hipstr 0.5.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c887e0cd47ee9e095cce55de0a701c81fe6631fe192a1621f94981603953c414 [INFO] running `Command { std: "docker" "start" "-a" "c887e0cd47ee9e095cce55de0a701c81fe6631fe192a1621f94981603953c414", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c887e0cd47ee9e095cce55de0a701c81fe6631fe192a1621f94981603953c414", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c887e0cd47ee9e095cce55de0a701c81fe6631fe192a1621f94981603953c414", kill_on_drop: false }` [INFO] [stdout] c887e0cd47ee9e095cce55de0a701c81fe6631fe192a1621f94981603953c414 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90b4abc229847afa90775c5756bf2bfbbdc58b9cccb12defc06c1a70168f0957 [INFO] running `Command { std: "docker" "start" "-a" "90b4abc229847afa90775c5756bf2bfbbdc58b9cccb12defc06c1a70168f0957", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking serde_test v1.0.177 [INFO] [stderr] Checking hipstr v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `bytes::HipByt<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bytes/tests.rs:1135:20 [INFO] [stdout] | [INFO] [stdout] 1115 | let a = H::borrowed(s.as_slice()); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1123 | let a = H::from(s.as_slice()); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1132 | let a = H::from(s); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1135 | assert_eq!(a.slice_ref_unchecked(&a[0..1]), b"*"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `string::HipStr<'_, backend::rc::ThreadSafe>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string/tests.rs:930:20 [INFO] [stdout] | [INFO] [stdout] 910 | let a = H::borrowed(s.as_str()); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 918 | let a = H::from(s.as_str()); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 927 | let a = H::from(s); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 930 | assert_eq!(a.slice_ref_unchecked(&a[0..1]), "*"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>, std::option::Option<&str>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/string/tests.rs:1129:15 [INFO] [stdout] | [INFO] [stdout] 1125 | mut computed: impl Iterator>, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1126 | mut expected: impl Iterator, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1129 | match (computed.next(), expected.next()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `os_string::HipOsStr<'_, backend::rc::ThreadSafe>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_string/tests.rs:392:13 [INFO] [stdout] | [INFO] [stdout] 373 | let ho = HipOsStr::from(s); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | assert!(ho.is_allocated()); [INFO] [stdout] 375 | let hs = ho.to_str_lossy(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let ho = HipOsStr::from(OsStr::from_bytes(bytes)); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `os_string::HipOsStr<'_, backend::rc::ThreadSafe>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os_string/tests.rs:430:20 [INFO] [stdout] | [INFO] [stdout] 410 | let a = HipOsStr::borrowed(s.as_str()); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | let a = HipOsStr::from(s.as_str()); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 427 | let a = HipOsStr::from(s); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 430 | assert_eq!(a.slice_ref_unchecked(sl(&a, 0..1)).as_encoded_bytes(), b"*"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hipstr` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "90b4abc229847afa90775c5756bf2bfbbdc58b9cccb12defc06c1a70168f0957", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90b4abc229847afa90775c5756bf2bfbbdc58b9cccb12defc06c1a70168f0957", kill_on_drop: false }` [INFO] [stdout] 90b4abc229847afa90775c5756bf2bfbbdc58b9cccb12defc06c1a70168f0957