[INFO] fetching crate headers 0.4.0... [INFO] checking headers-0.4.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate headers 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate headers 0.4.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate headers 0.4.0 [INFO] finished tweaking crates.io crate headers 0.4.0 [INFO] tweaked toml for crates.io crate headers 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2fed581dbf8150c7b115e0f02387751337b35684acb09b6be2c92a9f2f12bcc [INFO] running `Command { std: "docker" "start" "-a" "c2fed581dbf8150c7b115e0f02387751337b35684acb09b6be2c92a9f2f12bcc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2fed581dbf8150c7b115e0f02387751337b35684acb09b6be2c92a9f2f12bcc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2fed581dbf8150c7b115e0f02387751337b35684acb09b6be2c92a9f2f12bcc", kill_on_drop: false }` [INFO] [stdout] c2fed581dbf8150c7b115e0f02387751337b35684acb09b6be2c92a9f2f12bcc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf52356433a58ba97974e9801b6a4c1ec09101d220147333af10d76d53facc7f [INFO] running `Command { std: "docker" "start" "-a" "cf52356433a58ba97974e9801b6a4c1ec09101d220147333af10d76d53facc7f", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking headers v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/fmt.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn fmt(fmt: T) -> HeaderValue { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | let s = fmt.to_string(); [INFO] [stdout] 7 | match HeaderValue::from_maybe_shared(s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/iter.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 3 | let one = self.next()?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 4 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/connection.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn contains(&self, name: impl AsConnectionOption) -> bool { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let s = name.as_connection_option(); [INFO] [stdout] 90 | / self.0 [INFO] [stdout] 91 | | .iter() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/content_encoding.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn contains(&self, coding: impl AsCoding) -> bool { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let s = coding.as_coding(); [INFO] [stdout] 68 | self.0.iter().find(|&opt| opt == s).is_some() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/entity.rs:156:15 [INFO] [stdout] | [INFO] [stdout] 155 | let val = HeaderValue::from_static(bytes); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | match EntityTag::from_val(&val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `headers` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/fmt.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn fmt(fmt: T) -> HeaderValue { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | let s = fmt.to_string(); [INFO] [stdout] 7 | match HeaderValue::from_maybe_shared(s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/iter.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 3 | let one = self.next()?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 4 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/connection.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn contains(&self, name: impl AsConnectionOption) -> bool { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let s = name.as_connection_option(); [INFO] [stdout] 90 | / self.0 [INFO] [stdout] 91 | | .iter() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/content_encoding.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn contains(&self, coding: impl AsCoding) -> bool { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let s = coding.as_coding(); [INFO] [stdout] 68 | self.0.iter().find(|&opt| opt == s).is_some() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `headers` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "cf52356433a58ba97974e9801b6a4c1ec09101d220147333af10d76d53facc7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf52356433a58ba97974e9801b6a4c1ec09101d220147333af10d76d53facc7f", kill_on_drop: false }` [INFO] [stdout] cf52356433a58ba97974e9801b6a4c1ec09101d220147333af10d76d53facc7f