[INFO] fetching crate hashmap_settings 0.5.1... [INFO] checking hashmap_settings-0.5.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate hashmap_settings 0.5.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate hashmap_settings 0.5.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate hashmap_settings 0.5.1 [INFO] finished tweaking crates.io crate hashmap_settings 0.5.1 [INFO] tweaked toml for crates.io crate hashmap_settings 0.5.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0454ad299cfde933c9876c1b74ec026c7b6bfe2d5e76522ec4274779c02f1e23 [INFO] running `Command { std: "docker" "start" "-a" "0454ad299cfde933c9876c1b74ec026c7b6bfe2d5e76522ec4274779c02f1e23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0454ad299cfde933c9876c1b74ec026c7b6bfe2d5e76522ec4274779c02f1e23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0454ad299cfde933c9876c1b74ec026c7b6bfe2d5e76522ec4274779c02f1e23", kill_on_drop: false }` [INFO] [stdout] 0454ad299cfde933c9876c1b74ec026c7b6bfe2d5e76522ec4274779c02f1e23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39878f80ab30bc37f454bf8aded40ce3bae2709c0e113a4f0b73b844d9d95c47 [INFO] running `Command { std: "docker" "start" "-a" "39878f80ab30bc37f454bf8aded40ce3bae2709c0e113a4f0b73b844d9d95c47", kill_on_drop: false }` [INFO] [stderr] Checking dyn_ord v0.2.1 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking hashmap_settings v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result, DeepError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/account/mod.rs:1149:19 [INFO] [stdout] | [INFO] [stdout] 1137 | setting_value: V, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1149 | match found_account.deep_insert(setting_name, setting_value, account_names) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, DeepError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/account/mod.rs:1763:19 [INFO] [stdout] | [INFO] [stdout] 1741 | account: Self, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1763 | match found_account.deep_push_helper(account, valid, account_names) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stg/mod.rs:94:14 [INFO] [stdout] | [INFO] [stdout] 92 | let x: Box = self.clone(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let y: Box = other.clone(); [INFO] [stdout] 94 | x == y [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stg/mod.rs:226:10 [INFO] [stdout] | [INFO] [stdout] 224 | pub fn unstg_panic(self) -> S { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let x: Box = self.value; [INFO] [stdout] 226 | *x.downcast().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, DeepError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/account/mod.rs:1149:19 [INFO] [stdout] | [INFO] [stdout] 1137 | setting_value: V, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1149 | match found_account.deep_insert(setting_name, setting_value, account_names) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, DeepError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/account/mod.rs:1763:19 [INFO] [stdout] | [INFO] [stdout] 1741 | account: Self, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1763 | match found_account.deep_push_helper(account, valid, account_names) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stg/mod.rs:94:14 [INFO] [stdout] | [INFO] [stdout] 92 | let x: Box = self.clone(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let y: Box = other.clone(); [INFO] [stdout] 94 | x == y [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stg/mod.rs:226:10 [INFO] [stdout] | [INFO] [stdout] 224 | pub fn unstg_panic(self) -> S { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let x: Box = self.value; [INFO] [stdout] 226 | *x.downcast().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hashmap_settings` (lib test) due to 5 previous errors [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hashmap_settings` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "39878f80ab30bc37f454bf8aded40ce3bae2709c0e113a4f0b73b844d9d95c47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39878f80ab30bc37f454bf8aded40ce3bae2709c0e113a4f0b73b844d9d95c47", kill_on_drop: false }` [INFO] [stdout] 39878f80ab30bc37f454bf8aded40ce3bae2709c0e113a4f0b73b844d9d95c47