[INFO] fetching crate halo2_gadgets 0.3.0... [INFO] checking halo2_gadgets-0.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate halo2_gadgets 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate halo2_gadgets 0.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate halo2_gadgets 0.3.0 [INFO] finished tweaking crates.io crate halo2_gadgets 0.3.0 [INFO] tweaked toml for crates.io crate halo2_gadgets 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 195 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (available: v0.8.11) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding clap v3.2.25 (available: v4.5.18) [INFO] [stderr] Adding clap_derive v3.2.25 (available: v4.5.18) [INFO] [stderr] Adding clap_lex v0.2.4 (available: v0.7.2) [INFO] [stderr] Adding cpp_demangle v0.3.5 (available: v0.4.4) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (available: v0.5.0) [INFO] [stderr] Adding darling v0.10.2 (available: v0.20.10) [INFO] [stderr] Adding darling_core v0.10.2 (available: v0.20.10) [INFO] [stderr] Adding darling_macro v0.10.2 (available: v0.20.10) [INFO] [stderr] Adding dashmap v5.5.3 (available: v6.1.0) [INFO] [stderr] Adding debugid v0.7.3 (available: v0.8.0) [INFO] [stderr] Adding derive_builder v0.9.0 (available: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.9.0 (available: v0.20.1) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.5) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding image v0.24.9 (available: v0.25.2) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding inferno v0.11.4 (available: v0.11.21) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding memmap2 v0.5.10 (available: v0.9.5) [INFO] [stderr] Adding memoffset v0.6.5 (available: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (available: v0.8.0) [INFO] [stderr] Adding nix v0.23.2 (available: v0.29.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (available: v7.0.0) [INFO] [stderr] Adding pprof v0.8.0 (available: v0.13.0) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding quick-xml v0.23.1 (available: v0.36.2) [INFO] [stderr] Adding radium v0.7.0 (available: v1.1.0) [INFO] [stderr] Adding strsim v0.9.3 (available: v0.11.1) [INFO] [stderr] Adding strsim v0.10.0 (available: v0.11.1) [INFO] [stderr] Adding symbolic-common v8.8.0 (available: v12.11.1) [INFO] [stderr] Adding symbolic-demangle v8.8.0 (available: v12.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding tabbycat v0.1.2 (available: v0.1.3) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding uint v0.9.5 (available: v0.10.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding uuid v0.8.2 (available: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding wyz v0.5.1 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 99f899c521c9355720c9301da81ad7cc1b415ce596eaec708ea57c9981b09aa4 [INFO] running `Command { std: "docker" "start" "-a" "99f899c521c9355720c9301da81ad7cc1b415ce596eaec708ea57c9981b09aa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "99f899c521c9355720c9301da81ad7cc1b415ce596eaec708ea57c9981b09aa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99f899c521c9355720c9301da81ad7cc1b415ce596eaec708ea57c9981b09aa4", kill_on_drop: false }` [INFO] [stdout] 99f899c521c9355720c9301da81ad7cc1b415ce596eaec708ea57c9981b09aa4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3419a3d91f738bcf3bfaa53cfefc558c50bf03b3d2ebea2c8a545631a11e6e66 [INFO] running `Command { std: "docker" "start" "-a" "3419a3d91f738bcf3bfaa53cfefc558c50bf03b3d2ebea2c8a545631a11e6e66", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Compiling cpp_demangle v0.3.5 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Compiling findshlibs v0.10.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Compiling symbolic-demangle v8.8.0 [INFO] [stderr] Checking debugid v0.7.3 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking symbolic-common v8.8.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking quick-xml v0.23.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking str_stack v0.1.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling pprof v0.8.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking pasta_curves v0.5.1 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking halo2_proofs v0.3.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking halo2_gadgets v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking inferno v0.11.4 [INFO] [stdout] error: this value of type `Point` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecc.rs:284:14 [INFO] [stdout] | [INFO] [stdout] 278 | mut layouter: impl Layouter, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | let other: Point = (other.clone()).into(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | &Point::::from(self.clone()).inner, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `>::NonIdentityPoint` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecc.rs:348:45 [INFO] [stdout] | [INFO] [stdout] 343 | mut layouter: impl Layouter, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | by: ScalarVar, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | .mul(&mut layouter, &by.inner, &self.inner.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `poseidon::Sponge>::Word, RATE>, ConstantLength, T, RATE>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poseidon.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 279 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | mut layouter: impl Layouter, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | / self.sponge [INFO] [stdout] 293 | | .finish_absorbing(layouter.namespace(|| "finish absorbing"))? [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `halo2_gadgets` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Point` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecc.rs:284:14 [INFO] [stdout] | [INFO] [stdout] 278 | mut layouter: impl Layouter, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | let other: Point = (other.clone()).into(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | &Point::::from(self.clone()).inner, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `>::NonIdentityPoint` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecc.rs:348:45 [INFO] [stdout] | [INFO] [stdout] 343 | mut layouter: impl Layouter, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | by: ScalarVar, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | .mul(&mut layouter, &by.inner, &self.inner.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `poseidon::Sponge>::Word, RATE>, ConstantLength, T, RATE>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poseidon.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 279 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | mut layouter: impl Layouter, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | / self.sponge [INFO] [stdout] 293 | | .finish_absorbing(layouter.namespace(|| "finish absorbing"))? [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a module [INFO] [stdout] --> src/sinsemilla/merkle.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | pub mod tests { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | #![deny(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a method [INFO] [stdout] --> src/utilities/lookup_range_check.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn load(&self, layouter: &mut impl Layouter) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `halo2_gadgets` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "3419a3d91f738bcf3bfaa53cfefc558c50bf03b3d2ebea2c8a545631a11e6e66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3419a3d91f738bcf3bfaa53cfefc558c50bf03b3d2ebea2c8a545631a11e6e66", kill_on_drop: false }` [INFO] [stdout] 3419a3d91f738bcf3bfaa53cfefc558c50bf03b3d2ebea2c8a545631a11e6e66