[INFO] fetching crate gvfs 0.1.2... [INFO] checking gvfs-0.1.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate gvfs 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate gvfs 0.1.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gvfs 0.1.2 [INFO] finished tweaking crates.io crate gvfs 0.1.2 [INFO] tweaked toml for crates.io crate gvfs 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 60 packages to latest compatible versions [INFO] [stderr] Adding cargo_metadata v0.14.2 (available: v0.18.1) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding directories v2.0.2 (available: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (available: v0.4.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (available: v0.12.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding zip v0.5.13 (available: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba779409a91ab7b8248ca8f8cc3a0f749786dc768f5f065e4a0cd3a783a6b1fc [INFO] running `Command { std: "docker" "start" "-a" "ba779409a91ab7b8248ca8f8cc3a0f749786dc768f5f065e4a0cd3a783a6b1fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba779409a91ab7b8248ca8f8cc3a0f749786dc768f5f065e4a0cd3a783a6b1fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba779409a91ab7b8248ca8f8cc3a0f749786dc768f5f065e4a0cd3a783a6b1fc", kill_on_drop: false }` [INFO] [stdout] ba779409a91ab7b8248ca8f8cc3a0f749786dc768f5f065e4a0cd3a783a6b1fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c993dba7280ac7be5ba010b1b730442d34d15aa1c7324c42df9fc270e5ac824 [INFO] running `Command { std: "docker" "start" "-a" "5c993dba7280ac7be5ba010b1b730442d34d15aa1c7324c42df9fc270e5ac824", kill_on_drop: false }` [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling bytecount v0.6.8 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking cargo_metadata v0.14.2 [INFO] [stderr] Checking skeptic v0.13.7 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Compiling gvfs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | format!("Zip error: {}", e.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | format!("Zip error: {}", e.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:396:19 [INFO] [stdout] | [INFO] [stdout] 383 | let mut fs = dummy_fs_for_tests(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | match fs.open("/ooglebooglebarg.txt") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<&str, Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:763:27 [INFO] [stdout] | [INFO] [stdout] 760 | let mut stupid_archive_borrow = self.archive [INFO] [stdout] | ------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 763 | if let Ok(path) = convenient_path_to_str(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `resources_path`, `zip_path`, `user_config_path`, and `user_data_path` are never read [INFO] [stdout] --> src/filesystem.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct Filesystem { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 43 | vfs: vfs::OverlayFS, [INFO] [stdout] 44 | resources_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 45 | zip_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 46 | user_config_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 47 | user_data_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Filesystem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<&str, Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:763:27 [INFO] [stdout] | [INFO] [stdout] 760 | let mut stupid_archive_borrow = self.archive [INFO] [stdout] | ------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 763 | if let Ok(path) = convenient_path_to_str(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gvfs` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `resources_path`, `zip_path`, `user_config_path`, and `user_data_path` are never read [INFO] [stdout] --> src/filesystem.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct Filesystem { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 43 | vfs: vfs::OverlayFS, [INFO] [stdout] 44 | resources_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 45 | zip_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 46 | user_config_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 47 | user_data_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Filesystem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gvfs` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5c993dba7280ac7be5ba010b1b730442d34d15aa1c7324c42df9fc270e5ac824", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c993dba7280ac7be5ba010b1b730442d34d15aa1c7324c42df9fc270e5ac824", kill_on_drop: false }` [INFO] [stdout] 5c993dba7280ac7be5ba010b1b730442d34d15aa1c7324c42df9fc270e5ac824