[INFO] fetching crate gsm 1.3.0... [INFO] checking gsm-1.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate gsm 1.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gsm 1.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gsm 1.3.0 [INFO] finished tweaking crates.io crate gsm 1.3.0 [INFO] tweaked toml for crates.io crate gsm 1.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.5.6 (available: v1.7.2) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding semver v0.10.0 (available: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (available: v0.10.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 861b89c83a6b503d408d2ea8eeed344d5c01c38429d481897dd194270d67bbd9 [INFO] running `Command { std: "docker" "start" "-a" "861b89c83a6b503d408d2ea8eeed344d5c01c38429d481897dd194270d67bbd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "861b89c83a6b503d408d2ea8eeed344d5c01c38429d481897dd194270d67bbd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "861b89c83a6b503d408d2ea8eeed344d5c01c38429d481897dd194270d67bbd9", kill_on_drop: false }` [INFO] [stdout] 861b89c83a6b503d408d2ea8eeed344d5c01c38429d481897dd194270d67bbd9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aee5b7225ec0d03aba37d5ac2c984311c3f73391f7d5e0836814282e0322d483 [INFO] running `Command { std: "docker" "start" "-a" "aee5b7225ec0d03aba37d5ac2c984311c3f73391f7d5e0836814282e0322d483", kill_on_drop: false }` [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking semver v0.10.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking gsm v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/file_io.rs:288:11 [INFO] [stdout] | [INFO] [stdout] 281 | let mut machine = Machine::from(script); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | let mut result = machine.execute(&FileIO).unwrap(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 288 | match result.pop() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/file_io.rs:328:11 [INFO] [stdout] | [INFO] [stdout] 321 | let mut machine = Machine::from(script); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | let mut result = machine.execute(&FileIO).unwrap(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | match result.pop() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/file_io.rs:354:11 [INFO] [stdout] | [INFO] [stdout] 347 | let mut machine = Machine::from(script); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | let mut result = machine.execute(&FileIO).unwrap(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | match result.pop() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/file_io.rs:239:28 [INFO] [stdout] | [INFO] [stdout] 239 | panic!(format!("{}", e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 239 - panic!(format!("{}", e)); [INFO] [stdout] 239 + panic!("{}", e); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/file_io.rs:245:28 [INFO] [stdout] | [INFO] [stdout] 245 | panic!(format!("{}", e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 245 - panic!(format!("{}", e)); [INFO] [stdout] 245 + panic!("{}", e); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/file_io.rs:251:28 [INFO] [stdout] | [INFO] [stdout] 251 | panic!(format!("{}", e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 251 - panic!(format!("{}", e)); [INFO] [stdout] 251 + panic!("{}", e); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/file_io.rs:257:28 [INFO] [stdout] | [INFO] [stdout] 257 | panic!(format!("{}", e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 257 - panic!(format!("{}", e)); [INFO] [stdout] 257 + panic!("{}", e); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/file_io.rs:263:28 [INFO] [stdout] | [INFO] [stdout] 263 | panic!(format!("{}", e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 263 - panic!(format!("{}", e)); [INFO] [stdout] 263 + panic!("{}", e); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gsm` (test "file_io") due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "aee5b7225ec0d03aba37d5ac2c984311c3f73391f7d5e0836814282e0322d483", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aee5b7225ec0d03aba37d5ac2c984311c3f73391f7d5e0836814282e0322d483", kill_on_drop: false }` [INFO] [stdout] aee5b7225ec0d03aba37d5ac2c984311c3f73391f7d5e0836814282e0322d483