[INFO] fetching crate goodmetrics 6.0.0... [INFO] checking goodmetrics-6.0.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate goodmetrics 6.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate goodmetrics 6.0.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate goodmetrics 6.0.0 [INFO] finished tweaking crates.io crate goodmetrics 6.0.0 [INFO] tweaked toml for crates.io crate goodmetrics 6.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 229 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding bindgen v0.69.4 (available: v0.70.1) [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding matchit v0.7.3 (available: v0.8.4) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding sync_wrapper v0.1.2 (available: v1.0.1) [INFO] [stderr] Adding tower v0.4.13 (available: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (available: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ffd89be0b99231b74a7986339274b361dc14006006db730503fc56434b4a6de4 [INFO] running `Command { std: "docker" "start" "-a" "ffd89be0b99231b74a7986339274b361dc14006006db730503fc56434b4a6de4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ffd89be0b99231b74a7986339274b361dc14006006db730503fc56434b4a6de4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffd89be0b99231b74a7986339274b361dc14006006db730503fc56434b4a6de4", kill_on_drop: false }` [INFO] [stdout] ffd89be0b99231b74a7986339274b361dc14006006db730503fc56434b4a6de4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 48633ce512d71603834665606185308f062f206d05c2a53fbea678f9038ff9b1 [INFO] running `Command { std: "docker" "start" "-a" "48633ce512d71603834665606185308f062f206d05c2a53fbea678f9038ff9b1", kill_on_drop: false }` [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling aws-lc-rs v1.9.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking mirai-annotations v1.12.0 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling rustls v0.23.13 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Checking rustls-native-certs v0.8.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking ordered-float v4.3.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking webpki-roots v0.26.6 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling aws-lc-sys v0.21.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling prost-derive v0.13.3 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking prost v0.13.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tower v0.5.1 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking futures-batch v0.6.1 [INFO] [stderr] Checking axum-core v0.4.4 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking axum v0.7.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Checking hyper-timeout v0.5.1 [INFO] [stderr] Checking hyper-rustls v0.27.3 [INFO] [stderr] Checking tonic v0.12.2 [INFO] [stderr] Checking goodmetrics v6.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, types::Dimension>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:80:10 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn set(self, dimension: impl Into) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | *self.value.lock().expect("local mutex") = dimension.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goodmetrics` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, types::Dimension>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:80:10 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn set(self, dimension: impl Into) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | *self.value.lock().expect("local mutex") = dimension.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goodmetrics` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "48633ce512d71603834665606185308f062f206d05c2a53fbea678f9038ff9b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48633ce512d71603834665606185308f062f206d05c2a53fbea678f9038ff9b1", kill_on_drop: false }` [INFO] [stdout] 48633ce512d71603834665606185308f062f206d05c2a53fbea678f9038ff9b1