[INFO] fetching crate gluon_check 0.18.2... [INFO] checking gluon_check-0.18.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate gluon_check 0.18.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate gluon_check 0.18.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gluon_check 0.18.2 [INFO] finished tweaking crates.io crate gluon_check 0.18.2 [INFO] tweaked toml for crates.io crate gluon_check 0.18.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 110 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (available: v0.8.11) [INFO] [stderr] Adding archery v0.4.0 (available: v1.2.1) [INFO] [stderr] Adding arrayvec v0.5.2 (available: v0.7.6) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.5) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding hashbrown v0.11.2 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding lalrpop v0.19.12 (available: v0.21.0) [INFO] [stderr] Adding lalrpop-util v0.19.12 (available: v0.21.0) [INFO] [stderr] Adding ordered-float v2.10.1 (available: v4.3.0) [INFO] [stderr] Adding phf_shared v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding pretty v0.10.0 (available: v0.12.3) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding rpds v0.10.0 (available: v1.1.0) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding strsim v0.10.0 (available: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding term v0.7.0 (available: v1.0.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8bac96509bab4977c68d5d9d56378ce95d028e586456a26e62765a56da534d25 [INFO] running `Command { std: "docker" "start" "-a" "8bac96509bab4977c68d5d9d56378ce95d028e586456a26e62765a56da534d25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8bac96509bab4977c68d5d9d56378ce95d028e586456a26e62765a56da534d25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bac96509bab4977c68d5d9d56378ce95d028e586456a26e62765a56da534d25", kill_on_drop: false }` [INFO] [stdout] 8bac96509bab4977c68d5d9d56378ce95d028e586456a26e62765a56da534d25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd59d7bcd683397eb2789c56addbd76b4cc6e799cc673b9353e81aeec1f43a5d [INFO] running `Command { std: "docker" "start" "-a" "dd59d7bcd683397eb2789c56addbd76b4cc6e799cc673b9353e81aeec1f43a5d", kill_on_drop: false }` [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Compiling lalrpop-util v0.19.12 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking pretty v0.10.0 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking collect-mac v0.1.0 [INFO] [stderr] Checking archery v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking rpds v0.10.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking codespan v0.11.1 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling is-terminal v0.4.13 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Compiling gluon_codegen v0.18.2 [INFO] [stderr] Checking gluon_base v0.18.2 [INFO] [stderr] Checking gluon_format v0.18.2 [INFO] [stderr] Checking gluon_check v0.18.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `serde_derive` [INFO] [stdout] --> src/metadata.rs:3:7 [INFO] [stdout] | [INFO] [stdout] 3 | #[cfg(feature = "serde_derive")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `serde_derive` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `TypeExt` and `TypePtr` [INFO] [stdout] --> src/typ.rs:1:56 [INFO] [stdout] | [INFO] [stdout] 1 | pub use crate::base::types::{ArcType as RcType, Flags, TypeExt, TypePtr}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kindcheck.rs:45:11 [INFO] [stdout] | [INFO] [stdout] 41 | fn walk_move_kind(kind: ArcKind, f: &mut F) -> ArcKind [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | match walk_move_kind2(&kind, f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), (usize, T)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substitution.rs:291:23 [INFO] [stdout] | [INFO] [stdout] 283 | pub fn insert(&self, var: u32, t: T) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | match self.types.try_insert(var as usize, t.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `TypeGeneralizer<'_, '_, '_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/typecheck.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 383 | let typ = self.subs.hole(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | TypeGeneralizer::new(level, self, &typ, expr.span).generalize_variables(args, expr) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, ArcType>>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/typecheck.rs:2700:15 [INFO] [stdout] | [INFO] [stdout] 2696 | actual: RcType, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2700 | match unify_type::subsumes(&self.subs, state, &expected, &actual) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, ArcType>>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/typecheck.rs:2749:15 [INFO] [stdout] | [INFO] [stdout] 2740 | actual: RcType, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2749 | match unify_type::subsumes(&self.subs, state, &expected, &actual) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, ArcType>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/typecheck.rs:2882:15 [INFO] [stdout] | [INFO] [stdout] 2879 | fn unify(&self, expected: &RcType, actual: RcType) -> TcResult { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2882 | match unify::unify(&self.subs, state, expected, &actual) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/implicits.rs:155:31 [INFO] [stdout] | [INFO] [stdout] 151 | fn insert_(&mut self, mut iter: impl Iterator, value: &T) -> bool [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | if let Some(symbol) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, implicits::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/implicits.rs:346:15 [INFO] [stdout] | [INFO] [stdout] 345 | let mut to_resolve = Vec::new(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | match self.find_implicit( [INFO] [stdout] | _______________^ [INFO] [stdout] 347 | | implicit_bindings, [INFO] [stdout] 348 | | &mut to_resolve, [INFO] [stdout] 349 | | &Demand { [INFO] [stdout] ... | [INFO] [stdout] 352 | | }, [INFO] [stdout] 353 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, ArcType>>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/implicits.rs:524:9 [INFO] [stdout] | [INFO] [stdout] 515 | let binding_type = self.tc.instantiate_generics(&binding_type); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 524 | crate::unify_type::subsumes(&self.tc.subs, state, &demand.constraint, &iter.typ).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `has_data` is never used [INFO] [stdout] --> src/metadata.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 22 | trait ArcMetadata: Into> { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 25 | fn has_data(&self) -> bool; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gluon_check` (lib) due to 10 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "dd59d7bcd683397eb2789c56addbd76b4cc6e799cc673b9353e81aeec1f43a5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd59d7bcd683397eb2789c56addbd76b4cc6e799cc673b9353e81aeec1f43a5d", kill_on_drop: false }` [INFO] [stdout] dd59d7bcd683397eb2789c56addbd76b4cc6e799cc673b9353e81aeec1f43a5d