[INFO] fetching crate fp-collections 0.0.2... [INFO] checking fp-collections-0.0.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate fp-collections 0.0.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate fp-collections 0.0.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fp-collections 0.0.2 [INFO] finished tweaking crates.io crate fp-collections 0.0.2 [INFO] tweaked toml for crates.io crate fp-collections 0.0.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate fp-collections 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b581591e900f21d6e3942e771470427b82b9cb0320f82b0f1e3b86588d2b28c [INFO] running `Command { std: "docker" "start" "-a" "6b581591e900f21d6e3942e771470427b82b9cb0320f82b0f1e3b86588d2b28c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b581591e900f21d6e3942e771470427b82b9cb0320f82b0f1e3b86588d2b28c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b581591e900f21d6e3942e771470427b82b9cb0320f82b0f1e3b86588d2b28c", kill_on_drop: false }` [INFO] [stdout] 6b581591e900f21d6e3942e771470427b82b9cb0320f82b0f1e3b86588d2b28c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ea8eff4568feb18e808581b1e73fb25fd48572bcb8f3e9f653c9281c2a27d94 [INFO] running `Command { std: "docker" "start" "-a" "1ea8eff4568feb18e808581b1e73fb25fd48572bcb8f3e9f653c9281c2a27d94", kill_on_drop: false }` [INFO] [stderr] Checking fp-collections v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/list.rs:55:10 [INFO] [stdout] | [INFO] [stdout] 55 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/list.rs:122:10 [INFO] [stdout] | [INFO] [stdout] 122 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/list.rs:219:10 [INFO] [stdout] | [INFO] [stdout] 219 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/list.rs:55:10 [INFO] [stdout] | [INFO] [stdout] 55 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/set.rs:37:10 [INFO] [stdout] | [INFO] [stdout] 37 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/list.rs:122:10 [INFO] [stdout] | [INFO] [stdout] 122 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/list.rs:219:10 [INFO] [stdout] | [INFO] [stdout] 219 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/set.rs:37:10 [INFO] [stdout] | [INFO] [stdout] 37 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `List` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 193 | let l1 = self.clone().chop(ln / 2); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let l2 = self.clone().reverse().chop(ln - (ln / 2)); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | l1.sort_by(cmpfn).merge(cmpfn, &l2.sort_by(cmpfn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `List` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 193 | let l1 = self.clone().chop(ln / 2); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let l2 = self.clone().reverse().chop(ln - (ln / 2)); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | l1.sort_by(cmpfn).merge(cmpfn, &l2.sort_by(cmpfn)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Set` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn add(self, x: T) -> Self { [INFO] [stdout] | ---- - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | match self.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Set` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn add(self, x: T) -> Self { [INFO] [stdout] | ---- - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | match self.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Set` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:133:15 [INFO] [stdout] | [INFO] [stdout] 132 | fn balance(parent: Set, node: Set) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | match parent.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Set` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:133:15 [INFO] [stdout] | [INFO] [stdout] 132 | fn balance(parent: Set, node: Set) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | match parent.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fp-collections` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `fp-collections` (lib) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1ea8eff4568feb18e808581b1e73fb25fd48572bcb8f3e9f653c9281c2a27d94", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ea8eff4568feb18e808581b1e73fb25fd48572bcb8f3e9f653c9281c2a27d94", kill_on_drop: false }` [INFO] [stdout] 1ea8eff4568feb18e808581b1e73fb25fd48572bcb8f3e9f653c9281c2a27d94