[INFO] fetching crate flowc 0.142.0... [INFO] checking flowc-0.142.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate flowc 0.142.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate flowc 0.142.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate flowc 0.142.0 [INFO] finished tweaking crates.io crate flowc 0.142.0 [INFO] tweaked toml for crates.io crate flowc 0.142.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate flowc 0.142.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 637411eecaf267694610cd746b70c82d5178625ad7d81f406c228a3f8466e34b [INFO] running `Command { std: "docker" "start" "-a" "637411eecaf267694610cd746b70c82d5178625ad7d81f406c228a3f8466e34b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "637411eecaf267694610cd746b70c82d5178625ad7d81f406c228a3f8466e34b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "637411eecaf267694610cd746b70c82d5178625ad7d81f406c228a3f8466e34b", kill_on_drop: false }` [INFO] [stdout] 637411eecaf267694610cd746b70c82d5178625ad7d81f406c228a3f8466e34b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 00430882fd1b55ba81709c02206a4a8d9758711aff37a2d9deef2d511be8905c [INFO] running `Command { std: "docker" "start" "-a" "00430882fd1b55ba81709c02206a4a8d9758711aff37a2d9deef2d511be8905c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking memchr v2.6.2 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling rustix v0.38.10 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling curl v0.4.44 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking gimli v0.28.0 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking aho-corasick v1.0.5 [INFO] [stderr] Checking object v0.32.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking winnow v0.5.15 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling thiserror v1.0.47 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking anstyle v1.0.2 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Compiling const_format_proc_macros v0.2.31 [INFO] [stderr] Checking regex-automata v0.3.7 [INFO] [stderr] Checking brownstone v3.0.0 [INFO] [stderr] Checking indent_write v2.2.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking joinery v2.1.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking unsafe-libyaml v0.2.9 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking clap_builder v4.4.5 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking const_format v0.2.31 [INFO] [stderr] Compiling libz-sys v1.1.12 [INFO] [stderr] Compiling openssl-sys v0.9.92 [INFO] [stderr] Compiling curl-sys v0.4.65+curl-8.2.1 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking nom-supreme v0.8.0 [INFO] [stderr] Checking pori v0.0.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking clap v4.4.5 [INFO] [stderr] Checking regex v1.9.4 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.47 [INFO] [stderr] Compiling serial_test_derive v2.0.0 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking serial_test v2.0.0 [INFO] [stderr] Checking wax v0.5.0 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking serde_yaml v0.9.25 [INFO] [stderr] Checking toml_edit v0.20.1 [INFO] [stderr] Checking simpath v2.5.0 [INFO] [stderr] Checking toml v0.8.1 [INFO] [stderr] Checking flowcore v0.142.0 [INFO] [stderr] Checking flowc v0.142.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-parser_tests.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 31 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match parser::parse(&path, &meta_provider) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-parser_tests.rs:53:11 [INFO] [stdout] | [INFO] [stdout] 47 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | match parser::parse(&path, &meta_provider) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-parser_tests.rs:67:11 [INFO] [stdout] | [INFO] [stdout] 63 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | match parser::parse(&path, &meta_provider) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-parser_tests.rs:81:11 [INFO] [stdout] | [INFO] [stdout] 75 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | match parser::parse(&path, &meta_provider) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-parser_tests.rs:96:11 [INFO] [stdout] | [INFO] [stdout] 89 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | match parser::parse(&url, &meta_provider) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-parser_tests.rs:128:11 [INFO] [stdout] | [INFO] [stdout] 121 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | match parser::parse(&url, &meta_provider) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flowc` (test "flowc-parser_tests") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-compiler_tests.rs:206:19 [INFO] [stdout] | [INFO] [stdout] 193 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | match compile::compile(flow, &output_dir, false, false, [INFO] [stdout] | ___________________^ [INFO] [stdout] 207 | | &mut source_urls) { [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-compiler_tests.rs:277:11 [INFO] [stdout] | [INFO] [stdout] 269 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | match parser::parse(&url, &meta_provider) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-compiler_tests.rs:309:11 [INFO] [stdout] | [INFO] [stdout] 301 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | match parser::parse(&url, &meta_provider) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/flowc-compiler_tests.rs:362:11 [INFO] [stdout] | [INFO] [stdout] 354 | let meta_provider = MetaProvider::new(helper::set_lib_search_path_to_project(), [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | match parser::parse(&url, &meta_provider) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flowc` (test "flowc-compiler_tests") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "00430882fd1b55ba81709c02206a4a8d9758711aff37a2d9deef2d511be8905c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00430882fd1b55ba81709c02206a4a8d9758711aff37a2d9deef2d511be8905c", kill_on_drop: false }` [INFO] [stdout] 00430882fd1b55ba81709c02206a4a8d9758711aff37a2d9deef2d511be8905c