[INFO] fetching crate fj-core 0.49.0... [INFO] checking fj-core-0.49.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate fj-core 0.49.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate fj-core 0.49.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fj-core 0.49.0 [INFO] finished tweaking crates.io crate fj-core 0.49.0 [INFO] tweaked toml for crates.io crate fj-core 0.49.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 71 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (available: v0.5.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding nalgebra v0.32.6 (available: v0.33.0) [INFO] [stderr] Adding parry2d-f64 v0.13.8 (available: v0.17.1) [INFO] [stderr] Adding parry3d-f64 v0.13.8 (available: v0.17.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding simba v0.8.1 (available: v0.9.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 762abffae80131228fa22666be38e19b28c2de358e546ccf3a9b87ccee8a3459 [INFO] running `Command { std: "docker" "start" "-a" "762abffae80131228fa22666be38e19b28c2de358e546ccf3a9b87ccee8a3459", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "762abffae80131228fa22666be38e19b28c2de358e546ccf3a9b87ccee8a3459", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "762abffae80131228fa22666be38e19b28c2de358e546ccf3a9b87ccee8a3459", kill_on_drop: false }` [INFO] [stdout] 762abffae80131228fa22666be38e19b28c2de358e546ccf3a9b87ccee8a3459 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f4c66cbfc117f9fa262d7fd1b325b71e749075d15e57d5a8019bef93fbed006 [INFO] running `Command { std: "docker" "start" "-a" "5f4c66cbfc117f9fa262d7fd1b325b71e749075d15e57d5a8019bef93fbed006", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking type-map v0.5.0 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking spade v2.12.1 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking decorum v0.3.1 [INFO] [stderr] Checking nalgebra v0.32.6 [INFO] [stderr] Checking parry3d-f64 v0.13.8 [INFO] [stderr] Checking parry2d-f64 v0.13.8 [INFO] [stderr] Checking fj-math v0.49.0 [INFO] [stderr] Checking fj-interop v0.49.0 [INFO] [stderr] Checking fj-core v0.49.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(AnyObject, AnyObject)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/presentation.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 73 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | (self.original, self.derived) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Shell` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/build/shell.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 39 | let vertices = vertices [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let mut curves = BTreeMap::new(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Shell::empty().add_faces(faces, core) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HalfEdge` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/build/shell.rs:100:29 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|((vertex, positions), (curve, boundary))| { [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let half_edge = HalfEdge::line_segment( [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / half_edge [INFO] [stdout] 101 | | .update_start_vertex(|_, _| vertex, core) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Shell` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/holes.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 46 | let entry = HalfEdge::circle(location.position, radius, core); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | / self.update_face( [INFO] [stdout] 63 | | location.face, [INFO] [stdout] 64 | | |face, core| { [INFO] [stdout] 65 | | [face.update_region( [INFO] [stdout] ... | [INFO] [stdout] 85 | | core, [INFO] [stdout] 86 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Shell` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/holes.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 98 | let entry = HalfEdge::circle(entry_location.position, radius, core); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let swept_region = Region::empty(core) [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | / self.update_face( [INFO] [stdout] 137 | | entry_location.face, [INFO] [stdout] 138 | | |face, core| { [INFO] [stdout] 139 | | [face.update_region( [INFO] [stdout] ... | [INFO] [stdout] 184 | | core, [INFO] [stdout] 185 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `kinds::cycle::Cycle` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/join/cycle.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 127 | |cycle, (index, index_other)| { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | / cycle [INFO] [stdout] 131 | | .update_half_edge( [INFO] [stdout] 132 | | self.half_edges().nth_circular(index), [INFO] [stdout] 133 | | |half_edge, core| { [INFO] [stdout] ... | [INFO] [stdout] 158 | | core, [INFO] [stdout] 159 | | ) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(AnyObject, AnyObject)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layers/presentation.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 73 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | (self.original, self.derived) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fj-core` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Shell` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/build/shell.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 39 | let vertices = vertices [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let mut curves = BTreeMap::new(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Shell::empty().add_faces(faces, core) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HalfEdge` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/build/shell.rs:100:29 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|((vertex, positions), (curve, boundary))| { [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let half_edge = HalfEdge::line_segment( [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / half_edge [INFO] [stdout] 101 | | .update_start_vertex(|_, _| vertex, core) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Shell` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/holes.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 46 | let entry = HalfEdge::circle(location.position, radius, core); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | / self.update_face( [INFO] [stdout] 63 | | location.face, [INFO] [stdout] 64 | | |face, core| { [INFO] [stdout] 65 | | [face.update_region( [INFO] [stdout] ... | [INFO] [stdout] 85 | | core, [INFO] [stdout] 86 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Shell` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/holes.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 98 | let entry = HalfEdge::circle(entry_location.position, radius, core); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let swept_region = Region::empty(core) [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | / self.update_face( [INFO] [stdout] 137 | | entry_location.face, [INFO] [stdout] 138 | | |face, core| { [INFO] [stdout] 139 | | [face.update_region( [INFO] [stdout] ... | [INFO] [stdout] 184 | | core, [INFO] [stdout] 185 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `kinds::cycle::Cycle` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/join/cycle.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 127 | |cycle, (index, index_other)| { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | / cycle [INFO] [stdout] 131 | | .update_half_edge( [INFO] [stdout] 132 | | self.half_edges().nth_circular(index), [INFO] [stdout] 133 | | |half_edge, core| { [INFO] [stdout] ... | [INFO] [stdout] 158 | | core, [INFO] [stdout] 159 | | ) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fj-core` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "5f4c66cbfc117f9fa262d7fd1b325b71e749075d15e57d5a8019bef93fbed006", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f4c66cbfc117f9fa262d7fd1b325b71e749075d15e57d5a8019bef93fbed006", kill_on_drop: false }` [INFO] [stdout] 5f4c66cbfc117f9fa262d7fd1b325b71e749075d15e57d5a8019bef93fbed006