[INFO] fetching crate filesystem-hashing 0.3.4... [INFO] checking filesystem-hashing-0.3.4 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate filesystem-hashing 0.3.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate filesystem-hashing 0.3.4 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate filesystem-hashing 0.3.4 [INFO] finished tweaking crates.io crate filesystem-hashing 0.3.4 [INFO] tweaked toml for crates.io crate filesystem-hashing 0.3.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a31f00e1b197fbeaf13789b469b02ce3ff7cb18fee841a8755543ca8706acbd6 [INFO] running `Command { std: "docker" "start" "-a" "a31f00e1b197fbeaf13789b469b02ce3ff7cb18fee841a8755543ca8706acbd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a31f00e1b197fbeaf13789b469b02ce3ff7cb18fee841a8755543ca8706acbd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a31f00e1b197fbeaf13789b469b02ce3ff7cb18fee841a8755543ca8706acbd6", kill_on_drop: false }` [INFO] [stdout] a31f00e1b197fbeaf13789b469b02ce3ff7cb18fee841a8755543ca8706acbd6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8df2fac1c1a88f4b82ee790c319204285340cf51c133671c0a523f8e6e428ddd [INFO] running `Command { std: "docker" "start" "-a" "8df2fac1c1a88f4b82ee790c319204285340cf51c133671c0a523f8e6e428ddd", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking const-oid v0.10.0-rc.0 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking keccak v0.2.0-pre.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking rand_core v0.9.0-alpha.2 [INFO] [stderr] Checking rand_chacha v0.9.0-alpha.2 [INFO] [stderr] Checking rand v0.9.0-alpha.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hybrid-array v0.2.0-rc.10 [INFO] [stderr] Checking crypto-common v0.2.0-rc.1 [INFO] [stderr] Checking block-buffer v0.11.0-rc.1 [INFO] [stderr] Checking digest v0.11.0-pre.9 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking sha3 v0.11.0-pre.4 [INFO] [stderr] Checking filesystem-hashing v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/snapshot.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | let uuid_int: u128 = rand.gen(); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `rand::Rng::gen`: Renamed to `random` to avoid conflict with the new `gen` keyword in Rust 2024. [INFO] [stdout] --> src/snapshot.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | let uuid_int: u128 = rand.gen(); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:99:45 [INFO] [stdout] | [INFO] [stdout] 97 | ... let mut binding = bind.lock(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | ... let ht = binding.as_mut().expect("binding error"); [INFO] [stdout] 99 | ... if let Err(e) = hash_file(p.path(), ht, hash_type, verbose) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `verbose` [INFO] [stdout] --> src/snapshot.rs:161:5 [INFO] [stdout] | [INFO] [stdout] 161 | verbose: bool, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbose` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `verbose` [INFO] [stdout] --> src/snapshot.rs:313:66 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn export(snapshot: Snapshot, path: String, overwrite: bool, verbose: bool) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbose` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:99:45 [INFO] [stdout] | [INFO] [stdout] 97 | ... let mut binding = bind.lock(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | ... let ht = binding.as_mut().expect("binding error"); [INFO] [stdout] 99 | ... if let Err(e) = hash_file(p.path(), ht, hash_type, verbose) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:367:24 [INFO] [stdout] | [INFO] [stdout] 365 | let buffer = BytesMut::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let full_path = path_resolve(path); [INFO] [stdout] 367 | if let Ok(bytes) = fs::read(full_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `verbose` [INFO] [stdout] --> src/snapshot.rs:161:5 [INFO] [stdout] | [INFO] [stdout] 161 | verbose: bool, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbose` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `filesystem-hashing` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stdout] warning: unused variable: `verbose` [INFO] [stdout] --> src/snapshot.rs:313:66 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn export(snapshot: Snapshot, path: String, overwrite: bool, verbose: bool) -> Result<(), Error> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbose` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result, std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/snapshot.rs:367:24 [INFO] [stdout] | [INFO] [stdout] 365 | let buffer = BytesMut::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let full_path = path_resolve(path); [INFO] [stdout] 367 | if let Ok(bytes) = fs::read(full_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/snapshot.rs:405:13 [INFO] [stdout] | [INFO] [stdout] 405 | let mut snap = Snapshot::new( [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/snapshot.rs:418:13 [INFO] [stdout] | [INFO] [stdout] 418 | let mut snap = Snapshot::new( [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/snapshot.rs:431:13 [INFO] [stdout] | [INFO] [stdout] 431 | let mut snap = Snapshot::new( [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `filesystem-hashing` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8df2fac1c1a88f4b82ee790c319204285340cf51c133671c0a523f8e6e428ddd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8df2fac1c1a88f4b82ee790c319204285340cf51c133671c0a523f8e6e428ddd", kill_on_drop: false }` [INFO] [stdout] 8df2fac1c1a88f4b82ee790c319204285340cf51c133671c0a523f8e6e428ddd