[INFO] fetching crate fehler-macros 1.0.0... [INFO] checking fehler-macros-1.0.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate fehler-macros 1.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate fehler-macros 1.0.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fehler-macros 1.0.0 [INFO] finished tweaking crates.io crate fehler-macros 1.0.0 [INFO] tweaked toml for crates.io crate fehler-macros 1.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9c490afad423163bc6cec8da4b3647b4403a9b8ee325c885f9bcd4e92a2b007d [INFO] running `Command { std: "docker" "start" "-a" "9c490afad423163bc6cec8da4b3647b4403a9b8ee325c885f9bcd4e92a2b007d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9c490afad423163bc6cec8da4b3647b4403a9b8ee325c885f9bcd4e92a2b007d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c490afad423163bc6cec8da4b3647b4403a9b8ee325c885f9bcd4e92a2b007d", kill_on_drop: false }` [INFO] [stdout] 9c490afad423163bc6cec8da4b3647b4403a9b8ee325c885f9bcd4e92a2b007d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5487ac4f634a347155f769a53afdc13a4412a1c6b3ef23bc128329e482a1aadb [INFO] running `Command { std: "docker" "start" "-a" "5487ac4f634a347155f769a53afdc13a4412a1c6b3ef23bc128329e482a1aadb", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking fehler-macros v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:28:48 [INFO] [stdout] | [INFO] [stdout] 27 | fn inject_to_wrapper(&mut self, ret: Type) -> Type { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | if let Some(Type::Path(mut wrapper)) = self.wrapper.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/throws.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn fold(&mut self, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | if let Ok(item_fn) = syn::parse(input.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/args.rs:45:31 [INFO] [stdout] | [INFO] [stdout] 45 | _ => panic!(WRAPPER_MUST_BE_PATH) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 45 | _ => panic!("{}", WRAPPER_MUST_BE_PATH) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/args.rs:49:25 [INFO] [stdout] | [INFO] [stdout] 49 | } else { panic!(WRAPPER_MUST_BE_PATH) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 49 | } else { panic!("{}", WRAPPER_MUST_BE_PATH) } [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/args.rs:95:55 [INFO] [stdout] | [INFO] [stdout] 95 | _ => panic!(WRAPPER_MUST_BE_PATH) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 95 | _ => panic!("{}", WRAPPER_MUST_BE_PATH) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:28:48 [INFO] [stdout] | [INFO] [stdout] 27 | fn inject_to_wrapper(&mut self, ret: Type) -> Type { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | if let Some(Type::Path(mut wrapper)) = self.wrapper.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/throws.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn fold(&mut self, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | if let Ok(item_fn) = syn::parse(input.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/args.rs:45:31 [INFO] [stdout] | [INFO] [stdout] 45 | _ => panic!(WRAPPER_MUST_BE_PATH) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 45 | _ => panic!("{}", WRAPPER_MUST_BE_PATH) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/args.rs:49:25 [INFO] [stdout] | [INFO] [stdout] 49 | } else { panic!(WRAPPER_MUST_BE_PATH) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 49 | } else { panic!("{}", WRAPPER_MUST_BE_PATH) } [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/args.rs:95:55 [INFO] [stdout] | [INFO] [stdout] 95 | _ => panic!(WRAPPER_MUST_BE_PATH) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 95 | _ => panic!("{}", WRAPPER_MUST_BE_PATH) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fehler-macros` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fehler-macros` (lib) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5487ac4f634a347155f769a53afdc13a4412a1c6b3ef23bc128329e482a1aadb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5487ac4f634a347155f769a53afdc13a4412a1c6b3ef23bc128329e482a1aadb", kill_on_drop: false }` [INFO] [stdout] 5487ac4f634a347155f769a53afdc13a4412a1c6b3ef23bc128329e482a1aadb