[INFO] fetching crate fb_futures_ext 0.2.0... [INFO] checking fb_futures_ext-0.2.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate fb_futures_ext 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate fb_futures_ext 0.2.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fb_futures_ext 0.2.0 [INFO] finished tweaking crates.io crate fb_futures_ext 0.2.0 [INFO] tweaked toml for crates.io crate fb_futures_ext 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding erased-serde v0.3.31 (available: v0.4.5) [INFO] [stderr] Adding futures v0.1.31 (available: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding pin-project v0.4.30 (available: v1.1.5) [INFO] [stderr] Adding pin-project-internal v0.4.30 (available: v1.1.5) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f8762f3ced23805f5e505052b55c8ba257c7eacb94845289874b37c704222cd [INFO] running `Command { std: "docker" "start" "-a" "4f8762f3ced23805f5e505052b55c8ba257c7eacb94845289874b37c704222cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f8762f3ced23805f5e505052b55c8ba257c7eacb94845289874b37c704222cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f8762f3ced23805f5e505052b55c8ba257c7eacb94845289874b37c704222cd", kill_on_drop: false }` [INFO] [stdout] 4f8762f3ced23805f5e505052b55c8ba257c7eacb94845289874b37c704222cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f593f12e7bafa968fc1449d43b1f2ce237c5e265257af8654bbb71fc9ea692cb [INFO] running `Command { std: "docker" "start" "-a" "f593f12e7bafa968fc1449d43b1f2ce237c5e265257af8654bbb71fc9ea692cb", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling pin-project-internal v0.4.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v0.4.30 [INFO] [stderr] Checking shared_error v0.1.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking fb_futures_ext v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/future/abort_handle_ref.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct ControlledHandle(Arc); [INFO] [stdout] | ---------------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ControlledHandle` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option<()>, weight_limited_buffered_stream::WeightLimitedBufferedStream<'_, std::pin::Pin + std::marker::Send>>, u64)> + std::marker::Send>>, ()>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/weight_limited_buffered_stream.rs:234:32 [INFO] [stdout] | [INFO] [stdout] 227 | let (counter, s) = create_stream(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | if let (Some(()), s) = s.into_future().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option<()>, weight_limited_buffered_stream::WeightLimitedBufferedStream<'_, std::pin::Pin + std::marker::Send>>, u64)> + std::marker::Send>>, ()>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/weight_limited_buffered_stream.rs:252:32 [INFO] [stdout] | [INFO] [stdout] 245 | let (counter, s) = create_stream(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | if let (Some(()), s) = s.into_future().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option<()>, weight_limited_buffered_stream::WeightLimitedBufferedStream<'_, std::pin::Pin + std::marker::Send>>, u64)> + std::marker::Send>>, ()>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/weight_limited_buffered_stream.rs:270:32 [INFO] [stdout] | [INFO] [stdout] 263 | let (counter, s) = create_stream(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | if let (Some(()), s) = s.into_future().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, weight_limited_buffered_stream::WeightLimitedBufferedTryStream<'_, std::pin::Pin> + std::marker::Send>>, u64), String>> + std::marker::Send>>, (), String>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/weight_limited_buffered_stream.rs:317:36 [INFO] [stdout] | [INFO] [stdout] 310 | let (counter, s) = create_try_stream_all_good(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | if let (Some(Ok(())), s) = s.into_future().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, weight_limited_buffered_stream::WeightLimitedBufferedTryStream<'_, std::pin::Pin> + std::marker::Send>>, u64), String>> + std::marker::Send>>, (), String>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/weight_limited_buffered_stream.rs:335:36 [INFO] [stdout] | [INFO] [stdout] 328 | let (counter, s) = create_try_stream_all_good(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | if let (Some(Ok(())), s) = s.into_future().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, weight_limited_buffered_stream::WeightLimitedBufferedTryStream<'_, std::pin::Pin> + std::marker::Send>>, u64), String>> + std::marker::Send>>, (), String>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/weight_limited_buffered_stream.rs:353:36 [INFO] [stdout] | [INFO] [stdout] 346 | let (counter, s) = create_try_stream_all_good(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | if let (Some(Ok(())), s) = s.into_future().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, weight_limited_buffered_stream::WeightLimitedBufferedTryStream<'_, std::pin::Pin> + std::marker::Send>>, u64), String>> + std::marker::Send>>, (), String>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/weight_limited_buffered_stream.rs:382:36 [INFO] [stdout] | [INFO] [stdout] 375 | let (counter, s) = create_try_stream_fail_external(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | if let (Some(Ok(())), s) = s.into_future().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, weight_limited_buffered_stream::WeightLimitedBufferedTryStream<'_, std::pin::Pin> + std::marker::Send>>, u64), String>> + std::marker::Send>>, (), String>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/weight_limited_buffered_stream.rs:431:36 [INFO] [stdout] | [INFO] [stdout] 424 | let (counter, s) = create_try_stream_fail_internal(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | if let (Some(Ok(())), s) = s.into_future().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/future/abort_handle_ref.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct ControlledHandle(Arc); [INFO] [stdout] | ---------------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ControlledHandle` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fb_futures_ext` (lib test) due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f593f12e7bafa968fc1449d43b1f2ce237c5e265257af8654bbb71fc9ea692cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f593f12e7bafa968fc1449d43b1f2ce237c5e265257af8654bbb71fc9ea692cb", kill_on_drop: false }` [INFO] [stdout] f593f12e7bafa968fc1449d43b1f2ce237c5e265257af8654bbb71fc9ea692cb