[INFO] fetching crate fastlib 0.3.1... [INFO] checking fastlib-0.3.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate fastlib 0.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate fastlib 0.3.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fastlib 0.3.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate fastlib 0.3.1 [INFO] tweaked toml for crates.io crate fastlib 0.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 508a197438ec8d87af4a4a505c522beee5c1fe2b32a37687d9314120660795c1 [INFO] running `Command { std: "docker" "start" "-a" "508a197438ec8d87af4a4a505c522beee5c1fe2b32a37687d9314120660795c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "508a197438ec8d87af4a4a505c522beee5c1fe2b32a37687d9314120660795c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "508a197438ec8d87af4a4a505c522beee5c1fe2b32a37687d9314120660795c1", kill_on_drop: false }` [INFO] [stdout] 508a197438ec8d87af4a4a505c522beee5c1fe2b32a37687d9314120660795c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 89c8923d160cb69d2f4139bfb53b30b76581e864142638870356f737fd71d1f4 [INFO] running `Command { std: "docker" "start" "-a" "89c8923d160cb69d2f4139bfb53b30b76581e864142638870356f737fd71d1f4", kill_on_drop: false }` [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking roxmltree v0.20.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking fastlib v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option<(std::string::String, ValueData)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/value.rs:435:15 [INFO] [stdout] | [INFO] [stdout] 431 | fn next_key_seed(&mut self, seed: K) -> Result, Self::Error> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | match self.items.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/value.rs:448:15 [INFO] [stdout] | [INFO] [stdout] 444 | fn next_value_seed(&mut self, seed: V) -> Result [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | match self.value.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/value.rs:486:15 [INFO] [stdout] | [INFO] [stdout] 482 | fn next_element_seed(&mut self, seed: T) -> Result, Self::Error> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | match self.items.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fastlib` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option<(std::string::String, ValueData)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/value.rs:435:15 [INFO] [stdout] | [INFO] [stdout] 431 | fn next_key_seed(&mut self, seed: K) -> Result, Self::Error> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 435 | match self.items.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/value.rs:448:15 [INFO] [stdout] | [INFO] [stdout] 444 | fn next_value_seed(&mut self, seed: V) -> Result [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | match self.value.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/value.rs:486:15 [INFO] [stdout] | [INFO] [stdout] 482 | fn next_element_seed(&mut self, seed: T) -> Result, Self::Error> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | match self.items.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ModelVisitor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/base.rs:518:13 [INFO] [stdout] | [INFO] [stdout] 510 | fn do_test(raw: Vec, data: TemplateData) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | let mut msg = ModelVisitor::new(data.clone()); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/base.rs:749:13 [INFO] [stdout] | [INFO] [stdout] 745 | let mut d = Decoder::new_from_xml(include_str!("templates/base.xml")).unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 746 | let res = d.decode_stream(&mut r, &mut msg); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 749 | Err(e) => assert!(false, "Unexpected error: {:?}", e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Encoder` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/base_serde.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 134 | fn do_test(raw: Vec, data: Message) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let mut e = Encoder::new_from_xml(DEFINITION).unwrap(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `template::TemplateData` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:136:11 [INFO] [stdout] | [INFO] [stdout] 135 | fn extract_value(msg: ModelFactory, name: &str, test_name: &str) -> Option { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | match msg.data.unwrap().value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fastlib` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "89c8923d160cb69d2f4139bfb53b30b76581e864142638870356f737fd71d1f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89c8923d160cb69d2f4139bfb53b30b76581e864142638870356f737fd71d1f4", kill_on_drop: false }` [INFO] [stdout] 89c8923d160cb69d2f4139bfb53b30b76581e864142638870356f737fd71d1f4