[INFO] fetching crate fasten 0.8.3... [INFO] checking fasten-0.8.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate fasten 0.8.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate fasten 0.8.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fasten 0.8.3 [INFO] finished tweaking crates.io crate fasten 0.8.3 [INFO] tweaked toml for crates.io crate fasten 0.8.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate fasten 0.8.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c4b6f56e7a1d205b09e6d7f22a6b8b277936aae138125ee446f37572746abf8 [INFO] running `Command { std: "docker" "start" "-a" "7c4b6f56e7a1d205b09e6d7f22a6b8b277936aae138125ee446f37572746abf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c4b6f56e7a1d205b09e6d7f22a6b8b277936aae138125ee446f37572746abf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c4b6f56e7a1d205b09e6d7f22a6b8b277936aae138125ee446f37572746abf8", kill_on_drop: false }` [INFO] [stdout] 7c4b6f56e7a1d205b09e6d7f22a6b8b277936aae138125ee446f37572746abf8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1bfe2e6d079ccba624d753bbd5bf0d49a0273c0fc0bb09af70e794ebcc769488 [INFO] running `Command { std: "docker" "start" "-a" "1bfe2e6d079ccba624d753bbd5bf0d49a0273c0fc0bb09af70e794ebcc769488", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking owning_ref v0.2.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking smallvec v0.3.4 [INFO] [stderr] Checking parking_lot v0.3.8 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking multiqueue v0.3.2 [INFO] [stderr] Compiling libz-sys v1.1.12 [INFO] [stderr] Compiling lz4-sys v1.9.4 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking bam v0.1.4 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking statistical v1.0.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking lz4 v1.24.0 [INFO] [stderr] Checking fastq v0.6.0 [INFO] [stderr] Checking fasten v0.8.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/fasten_replace.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 76 | let find_regex = Regex::new(&find_param) [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let mut buffer_iter = my_buffer.lines(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | while let Some(line) = buffer_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fasten` (bin "fasten_replace") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/fasten_convert.rs:276:14 [INFO] [stdout] | [INFO] [stdout] 263 | fn read_fastq(tx:std::sync::mpsc::Sender, paired_end:bool){ [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | let mut parser_getter = parser.ref_iter(); [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | match &parser_getter.advance() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fasten` (bin "fasten_convert" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "1bfe2e6d079ccba624d753bbd5bf0d49a0273c0fc0bb09af70e794ebcc769488", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1bfe2e6d079ccba624d753bbd5bf0d49a0273c0fc0bb09af70e794ebcc769488", kill_on_drop: false }` [INFO] [stdout] 1bfe2e6d079ccba624d753bbd5bf0d49a0273c0fc0bb09af70e794ebcc769488