[INFO] fetching crate extension-trait 1.0.2... [INFO] checking extension-trait-1.0.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate extension-trait 1.0.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate extension-trait 1.0.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate extension-trait 1.0.2 [INFO] finished tweaking crates.io crate extension-trait 1.0.2 [INFO] tweaked toml for crates.io crate extension-trait 1.0.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 832230e20efa96708172b9a3ae7507455fb19586589aed44e4c0e05e6f014efa [INFO] running `Command { std: "docker" "start" "-a" "832230e20efa96708172b9a3ae7507455fb19586589aed44e4c0e05e6f014efa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "832230e20efa96708172b9a3ae7507455fb19586589aed44e4c0e05e6f014efa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "832230e20efa96708172b9a3ae7507455fb19586589aed44e4c0e05e6f014efa", kill_on_drop: false }` [INFO] [stdout] 832230e20efa96708172b9a3ae7507455fb19586589aed44e4c0e05e6f014efa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 11fed424c064330bb79d9ef0c52440a7424c278ca493650a8ee7e089c55c77a1 [INFO] running `Command { std: "docker" "start" "-a" "11fed424c064330bb79d9ef0c52440a7424c278ca493650a8ee7e089c55c77a1", kill_on_drop: false }` [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking extension-trait v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Map, {closure@src/lib.rs:106:49: 106:54}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 86 | }) => quote! { #(#attrs)* #const_token #ident #colon_token #ty #semi_token }, [INFO] [stdout] | ---------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let inputs = inputs.into_iter().map(|arg| { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 125 | / quote! { [INFO] [stdout] 126 | | #(#attrs)* [INFO] [stdout] 127 | | #constness #asyncness #unsafety #abi #fn_token #ident #generics (#(#inputs,)* #variadic) #output #where_clause; [INFO] [stdout] 128 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | | }) => quote! { #(#attrs)* #type_token #ident #generics #semi_token }, [INFO] [stdout] | | -------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Cow<'_, syn::Ident>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:29 [INFO] [stdout] | [INFO] [stdout] 110 | let ident = extract_ident(pat).unwrap_or_else(|| Cow::Owned(Ident::new("_", span))); [INFO] [stdout] | ^^^^^ [INFO] [stdout] 111 | quote! { #(#attrs)* #ident #colon_token #ty } [INFO] [stdout] | --------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | }) => quote! { #(#attrs)* #self_token #colon #ty }, [INFO] [stdout] | -------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `extension-trait` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Map, {closure@src/lib.rs:106:49: 106:54}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 86 | }) => quote! { #(#attrs)* #const_token #ident #colon_token #ty #semi_token }, [INFO] [stdout] | ---------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let inputs = inputs.into_iter().map(|arg| { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 125 | / quote! { [INFO] [stdout] 126 | | #(#attrs)* [INFO] [stdout] 127 | | #constness #asyncness #unsafety #abi #fn_token #ident #generics (#(#inputs,)* #variadic) #output #where_clause; [INFO] [stdout] 128 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | | }) => quote! { #(#attrs)* #type_token #ident #generics #semi_token }, [INFO] [stdout] | | -------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Cow<'_, syn::Ident>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:29 [INFO] [stdout] | [INFO] [stdout] 110 | let ident = extract_ident(pat).unwrap_or_else(|| Cow::Owned(Ident::new("_", span))); [INFO] [stdout] | ^^^^^ [INFO] [stdout] 111 | quote! { #(#attrs)* #ident #colon_token #ty } [INFO] [stdout] | --------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | }) => quote! { #(#attrs)* #self_token #colon #ty }, [INFO] [stdout] | -------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `extension-trait` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "11fed424c064330bb79d9ef0c52440a7424c278ca493650a8ee7e089c55c77a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11fed424c064330bb79d9ef0c52440a7424c278ca493650a8ee7e089c55c77a1", kill_on_drop: false }` [INFO] [stdout] 11fed424c064330bb79d9ef0c52440a7424c278ca493650a8ee7e089c55c77a1