[INFO] fetching crate exprs 0.1.1... [INFO] checking exprs-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate exprs 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate exprs 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate exprs 0.1.1 [INFO] finished tweaking crates.io crate exprs 0.1.1 [INFO] tweaked toml for crates.io crate exprs 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate exprs 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c46bb6bb1af082ef5afe62fa6cf823d3c1b775818d424b08caef6d399f84d7e2 [INFO] running `Command { std: "docker" "start" "-a" "c46bb6bb1af082ef5afe62fa6cf823d3c1b775818d424b08caef6d399f84d7e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c46bb6bb1af082ef5afe62fa6cf823d3c1b775818d424b08caef6d399f84d7e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c46bb6bb1af082ef5afe62fa6cf823d3c1b775818d424b08caef6d399f84d7e2", kill_on_drop: false }` [INFO] [stdout] c46bb6bb1af082ef5afe62fa6cf823d3c1b775818d424b08caef6d399f84d7e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 57a27f5698628ae646455e7be639a36331950e9e7e3224e58482994ad4abb666 [INFO] running `Command { std: "docker" "start" "-a" "57a27f5698628ae646455e7be639a36331950e9e7e3224e58482994ad4abb666", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Checking exprs v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lexer.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | /// Need to parse function [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lexer.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | /// Need to parse function [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/token.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | _ => Assoc::NONE, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/token.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 63 | Op::SUM | Op::MUL | Op::SUB | Op::DIV => Assoc::LEFT, [INFO] [stdout] | ------------------------------------- matches some of the same values [INFO] [stdout] 64 | Op::EXP | Op::NEG | Op::FAC => Assoc::RIGHT, [INFO] [stdout] | --------------------------- matches some of the same values [INFO] [stdout] 65 | _ => Assoc::NONE, [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/token.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | _ => 0, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/token.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 73 | Op::NEG => 5, [INFO] [stdout] | ------- matches some of the same values [INFO] [stdout] 74 | Op::EXP | Op::FAC => 4, [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] 75 | Op::SUB | Op::SUM => 2, [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] 76 | Op::MUL | Op::DIV => 3, [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] 77 | _ => 0, [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/token.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | _ => Assoc::NONE, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/token.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 63 | Op::SUM | Op::MUL | Op::SUB | Op::DIV => Assoc::LEFT, [INFO] [stdout] | ------------------------------------- matches some of the same values [INFO] [stdout] 64 | Op::EXP | Op::NEG | Op::FAC => Assoc::RIGHT, [INFO] [stdout] | --------------------------- matches some of the same values [INFO] [stdout] 65 | _ => Assoc::NONE, [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/token.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | _ => 0, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/token.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 73 | Op::NEG => 5, [INFO] [stdout] | ------- matches some of the same values [INFO] [stdout] 74 | Op::EXP | Op::FAC => 4, [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] 75 | Op::SUB | Op::SUM => 2, [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] 76 | Op::MUL | Op::DIV => 3, [INFO] [stdout] | ----------------- matches some of the same values [INFO] [stdout] 77 | _ => 0, [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lexer.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | let mut is_fn = false; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parser::AstNode` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:146:14 [INFO] [stdout] | [INFO] [stdout] 71 | let mut output: Vec = Vec::with_capacity(tokens.len()); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | AST::new(output.pop().unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lexer.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | let mut is_fn = false; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parser::AstNode` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:146:14 [INFO] [stdout] | [INFO] [stdout] 71 | let mut output: Vec = Vec::with_capacity(tokens.len()); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | AST::new(output.pop().unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exprs` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exprs` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "57a27f5698628ae646455e7be639a36331950e9e7e3224e58482994ad4abb666", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57a27f5698628ae646455e7be639a36331950e9e7e3224e58482994ad4abb666", kill_on_drop: false }` [INFO] [stdout] 57a27f5698628ae646455e7be639a36331950e9e7e3224e58482994ad4abb666