[INFO] fetching crate etch 0.4.2... [INFO] checking etch-0.4.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate etch 0.4.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate etch 0.4.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate etch 0.4.2 [INFO] finished tweaking crates.io crate etch 0.4.2 [INFO] tweaked toml for crates.io crate etch 0.4.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate etch 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 876b26931f72bd98c33a32c7b6bb0fbc35bcd197286031c8cee219f3ea44c968 [INFO] running `Command { std: "docker" "start" "-a" "876b26931f72bd98c33a32c7b6bb0fbc35bcd197286031c8cee219f3ea44c968", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "876b26931f72bd98c33a32c7b6bb0fbc35bcd197286031c8cee219f3ea44c968", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "876b26931f72bd98c33a32c7b6bb0fbc35bcd197286031c8cee219f3ea44c968", kill_on_drop: false }` [INFO] [stdout] 876b26931f72bd98c33a32c7b6bb0fbc35bcd197286031c8cee219f3ea44c968 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 206278abd3270bc8bdcaac7d795f1212bf13b1aaf916276c5b4a279f7bacad3c [INFO] running `Command { std: "docker" "start" "-a" "206278abd3270bc8bdcaac7d795f1212bf13b1aaf916276c5b4a279f7bacad3c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.29 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.33 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling serde v1.0.91 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling ryu v0.2.8 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking safemem v0.3.0 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking xml-rs v0.8.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking line-wrap v0.1.1 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking yaml-rust v0.4.3 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Checking regex-syntax v0.6.6 [INFO] [stderr] Checking bork v0.2.1 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling bincode v1.1.4 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling miniz-sys v0.1.12 [INFO] [stderr] Compiling onig_sys v69.1.0 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking flate2 v1.0.7 [INFO] [stderr] Compiling serde_derive v1.0.91 [INFO] [stderr] Compiling proc-macro-hack v0.5.5 [INFO] [stderr] Compiling paste-impl v0.1.5 [INFO] [stderr] Checking paste v0.1.5 [INFO] [stderr] Checking glue v0.8.7 [INFO] [stderr] Checking onig v4.3.2 [INFO] [stderr] Checking serde_json v1.0.39 [INFO] [stderr] Checking plist v0.4.1 [INFO] [stderr] Checking syntect v3.2.0 [INFO] [stderr] Checking etch v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `impl glue::types::Parser<'_, (&str, &str)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/metadata.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 27 | _state: SharedState, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | match delimited( [INFO] [stdout] | _______________^ [INFO] [stdout] 36 | | take_all((indent(0..), is("#meta["))), [INFO] [stdout] 37 | | separated( [INFO] [stdout] 38 | | tag_name(), [INFO] [stdout] ... | [INFO] [stdout] 42 | | take_all((space(0..), is(']'))), [INFO] [stdout] 43 | | ).parse(ctx) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/nodes.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Clone, PartialEq, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Node` [INFO] [stdout] 13 | pub enum Node { [INFO] [stdout] | ---- `Node` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `etch` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `impl glue::types::Parser<'_, (&str, &str)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/metadata.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 27 | _state: SharedState, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | match delimited( [INFO] [stdout] | _______________^ [INFO] [stdout] 36 | | take_all((indent(0..), is("#meta["))), [INFO] [stdout] 37 | | separated( [INFO] [stdout] 38 | | tag_name(), [INFO] [stdout] ... | [INFO] [stdout] 42 | | take_all((space(0..), is(']'))), [INFO] [stdout] 43 | | ).parse(ctx) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/nodes.rs:12:35 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Clone, PartialEq, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Node` [INFO] [stdout] 13 | pub enum Node { [INFO] [stdout] | ---- `Node` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `etch` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "206278abd3270bc8bdcaac7d795f1212bf13b1aaf916276c5b4a279f7bacad3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "206278abd3270bc8bdcaac7d795f1212bf13b1aaf916276c5b4a279f7bacad3c", kill_on_drop: false }` [INFO] [stdout] 206278abd3270bc8bdcaac7d795f1212bf13b1aaf916276c5b4a279f7bacad3c