[INFO] fetching crate espr 0.4.0... [INFO] checking espr-0.4.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate espr 0.4.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate espr 0.4.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate espr 0.4.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate espr 0.4.0 [INFO] tweaked toml for crates.io crate espr 0.4.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate espr 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c6d727f4458283523f39b9d6648eae26f3105e6fd58535cd2a84f8d3c05c1e9c [INFO] running `Command { std: "docker" "start" "-a" "c6d727f4458283523f39b9d6648eae26f3105e6fd58535cd2a84f8d3c05c1e9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c6d727f4458283523f39b9d6648eae26f3105e6fd58535cd2a84f8d3c05c1e9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6d727f4458283523f39b9d6648eae26f3105e6fd58535cd2a84f8d3c05c1e9c", kill_on_drop: false }` [INFO] [stdout] c6d727f4458283523f39b9d6648eae26f3105e6fd58535cd2a84f8d3c05c1e9c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 18688359baa90a65aa697bac2c812fc52b3866485cffc40b87ecff27764cf0e8 [INFO] running `Command { std: "docker" "start" "-a" "18688359baa90a65aa697bac2c812fc52b3866485cffc40b87ecff27764cf0e8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking check_keyword v0.2.0 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking similar v2.2.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking insta v1.40.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Checking Inflector v0.11.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling katexit v0.1.4 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking espr v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/rust/entity.rs:183:17 [INFO] [stdout] | [INFO] [stdout] 157 | let any = self.any_ident(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let name = self.name_ident(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | [INFO] [stdout] 160 | let constraints = self [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let supertype = match ty { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 190 | tokens.append_all(quote! { [INFO] [stdout] | _______________________________- [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] 191 | | impl AsRef<#supertype> for #any { [INFO] [stdout] 192 | | fn as_ref(&self) -> &#supertype { [INFO] [stdout] 193 | | match self { [INFO] [stdout] ... | [INFO] [stdout] 198 | | } [INFO] [stdout] 199 | | }); [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/entity/inverse.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 25 | .map(|opt| { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | if let Some((agg, bound, _of)) = opt { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/rust/entity.rs:183:17 [INFO] [stdout] | [INFO] [stdout] 157 | let any = self.any_ident(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let name = self.name_ident(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | [INFO] [stdout] 160 | let constraints = self [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let supertype = match ty { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 190 | tokens.append_all(quote! { [INFO] [stdout] | _______________________________- [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] 191 | | impl AsRef<#supertype> for #any { [INFO] [stdout] 192 | | fn as_ref(&self) -> &#supertype { [INFO] [stdout] 193 | | match self { [INFO] [stdout] ... | [INFO] [stdout] 198 | | } [INFO] [stdout] 199 | | }); [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/entity/inverse.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 25 | .map(|opt| { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | if let Some((agg, bound, _of)) = opt { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ast::expression::QualifiableFactor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expression/primary.rs:226:48 [INFO] [stdout] | [INFO] [stdout] 224 | let (res, (q, _remarks)) = super::primary("x").finish().unwrap(); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | assert_eq!(res, ""); [INFO] [stdout] 226 | if let Expression::QualifiableFactor { factor, qualifiers } = q { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ast::expression::QualifiableFactor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expression/primary.rs:243:48 [INFO] [stdout] | [INFO] [stdout] 241 | let (res, (q, _remarks)) = super::primary(r"x\group.attr").finish().unwrap(); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | assert_eq!(res, ""); [INFO] [stdout] 243 | if let Expression::QualifiableFactor { factor, qualifiers } = q { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ast::expression::QualifiableFactor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expression/primary.rs:262:48 [INFO] [stdout] | [INFO] [stdout] 260 | let (res, (q, _remarks)) = super::primary("f(x)").finish().unwrap(); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | assert_eq!(res, ""); [INFO] [stdout] 262 | if let Expression::QualifiableFactor { factor, qualifiers } = q { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ast::expression::QualifiableFactor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expression/primary.rs:287:48 [INFO] [stdout] | [INFO] [stdout] 285 | let (res, (q, _remarks)) = super::primary("x[2 * 2]").finish().unwrap(); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | assert_eq!(res, ""); [INFO] [stdout] 287 | if let Expression::QualifiableFactor { factor, qualifiers } = q { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ast::expression::QualifiableFactor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expression/primary.rs:305:48 [INFO] [stdout] | [INFO] [stdout] 303 | let (res, (q, _remarks)) = super::primary("x[1:3]").finish().unwrap(); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 304 | assert_eq!(res, ""); [INFO] [stdout] 305 | if let Expression::QualifiableFactor { factor, qualifiers } = q { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ast::expression::QualifiableFactor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expression/primary.rs:323:48 [INFO] [stdout] | [INFO] [stdout] 321 | let (res, (q, _remarks)) = super::primary("x[1:?]").finish().unwrap(); [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | assert_eq!(res, ""); [INFO] [stdout] 323 | if let Expression::QualifiableFactor { factor, qualifiers } = q { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expression/simple.rs:315:61 [INFO] [stdout] | [INFO] [stdout] 311 | let (residual, (ctor, _remarks)) = super::entity_constructor("point(0.0, 0.0, 0.0)") [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | if let super::Expression::EntityConstructor { name, values } = ctor { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `espr` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `espr` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "18688359baa90a65aa697bac2c812fc52b3866485cffc40b87ecff27764cf0e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18688359baa90a65aa697bac2c812fc52b3866485cffc40b87ecff27764cf0e8", kill_on_drop: false }` [INFO] [stdout] 18688359baa90a65aa697bac2c812fc52b3866485cffc40b87ecff27764cf0e8