[INFO] fetching crate esl01-indexedlog 0.3.0... [INFO] checking esl01-indexedlog-0.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate esl01-indexedlog 0.3.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate esl01-indexedlog 0.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate esl01-indexedlog 0.3.0 [INFO] finished tweaking crates.io crate esl01-indexedlog 0.3.0 [INFO] tweaked toml for crates.io crate esl01-indexedlog 0.3.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding ctor v0.1.26 (available: v0.2.8) [INFO] [stderr] Adding env_logger v0.8.4 (available: v0.11.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a27b75416ee12f5d9a529dc3c52ca0e424982d34e4e250862141fe841cbda409 [INFO] running `Command { std: "docker" "start" "-a" "a27b75416ee12f5d9a529dc3c52ca0e424982d34e4e250862141fe841cbda409", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a27b75416ee12f5d9a529dc3c52ca0e424982d34e4e250862141fe841cbda409", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a27b75416ee12f5d9a529dc3c52ca0e424982d34e4e250862141fe841cbda409", kill_on_drop: false }` [INFO] [stdout] a27b75416ee12f5d9a529dc3c52ca0e424982d34e4e250862141fe841cbda409 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9f533ae105737571121df4f412817c2075eb4edaf272019f9f57ce7001d00c7 [INFO] running `Command { std: "docker" "start" "-a" "a9f533ae105737571121df4f412817c2075eb4edaf272019f9f57ce7001d00c7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking esl01-vlqencoding v0.3.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking esl01-atomicfile v0.3.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking esl01-dev-logger v0.3.0 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking esl01-minibytes v0.3.0 [INFO] [stderr] Checking esl01-indexedlog v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `open_options::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/repair.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 146 | .or_else(|_| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | / self.clone() [INFO] [stdout] 148 | | .index_defs(Vec::new()) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `open_options::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/mod.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn open>(dir: P, index_defs: Vec) -> crate::Result { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | / OpenOptions::new() [INFO] [stdout] 237 | | .index_defs(index_defs) [INFO] [stdout] 238 | | .create(true) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `GenericPath` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/mod.rs:820:32 [INFO] [stdout] | [INFO] [stdout] 819 | let result: crate::Result<_> = (|this: Log| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 820 | if let Some(dir) = this.dir.clone().as_opt_path() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:575:15 [INFO] [stdout] | [INFO] [stdout] 573 | fn read_file>(&mut self, path: P) -> crate::Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | let path = path.as_ref(); [INFO] [stdout] 575 | match utils::atomic_read(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `O` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repair.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 143 | fn repair(path: impl AsRef) -> crate::Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | T::default_open_options().open_options_repair(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esl01-indexedlog` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::fs::File` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:4347:17 [INFO] [stdout] | [INFO] [stdout] 4291 | let dir = tempdir().unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4308 | let opts = open_opts() [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4347 | let mut f = File::create(dir.path().join("a")).expect("create"); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `open_options::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/repair.rs:147:21 [INFO] [stdout] | [INFO] [stdout] 146 | .or_else(|_| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | / self.clone() [INFO] [stdout] 148 | | .index_defs(Vec::new()) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `open_options::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/mod.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn open>(dir: P, index_defs: Vec) -> crate::Result { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | / OpenOptions::new() [INFO] [stdout] 237 | | .index_defs(index_defs) [INFO] [stdout] 238 | | .create(true) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `GenericPath` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/mod.rs:820:32 [INFO] [stdout] | [INFO] [stdout] 819 | let result: crate::Result<_> = (|this: Log| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 820 | if let Some(dir) = this.dir.clone().as_opt_path() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:575:15 [INFO] [stdout] | [INFO] [stdout] 573 | fn read_file>(&mut self, path: P) -> crate::Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | let path = path.as_ref(); [INFO] [stdout] 575 | match utils::atomic_read(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `O` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repair.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 143 | fn repair(path: impl AsRef) -> crate::Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | T::default_open_options().open_options_repair(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `[rotate::RotateLog; 2]` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotate.rs:1017:28 [INFO] [stdout] | [INFO] [stdout] 1007 | let dir = tempdir().unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1008 | let opts = OpenOptions::new() [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1017 | for rotate in &mut [rotate, rotate_mem] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `rotate::RotateLog` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotate.rs:1103:17 [INFO] [stdout] | [INFO] [stdout] 1065 | let dir = tempdir().unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1103 | let rotate = open(4); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Map>, {closure@src/rotate.rs:1769:57: 1769:60}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotate.rs:1769:42 [INFO] [stdout] | [INFO] [stdout] 1762 | let mut log = open_opts.open(path).unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1769 | for entry in log.iter().map(|d| d.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `esl01-indexedlog` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "a9f533ae105737571121df4f412817c2075eb4edaf272019f9f57ce7001d00c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9f533ae105737571121df4f412817c2075eb4edaf272019f9f57ce7001d00c7", kill_on_drop: false }` [INFO] [stdout] a9f533ae105737571121df4f412817c2075eb4edaf272019f9f57ce7001d00c7