[INFO] fetching crate ergo 0.0.5... [INFO] checking ergo-0.0.5 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ergo 0.0.5 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ergo 0.0.5 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ergo 0.0.5 [INFO] finished tweaking crates.io crate ergo 0.0.5 [INFO] tweaked toml for crates.io crate ergo 0.0.5 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 110 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (available: v1.1.3) [INFO] [stderr] Adding arrayvec v0.4.12 (available: v0.7.6) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding crossbeam-channel v0.1.3 (available: v0.5.13) [INFO] [stderr] Adding crossbeam-epoch v0.4.3 (available: v0.9.18) [INFO] [stderr] Adding crossbeam-utils v0.3.2 (available: v0.8.20) [INFO] [stderr] Adding dirs v2.0.2 (available: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (available: v0.4.1) [INFO] [stderr] Adding dtoa v0.4.8 (available: v1.0.9) [INFO] [stderr] Adding erased-serde v0.3.31 (available: v0.4.5) [INFO] [stderr] Adding glob v0.2.11 (available: v0.3.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding heck v0.3.3 (available: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.7.11 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding memoffset v0.2.1 (available: v0.9.1) [INFO] [stderr] Adding owning_ref v0.3.3 (available: v0.4.1) [INFO] [stderr] Adding parking_lot v0.5.5 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.2.14 (available: v0.9.10) [INFO] [stderr] Adding path_abs v0.4.1 (available: v0.5.1) [INFO] [stderr] Adding quote v0.3.15 (available: v1.0.37) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding regex v0.2.11 (available: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (available: v0.8.4) [INFO] [stderr] Adding remove_dir_all v0.5.3 (available: v0.8.4) [INFO] [stderr] Adding ron v0.1.7 (available: v0.8.1) [INFO] [stderr] Adding scopeguard v0.3.3 (available: v1.2.0) [INFO] [stderr] Adding serde_yaml v0.7.5 (available: v0.9.34+deprecated) [INFO] [stderr] Adding shellexpand v1.1.1 (available: v3.1.0) [INFO] [stderr] Adding smallvec v0.6.14 (available: v1.13.2) [INFO] [stderr] Adding syn v0.11.11 (available: v2.0.77) [INFO] [stderr] Adding thread_local v0.3.6 (available: v1.1.8) [INFO] [stderr] Adding toml v0.4.10 (available: v0.8.19) [INFO] [stderr] Adding ucd-util v0.1.10 (available: v0.2.1) [INFO] [stderr] Adding unicode-xid v0.0.4 (available: v0.2.6) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef96ee3ec74d99f0ac973835e80166c3ef722bbfcde2ce2c92a54cbe94b0fd61 [INFO] running `Command { std: "docker" "start" "-a" "ef96ee3ec74d99f0ac973835e80166c3ef722bbfcde2ce2c92a54cbe94b0fd61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef96ee3ec74d99f0ac973835e80166c3ef722bbfcde2ce2c92a54cbe94b0fd61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef96ee3ec74d99f0ac973835e80166c3ef722bbfcde2ce2c92a54cbe94b0fd61", kill_on_drop: false }` [INFO] [stdout] ef96ee3ec74d99f0ac973835e80166c3ef722bbfcde2ce2c92a54cbe94b0fd61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af42072ac59d3a1e81aa9e5900f3e77df62fbbc5291f12ab15f47cd4e46a6a80 [INFO] running `Command { std: "docker" "start" "-a" "af42072ac59d3a1e81aa9e5900f3e77df62fbbc5291f12ab15f47cd4e46a6a80", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking std_prelude v0.2.12 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking stfu8 v0.2.7 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking taken v0.1.1 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Compiling configure_derive v0.1.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking nix v0.29.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking shellexpand v1.1.1 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.42 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Checking ergo_sync v0.1.0 [INFO] [stderr] Checking ctrlc v3.4.5 [INFO] [stderr] Checking ergo_sys v0.0.1 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking ron v0.1.7 [INFO] [stderr] Checking path_abs v0.4.1 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ergo_fs v0.2.0 [INFO] [stderr] Checking ergo_std v0.0.3 [INFO] [stderr] Checking configure v0.1.1 [INFO] [stderr] Checking ergo_config v0.0.1 [INFO] [stderr] Checking ergo v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `ergo_sync::IntoIter<(ergo_fs::PathFile, ergo_fs::PathBuf)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deep_copy.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | for (from, to_postfix) in recv_file { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 39 | / ch_try!( [INFO] [stdout] 40 | | send_err, [INFO] [stdout] 41 | | from.copy(to.join(to_postfix)).map_err(|err| err.into()), [INFO] [stdout] 42 | | continue [INFO] [stdout] 43 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deep_copy.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 51 | from: PathDir, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | to: PathDir, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | send_err: Sender, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | send_file: Sender<(PathFile, PathBuf)>, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | ) { [INFO] [stdout] 56 | let mut it = from.walk().follow_links(true).into_iter(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | loop { [INFO] [stdout] 58 | let entry = match it.next() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | let entry = handle_err!(entry); [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let to_postfix = handle_err!(to_postfix); [INFO] [stdout] | ----------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | match handle_err!(PathType::new(entry.path())) { [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | ch!(send_err <- err.into()); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | ch!(send_file <- (from_file, to_postfix.to_path_buf())); [INFO] [stdout] | ------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ergo` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `ergo_sync::IntoIter<(ergo_fs::PathFile, ergo_fs::PathBuf)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deep_copy.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | for (from, to_postfix) in recv_file { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 39 | / ch_try!( [INFO] [stdout] 40 | | send_err, [INFO] [stdout] 41 | | from.copy(to.join(to_postfix)).map_err(|err| err.into()), [INFO] [stdout] 42 | | continue [INFO] [stdout] 43 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deep_copy.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 51 | from: PathDir, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | to: PathDir, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | send_err: Sender, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | send_file: Sender<(PathFile, PathBuf)>, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | ) { [INFO] [stdout] 56 | let mut it = from.walk().follow_links(true).into_iter(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | loop { [INFO] [stdout] 58 | let entry = match it.next() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 73 | let entry = handle_err!(entry); [INFO] [stdout] | ------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let to_postfix = handle_err!(to_postfix); [INFO] [stdout] | ----------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | match handle_err!(PathType::new(entry.path())) { [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | ch!(send_err <- err.into()); [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | ch!(send_file <- (from_file, to_postfix.to_path_buf())); [INFO] [stdout] | ------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ergo` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "af42072ac59d3a1e81aa9e5900f3e77df62fbbc5291f12ab15f47cd4e46a6a80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af42072ac59d3a1e81aa9e5900f3e77df62fbbc5291f12ab15f47cd4e46a6a80", kill_on_drop: false }` [INFO] [stdout] af42072ac59d3a1e81aa9e5900f3e77df62fbbc5291f12ab15f47cd4e46a6a80