[INFO] fetching crate elm-solve-deps 0.1.1... [INFO] checking elm-solve-deps-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate elm-solve-deps 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate elm-solve-deps 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate elm-solve-deps 0.1.1 [INFO] finished tweaking crates.io crate elm-solve-deps 0.1.1 [INFO] tweaked toml for crates.io crate elm-solve-deps 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate elm-solve-deps 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d6d848ae4ec25f55b095551c7116f2f7321209629fe70e90ec8b70590644cb2a [INFO] running `Command { std: "docker" "start" "-a" "d6d848ae4ec25f55b095551c7116f2f7321209629fe70e90ec8b70590644cb2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d6d848ae4ec25f55b095551c7116f2f7321209629fe70e90ec8b70590644cb2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6d848ae4ec25f55b095551c7116f2f7321209629fe70e90ec8b70590644cb2a", kill_on_drop: false }` [INFO] [stdout] d6d848ae4ec25f55b095551c7116f2f7321209629fe70e90ec8b70590644cb2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0423142287a95c2d689b82cefa858de13048a7cc8195797af385b4ab3aac18ab [INFO] running `Command { std: "docker" "start" "-a" "0423142287a95c2d689b82cefa858de13048a7cc8195797af385b4ab3aac18ab", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.132 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling serde v1.0.132 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Compiling const_fn v0.4.8 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking qstring v0.7.2 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Compiling cookie v0.14.4 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking publicsuffix v1.5.6 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking webpki-roots v0.21.1 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking pubgrub v0.2.1 [INFO] [stderr] Checking ron v0.6.6 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking cookie_store v0.12.0 [INFO] [stderr] Checking elm-solve-deps v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking ureq v1.5.5 [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/solver.rs:171:54 [INFO] [stdout] | [INFO] [stdout] 171 | .filter(|v| range.borrow().contains(v.borrow())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `SemanticVersion` does not implement `Borrow`, so calling `borrow` on `&SemanticVersion` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 171 - .filter(|v| range.borrow().contains(v.borrow())) [INFO] [stdout] 171 + .filter(|v| range.borrow().contains(v)) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `SemanticVersion`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/pubgrub-0.2.1/src/version.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 + #[derive(Clone)] [INFO] [stdout] 21 | pub struct SemanticVersion { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/solver.rs:179:48 [INFO] [stdout] | [INFO] [stdout] 179 | .find(|v| range.borrow().contains(v.borrow())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `SemanticVersion` does not implement `Borrow`, so calling `borrow` on `&SemanticVersion` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 179 - .find(|v| range.borrow().contains(v.borrow())); [INFO] [stdout] 179 + .find(|v| range.borrow().contains(v)); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `SemanticVersion`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/pubgrub-0.2.1/src/version.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 + #[derive(Clone)] [INFO] [stdout] 21 | pub struct SemanticVersion { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/solver.rs:171:54 [INFO] [stdout] | [INFO] [stdout] 171 | .filter(|v| range.borrow().contains(v.borrow())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `SemanticVersion` does not implement `Borrow`, so calling `borrow` on `&SemanticVersion` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 171 - .filter(|v| range.borrow().contains(v.borrow())) [INFO] [stdout] 171 + .filter(|v| range.borrow().contains(v)) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `SemanticVersion`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/pubgrub-0.2.1/src/version.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 + #[derive(Clone)] [INFO] [stdout] 21 | pub struct SemanticVersion { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/solver.rs:179:48 [INFO] [stdout] | [INFO] [stdout] 179 | .find(|v| range.borrow().contains(v.borrow())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `SemanticVersion` does not implement `Borrow`, so calling `borrow` on `&SemanticVersion` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 179 - .find(|v| range.borrow().contains(v.borrow())); [INFO] [stdout] 179 + .find(|v| range.borrow().contains(v)); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `SemanticVersion`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/pubgrub-0.2.1/src/version.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 + #[derive(Clone)] [INFO] [stdout] 21 | pub struct SemanticVersion { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.66s [INFO] running `Command { std: "docker" "inspect" "0423142287a95c2d689b82cefa858de13048a7cc8195797af385b4ab3aac18ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0423142287a95c2d689b82cefa858de13048a7cc8195797af385b4ab3aac18ab", kill_on_drop: false }` [INFO] [stdout] 0423142287a95c2d689b82cefa858de13048a7cc8195797af385b4ab3aac18ab