[INFO] fetching crate dynparser 0.4.2... [INFO] checking dynparser-0.4.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate dynparser 0.4.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dynparser 0.4.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dynparser 0.4.2 [INFO] finished tweaking crates.io crate dynparser 0.4.2 [INFO] tweaked toml for crates.io crate dynparser 0.4.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 1 package to latest compatible version [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 79e19038aaddc578d6b180e9c590b7ef09b16e47a67edd8f387e001958de6344 [INFO] running `Command { std: "docker" "start" "-a" "79e19038aaddc578d6b180e9c590b7ef09b16e47a67edd8f387e001958de6344", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "79e19038aaddc578d6b180e9c590b7ef09b16e47a67edd8f387e001958de6344", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79e19038aaddc578d6b180e9c590b7ef09b16e47a67edd8f387e001958de6344", kill_on_drop: false }` [INFO] [stdout] 79e19038aaddc578d6b180e9c590b7ef09b16e47a67edd8f387e001958de6344 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 407f3c8beb648fc16ebc905866347463064c7985d18b06cb922c169daad4196b [INFO] running `Command { std: "docker" "start" "-a" "407f3c8beb648fc16ebc905866347463064c7985d18b06cb922c169daad4196b", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking idata v0.1.2 [INFO] [stderr] Checking dynparser v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 137 | #[cfg_attr(feature = "cargo-clippy", allow(let_and_return))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ast/mod.rs:142:10 [INFO] [stdout] | [INFO] [stdout] 142 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ast/mod.rs:200:10 [INFO] [stdout] | [INFO] [stdout] 200 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ast/mod.rs:205:10 [INFO] [stdout] | [INFO] [stdout] 205 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/peg/mod.rs:338:6 [INFO] [stdout] | [INFO] [stdout] 338 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/peg/mod.rs:726:98 [INFO] [stdout] | [INFO] [stdout] 726 | let (to, _) = idata::consume_char(chars).ok_or_else(|| error_peg_s("expected to char"))?;; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 137 | #[cfg_attr(feature = "cargo-clippy", allow(let_and_return))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ast/mod.rs:142:10 [INFO] [stdout] | [INFO] [stdout] 142 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ast/mod.rs:200:10 [INFO] [stdout] | [INFO] [stdout] 200 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ast/mod.rs:205:10 [INFO] [stdout] | [INFO] [stdout] 205 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/peg/mod.rs:338:6 [INFO] [stdout] | [INFO] [stdout] 338 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/peg/mod.rs:726:98 [INFO] [stdout] | [INFO] [stdout] 726 | let (to, _) = idata::consume_char(chars).ok_or_else(|| error_peg_s("expected to char"))?;; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Started` is never constructed [INFO] [stdout] --> src/parser/expression/mod.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) struct Started(usize); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Expression` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expression/test.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 88 | let rules = rules!{}; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let expr = Expression::Or(MultiExpr(rules)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Expression` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expression/test.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 148 | let rules = rules!{}; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let expr = repeat_literal("bb".to_string(), NRep(0), None); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Started` is never constructed [INFO] [stdout] --> src/parser/expression/mod.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) struct Started(usize); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dynparser` (lib test) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "407f3c8beb648fc16ebc905866347463064c7985d18b06cb922c169daad4196b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "407f3c8beb648fc16ebc905866347463064c7985d18b06cb922c169daad4196b", kill_on_drop: false }` [INFO] [stdout] 407f3c8beb648fc16ebc905866347463064c7985d18b06cb922c169daad4196b