[INFO] fetching crate duckdb-extension-framework 0.7.0... [INFO] checking duckdb-extension-framework-0.7.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate duckdb-extension-framework 0.7.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate duckdb-extension-framework 0.7.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate duckdb-extension-framework 0.7.0 [INFO] finished tweaking crates.io crate duckdb-extension-framework 0.7.0 [INFO] tweaked toml for crates.io crate duckdb-extension-framework 0.7.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.61.0 (available: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding num-derive v0.3.3 (available: v0.4.2) [INFO] [stderr] Adding peeking_take_while v0.1.2 (available: v1.0.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding which v4.4.2 (available: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 037fa3c82d1955729ded91f15619c8c8478089c57519b02fb9e27f9430678991 [INFO] running `Command { std: "docker" "start" "-a" "037fa3c82d1955729ded91f15619c8c8478089c57519b02fb9e27f9430678991", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "037fa3c82d1955729ded91f15619c8c8478089c57519b02fb9e27f9430678991", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "037fa3c82d1955729ded91f15619c8c8478089c57519b02fb9e27f9430678991", kill_on_drop: false }` [INFO] [stdout] 037fa3c82d1955729ded91f15619c8c8478089c57519b02fb9e27f9430678991 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b12c30d9cb8bab06ecab89f3e83d9836b54787b6c58ce816485405242b28a377 [INFO] running `Command { std: "docker" "start" "-a" "b12c30d9cb8bab06ecab89f3e83d9836b54787b6c58ce816485405242b28a377", kill_on_drop: false }` [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling libloading v0.8.5 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling bindgen v0.61.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling build_script v0.2.0 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling duckdb-extension-framework v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/constants.rs:3:32 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Eq, PartialEq, num_derive::FromPrimitive)] [INFO] [stdout] | ^------------------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_LogicalTypeId` [INFO] [stdout] 4 | pub enum LogicalTypeId { [INFO] [stdout] | ------------- `LogicalTypeId` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `num_derive::FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `num_derive::FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `num_derive::FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> src/logical_type.rs:75:38 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|it| CString::new(it.deref()).unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/bind_info.rs:26:53 [INFO] [stdout] | [INFO] [stdout] 26 | duckdb_bind_add_result_column(self.ptr, as_string!(column_name), column_type.typ); [INFO] [stdout] | ----------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/bind_info.rs:35:45 [INFO] [stdout] | [INFO] [stdout] 35 | duckdb_bind_set_error(self.ptr, as_string!(error)); [INFO] [stdout] | ----------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/function_info.rs:21:47 [INFO] [stdout] | [INFO] [stdout] 21 | duckdb_function_set_error(self.0, as_string!(error)); [INFO] [stdout] | ----------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/constants.rs:3:32 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Eq, PartialEq, num_derive::FromPrimitive)] [INFO] [stdout] | ^------------------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_LogicalTypeId` [INFO] [stdout] 4 | pub enum LogicalTypeId { [INFO] [stdout] | ------------- `LogicalTypeId` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `num_derive::FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `num_derive::FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `num_derive::FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> src/logical_type.rs:75:38 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|it| CString::new(it.deref()).unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/bind_info.rs:26:53 [INFO] [stdout] | [INFO] [stdout] 26 | duckdb_bind_add_result_column(self.ptr, as_string!(column_name), column_type.typ); [INFO] [stdout] | ----------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/bind_info.rs:35:45 [INFO] [stdout] | [INFO] [stdout] 35 | duckdb_bind_set_error(self.ptr, as_string!(error)); [INFO] [stdout] | ----------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/function_info.rs:21:47 [INFO] [stdout] | [INFO] [stdout] 21 | duckdb_function_set_error(self.0, as_string!(error)); [INFO] [stdout] | ----------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.22s [INFO] running `Command { std: "docker" "inspect" "b12c30d9cb8bab06ecab89f3e83d9836b54787b6c58ce816485405242b28a377", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b12c30d9cb8bab06ecab89f3e83d9836b54787b6c58ce816485405242b28a377", kill_on_drop: false }` [INFO] [stdout] b12c30d9cb8bab06ecab89f3e83d9836b54787b6c58ce816485405242b28a377