[INFO] fetching crate dsntk-feel-evaluator 0.0.8... [INFO] checking dsntk-feel-evaluator-0.0.8 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate dsntk-feel-evaluator 0.0.8 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dsntk-feel-evaluator 0.0.8 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dsntk-feel-evaluator 0.0.8 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate dsntk-feel-evaluator 0.0.8 [INFO] tweaked toml for crates.io crate dsntk-feel-evaluator 0.0.8 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 155 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-registry v0.2.0 (available: v0.3.0) [INFO] [stderr] Adding windows-strings v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32aa63fcab660a7911913836d8352d9f10ad91bca81168552cdcaf42cfa32e7d [INFO] running `Command { std: "docker" "start" "-a" "32aa63fcab660a7911913836d8352d9f10ad91bca81168552cdcaf42cfa32e7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32aa63fcab660a7911913836d8352d9f10ad91bca81168552cdcaf42cfa32e7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32aa63fcab660a7911913836d8352d9f10ad91bca81168552cdcaf42cfa32e7d", kill_on_drop: false }` [INFO] [stdout] 32aa63fcab660a7911913836d8352d9f10ad91bca81168552cdcaf42cfa32e7d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b2b07346d7bd37ba7630779ee415ca841594199ee4b435716e911414d893a81 [INFO] running `Command { std: "docker" "start" "-a" "1b2b07346d7bd37ba7630779ee415ca841594199ee4b435716e911414d893a81", kill_on_drop: false }` [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling dfp-number-sys v0.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking uriparse v0.6.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling rustls v0.23.13 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking webpki-roots v0.26.6 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking dsntk-feel-regex v0.0.8 [INFO] [stderr] Compiling dsntk-feel-grammar v0.0.8 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling chrono-tz-build v0.4.0 [INFO] [stderr] Compiling dsntk-feel-parser v0.0.8 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Compiling chrono-tz v0.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling dsntk-macros v0.0.8 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Checking hyper-rustls v0.27.3 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking dsntk-common v0.0.8 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking dsntk-feel-number v0.0.8 [INFO] [stderr] Checking dsntk-feel-temporal v0.0.8 [INFO] [stderr] Checking dsntk-feel v0.0.8 [INFO] [stderr] Checking dsntk-feel-evaluator v0.0.8 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bifs/core.rs:2093:43 [INFO] [stdout] | [INFO] [stdout] 2092 | let scope: FeelScope = ctx.into(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2093 | if let Value::Boolean(result) = body.evaluate(&scope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluators.rs:47:36 [INFO] [stdout] | [INFO] [stdout] 46 | let evaluator = crate::builders::build_evaluator(node); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | if let Value::Context(context) = evaluator(scope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluators.rs:63:45 [INFO] [stdout] | [INFO] [stdout] 62 | let evaluator = crate::builders::build_evaluator(node); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | if let value @ Value::Range(_, _, _, _) = evaluator(scope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dsntk-feel-evaluator` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `dsntk_feel::values::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bifs/core.rs:2093:43 [INFO] [stdout] | [INFO] [stdout] 2092 | let scope: FeelScope = ctx.into(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2093 | if let Value::Boolean(result) = body.evaluate(&scope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `dsntk_feel::values::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluators.rs:47:36 [INFO] [stdout] | [INFO] [stdout] 46 | let evaluator = crate::builders::build_evaluator(node); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | if let Value::Context(context) = evaluator(scope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `dsntk_feel::values::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluators.rs:63:45 [INFO] [stdout] | [INFO] [stdout] 62 | let evaluator = crate::builders::build_evaluator(node); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | if let value @ Value::Range(_, _, _, _) = evaluator(scope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | let scope = FeelScope::default(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | match dsntk_feel_parser::parse_context(&scope, input, false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn te_context(trace: bool, scope: &FeelScope, actual: Actual, expected: Expected) { [INFO] [stdout] | ------ -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | match dsntk_feel_parser::parse_context(scope, &expected.to_string(), trace) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn boxed_expression(trace: bool, scope: &FeelScope, text: &str, expected: Value) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | match dsntk_feel_parser::parse_boxed_expression(scope, text, trace) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/mod.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 238 | fn textual_expression(trace: bool, scope: &FeelScope, text: &str, expected: Value) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | match dsntk_feel_parser::parse_textual_expression(scope, text, trace) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dsntk-feel-evaluator` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "1b2b07346d7bd37ba7630779ee415ca841594199ee4b435716e911414d893a81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b2b07346d7bd37ba7630779ee415ca841594199ee4b435716e911414d893a81", kill_on_drop: false }` [INFO] [stdout] 1b2b07346d7bd37ba7630779ee415ca841594199ee4b435716e911414d893a81