[INFO] fetching crate dotlr 0.2.1... [INFO] checking dotlr-0.2.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate dotlr 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate dotlr 0.2.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dotlr 0.2.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate dotlr 0.2.1 [INFO] tweaked toml for crates.io crate dotlr 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate dotlr 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1309d1bafa8699eb69053d350693803af6dda7b561fd7c66710624cc11fce74c [INFO] running `Command { std: "docker" "start" "-a" "1309d1bafa8699eb69053d350693803af6dda7b561fd7c66710624cc11fce74c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1309d1bafa8699eb69053d350693803af6dda7b561fd7c66710624cc11fce74c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1309d1bafa8699eb69053d350693803af6dda7b561fd7c66710624cc11fce74c", kill_on_drop: false }` [INFO] [stdout] 1309d1bafa8699eb69053d350693803af6dda7b561fd7c66710624cc11fce74c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 263a79c89d390935f7943121ea73a1ae44cb5db8f28d2629277b566c3edfd07e [INFO] running `Command { std: "docker" "start" "-a" "263a79c89d390935f7943121ea73a1ae44cb5db8f28d2629277b566c3edfd07e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling rustix v0.38.36 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking clap_builder v4.5.17 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking tint v1.0.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking smol_str v0.3.1 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking ordered-multimap v0.6.0 [INFO] [stderr] Checking rust-ini v0.19.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Compiling logos-codegen v0.14.1 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.82 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling logos-derive v0.14.1 [INFO] [stderr] Checking logos v0.14.1 [INFO] [stderr] Compiling pest v2.7.12 [INFO] [stderr] Checking clap v4.5.17 [INFO] [stderr] Compiling pest_meta v2.7.12 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Compiling pest_generator v2.7.12 [INFO] [stderr] Compiling pest_derive v2.7.12 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking prettytable-rs v0.10.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking fd-lock v4.0.2 [INFO] [stderr] Checking rustyline v14.0.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking ptree v0.5.0 [INFO] [stderr] Checking dotlr v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/calculator.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 30 | let mut editor = DefaultEditor::new().expect("repl cannot be created"); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let readline = editor.readline(&cursor); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `dotlr::Token` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/calculator.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 85 | fn evaluate(tree: Tree<'_>) -> f64 { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | match tree { [INFO] [stdout] 87 | Tree::Terminal { token, slice } => { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dotlr` (example "calculator") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `dotlr::Token` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/json.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 22 | fn from(tree: Tree) -> Value { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | match tree { [INFO] [stdout] 24 | Tree::Terminal { token, slice } => { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `dotlr::Symbol` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/json.rs:62:57 [INFO] [stdout] | [INFO] [stdout] 60 | ... fn collect(elements: Tree, values: &mut Vec) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | ... match elements { [INFO] [stdout] 62 | ... Tree::NonTerminal { symbol, pattern } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `dotlr::Symbol` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/json.rs:97:57 [INFO] [stdout] | [INFO] [stdout] 95 | ... fn collect(elements: Tree, entries: &mut IndexMap) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | ... match elements { [INFO] [stdout] 97 | ... Tree::NonTerminal { symbol, pattern } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dotlr` (example "json") due to 4 previous errors [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/parser.rs:69:36 [INFO] [stdout] | [INFO] [stdout] 66 | let error = Parser::lr(grammar).unwrap_err(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | if let ParserError::Conflict { parser, token, state } = error { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/parser.rs:96:36 [INFO] [stdout] | [INFO] [stdout] 93 | let error = Parser::lr(grammar).unwrap_err(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | if let ParserError::Conflict { parser, token, state } = error { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/parser.rs:119:36 [INFO] [stdout] | [INFO] [stdout] 116 | let error = Parser::lalr(grammar).unwrap_err(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | if let ParserError::Conflict { parser, token, state } = error { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `[IndexMap; 7]` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/parser.rs:613:13 [INFO] [stdout] | [INFO] [stdout] 133 | let parser = Parser::lr(grammar).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 613 | / [ [INFO] [stdout] 614 | | // State 0 [INFO] [stdout] 615 | | IndexMap::::from_iter( [INFO] [stdout] 616 | | [ [INFO] [stdout] ... | [INFO] [stdout] 651 | | ), [INFO] [stdout] 652 | | ] [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `[IndexMap; 9]` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/parser.rs:1417:13 [INFO] [stdout] | [INFO] [stdout] 660 | let parser = Parser::lalr(grammar).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1417 | / [ [INFO] [stdout] 1418 | | // State 0 [INFO] [stdout] 1419 | | IndexMap::::from_iter( [INFO] [stdout] 1420 | | [ [INFO] [stdout] ... | [INFO] [stdout] 1467 | | ), [INFO] [stdout] 1468 | | ] [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dotlr` (test "parser") due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "263a79c89d390935f7943121ea73a1ae44cb5db8f28d2629277b566c3edfd07e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "263a79c89d390935f7943121ea73a1ae44cb5db8f28d2629277b566c3edfd07e", kill_on_drop: false }` [INFO] [stdout] 263a79c89d390935f7943121ea73a1ae44cb5db8f28d2629277b566c3edfd07e