[INFO] fetching crate dipstick 0.9.2... [INFO] checking dipstick-0.9.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate dipstick 0.9.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate dipstick 0.9.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dipstick 0.9.2 [INFO] finished tweaking crates.io crate dipstick 0.9.2 [INFO] tweaked toml for crates.io crate dipstick 0.9.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate dipstick 0.9.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 927fa67b77658b01bca8557eff230ceb13ebaa68b1eaa48f699c457fae6b9dc8 [INFO] running `Command { std: "docker" "start" "-a" "927fa67b77658b01bca8557eff230ceb13ebaa68b1eaa48f699c457fae6b9dc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "927fa67b77658b01bca8557eff230ceb13ebaa68b1eaa48f699c457fae6b9dc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "927fa67b77658b01bca8557eff230ceb13ebaa68b1eaa48f699c457fae6b9dc8", kill_on_drop: false }` [INFO] [stdout] 927fa67b77658b01bca8557eff230ceb13ebaa68b1eaa48f699c457fae6b9dc8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ace13892a46f72fe3931c1febebf0b479ea72d426679e4ac2b2a7405689b69c2 [INFO] running `Command { std: "docker" "start" "-a" "ace13892a46f72fe3931c1febebf0b479ea72d426679e4ac2b2a7405689b69c2", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling minreq v2.6.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking atomic_refcell v0.1.9 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking dipstick v0.9.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Proxy` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 225 | fn from(name: S) -> Proxy { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Proxy::new().named(name.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `AtomicBucket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 151 | fn from(name: S) -> AtomicBucket { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | AtomicBucket::new().named(name.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, BTreeMap>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/map.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(map: StatsMapScope) -> Self { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | map.inner.read().unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/stream.rs:190:23 [INFO] [stdout] | [INFO] [stdout] 188 | InputMetric::new(metric_id, move |value, labels| { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut buffer = Vec::with_capacity(32); [INFO] [stdout] 190 | match template.print(&mut buffer, value, |key| labels.lookup(key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/stream.rs:203:23 [INFO] [stdout] | [INFO] [stdout] 201 | InputMetric::new(metric_id, move |value, labels| { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let mut buffer = Vec::with_capacity(32); [INFO] [stdout] 203 | match template.print(&mut buffer, value, |key| labels.lookup(key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/log.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 118 | InputMetric::new(MetricId::forge("log", name), move |value, labels| { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut buffer = Vec::with_capacity(32); [INFO] [stdout] 120 | match template.print(&mut buffer, value, |key| labels.lookup(key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/log.rs:134:23 [INFO] [stdout] | [INFO] [stdout] 132 | InputMetric::new(MetricId::forge("log", name), move |value, labels| { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let mut buffer = Vec::with_capacity(32); [INFO] [stdout] 134 | match template.print(&mut buffer, value, |key| labels.lookup(key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/graphite.rs:150:15 [INFO] [stdout] | [INFO] [stdout] 144 | fn flush_inner(&self, mut buf: RwLockWriteGuard) -> io::Result<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let mut sock = write_lock!(self.socket); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | match sock.write_all(buf.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/prometheus.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 157 | fn flush_inner(&self, mut buf: RwLockWriteGuard) -> io::Result<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | match minreq::post(self.push_url.as_str()) [INFO] [stdout] | _______________^ [INFO] [stdout] 163 | | .with_body(buf.as_str()) [INFO] [stdout] 164 | | .send() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Proxy` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 225 | fn from(name: S) -> Proxy { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | Proxy::new().named(name.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dipstick` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `atomic::AtomicBucket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 151 | fn from(name: S) -> AtomicBucket { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | AtomicBucket::new().named(name.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, BTreeMap>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/map.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(map: StatsMapScope) -> Self { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | map.inner.read().unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/stream.rs:190:23 [INFO] [stdout] | [INFO] [stdout] 188 | InputMetric::new(metric_id, move |value, labels| { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let mut buffer = Vec::with_capacity(32); [INFO] [stdout] 190 | match template.print(&mut buffer, value, |key| labels.lookup(key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/stream.rs:203:23 [INFO] [stdout] | [INFO] [stdout] 201 | InputMetric::new(metric_id, move |value, labels| { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let mut buffer = Vec::with_capacity(32); [INFO] [stdout] 203 | match template.print(&mut buffer, value, |key| labels.lookup(key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/log.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 118 | InputMetric::new(MetricId::forge("log", name), move |value, labels| { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut buffer = Vec::with_capacity(32); [INFO] [stdout] 120 | match template.print(&mut buffer, value, |key| labels.lookup(key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/log.rs:134:23 [INFO] [stdout] | [INFO] [stdout] 132 | InputMetric::new(MetricId::forge("log", name), move |value, labels| { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let mut buffer = Vec::with_capacity(32); [INFO] [stdout] 134 | match template.print(&mut buffer, value, |key| labels.lookup(key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/graphite.rs:150:15 [INFO] [stdout] | [INFO] [stdout] 144 | fn flush_inner(&self, mut buf: RwLockWriteGuard) -> io::Result<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let mut sock = write_lock!(self.socket); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | match sock.write_all(buf.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/prometheus.rs:162:15 [INFO] [stdout] | [INFO] [stdout] 157 | fn flush_inner(&self, mut buf: RwLockWriteGuard) -> io::Result<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | match minreq::post(self.push_url.as_str()) [INFO] [stdout] | _______________^ [INFO] [stdout] 163 | | .with_body(buf.as_str()) [INFO] [stdout] 164 | | .send() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dipstick` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "ace13892a46f72fe3931c1febebf0b479ea72d426679e4ac2b2a7405689b69c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ace13892a46f72fe3931c1febebf0b479ea72d426679e4ac2b2a7405689b69c2", kill_on_drop: false }` [INFO] [stdout] ace13892a46f72fe3931c1febebf0b479ea72d426679e4ac2b2a7405689b69c2