[INFO] fetching crate diplomat-tool 0.8.0... [INFO] checking diplomat-tool-0.8.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate diplomat-tool 0.8.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate diplomat-tool 0.8.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate diplomat-tool 0.8.0 [INFO] finished tweaking crates.io crate diplomat-tool 0.8.0 [INFO] tweaked toml for crates.io crate diplomat-tool 0.8.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate diplomat-tool 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0693606d6973ff0e09817303968a5d8a41f747e44cbb372a8ee3b5391fb139b5 [INFO] running `Command { std: "docker" "start" "-a" "0693606d6973ff0e09817303968a5d8a41f747e44cbb372a8ee3b5391fb139b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0693606d6973ff0e09817303968a5d8a41f747e44cbb372a8ee3b5391fb139b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0693606d6973ff0e09817303968a5d8a41f747e44cbb372a8ee3b5391fb139b5", kill_on_drop: false }` [INFO] [stdout] 0693606d6973ff0e09817303968a5d8a41f747e44cbb372a8ee3b5391fb139b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c3c307a9389379e44a271310ab52506a6ac9af8e86dbf082fe05171de84b24d [INFO] running `Command { std: "docker" "start" "-a" "9c3c307a9389379e44a271310ab52506a6ac9af8e86dbf082fe05171de84b24d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling pulldown-cmark v0.8.0 [INFO] [stderr] Checking strck v0.1.2 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking askama_escape v0.10.3 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking similar v2.4.0 [INFO] [stderr] Checking strck_ident v0.1.2 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking quote v1.0.35 [INFO] [stderr] Checking syn v2.0.55 [INFO] [stderr] Compiling askama_parser v0.2.1 [INFO] [stderr] Checking syn-inline-mod v0.6.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.3 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Checking serde v1.0.197 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking diplomat_core v0.8.0 [INFO] [stderr] Checking insta v1.36.1 [INFO] [stderr] Compiling basic-toml v0.1.9 [INFO] [stderr] Compiling askama_derive v0.12.5 [INFO] [stderr] Checking askama v0.12.1 [INFO] [stderr] Checking diplomat-tool v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Argument<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js/conversions.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 105 | param_name: UnpackedBinding<'env>, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let param_name_buf = Argument::DiplomatBuf(param_name.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/js/conversions.rs:37:49 [INFO] [stdout] | [INFO] [stdout] 37 | #[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Display, Debug)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_UnpackedBinding` [INFO] [stdout] 38 | pub enum UnpackedBinding<'env> { [INFO] [stdout] | --------------- `UnpackedBinding` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/js/conversions.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | #[derive(Clone, Display, Debug, PartialEq, Eq, PartialOrd, Ord)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_Argument` [INFO] [stdout] 58 | pub enum Argument<'env> { [INFO] [stdout] | -------- `Argument` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/js/conversions.rs:665:10 [INFO] [stdout] | [INFO] [stdout] 665 | #[derive(Display)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_JsPrimitiveNumber` [INFO] [stdout] 666 | enum JsPrimitiveNumber { [INFO] [stdout] | ----------------- `JsPrimitiveNumber` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diplomat-tool` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Argument<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/js/conversions.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 105 | param_name: UnpackedBinding<'env>, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let param_name_buf = Argument::DiplomatBuf(param_name.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kotlin/formatter.rs:347:15 [INFO] [stdout] | [INFO] [stdout] 338 | let item = syn::parse2::(tk_stream).expect("failed to parse item "); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | [INFO] [stdout] 340 | let diplomat_file = ast::File::from(&item); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | [INFO] [stdout] 342 | let env = diplomat_file.all_types(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 347 | match hir::TypeContext::from_ast(&env, attr_validator) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/js/conversions.rs:37:49 [INFO] [stdout] | [INFO] [stdout] 37 | #[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Display, Debug)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_UnpackedBinding` [INFO] [stdout] 38 | pub enum UnpackedBinding<'env> { [INFO] [stdout] | --------------- `UnpackedBinding` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/js/conversions.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | #[derive(Clone, Display, Debug, PartialEq, Eq, PartialOrd, Ord)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_Argument` [INFO] [stdout] 58 | pub enum Argument<'env> { [INFO] [stdout] | -------- `Argument` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/js/conversions.rs:665:10 [INFO] [stdout] | [INFO] [stdout] 665 | #[derive(Display)] [INFO] [stdout] | ^------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_Display_FOR_JsPrimitiveNumber` [INFO] [stdout] 666 | enum JsPrimitiveNumber { [INFO] [stdout] | ----------------- `JsPrimitiveNumber` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `displaydoc` crate, try updating your dependency with `cargo update -p displaydoc` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diplomat-tool` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9c3c307a9389379e44a271310ab52506a6ac9af8e86dbf082fe05171de84b24d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c3c307a9389379e44a271310ab52506a6ac9af8e86dbf082fe05171de84b24d", kill_on_drop: false }` [INFO] [stdout] 9c3c307a9389379e44a271310ab52506a6ac9af8e86dbf082fe05171de84b24d