[INFO] fetching crate diffus 0.10.0... [INFO] checking diffus-0.10.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate diffus 0.10.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate diffus 0.10.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate diffus 0.10.0 [INFO] finished tweaking crates.io crate diffus 0.10.0 [INFO] tweaked toml for crates.io crate diffus 0.10.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b150a2176b5feb7df819eb693f6c2fc11f63f19dfbe969031c4eeb8ae45c328 [INFO] running `Command { std: "docker" "start" "-a" "7b150a2176b5feb7df819eb693f6c2fc11f63f19dfbe969031c4eeb8ae45c328", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b150a2176b5feb7df819eb693f6c2fc11f63f19dfbe969031c4eeb8ae45c328", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b150a2176b5feb7df819eb693f6c2fc11f63f19dfbe969031c4eeb8ae45c328", kill_on_drop: false }` [INFO] [stdout] 7b150a2176b5feb7df819eb693f6c2fc11f63f19dfbe969031c4eeb8ae45c328 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26a37a51e9dc11e5795931245cfe3418859eca2cc04ef44ac98400a3a6e33ccf [INFO] running `Command { std: "docker" "start" "-a" "26a37a51e9dc11e5795931245cfe3418859eca2cc04ef44ac98400a3a6e33ccf", kill_on_drop: false }` [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking diffus v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/collection.rs:12:65 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'a, T: Same + Diffable<'a> + 'a> Diffable<'a> for $typ { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 12 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] ... [INFO] [stdout] 36 | / collection_impl! { [INFO] [stdout] 37 | | BinaryHeap, LinkedList, Vec, VecDeque [INFO] [stdout] 38 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] = note: this warning originates in the macro `collection_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/map.rs:12:59 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'a, K: Eq + $key_constraint + 'a, V: Diffable<'a> + 'a> Diffable<'a> for $typ { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 12 | fn diff(&'a self, other: &'a Self) -> Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] ... [INFO] [stdout] 42 | / map_impl! { [INFO] [stdout] 43 | | (BTreeMap, Ord), [INFO] [stdout] 44 | | (HashMap, Hash) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `map_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/option.rs:9:53 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'a, T: Diffable<'a> + 'a> Diffable<'a> for Option { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 9 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/primitives.rs:9:65 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'a> Diffable<'a> for $typ { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 9 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] ... [INFO] [stdout] 22 | primitive_impl! { i64, i32, i16, i8, u64, u32, u16, u8, char, bool, isize, usize, f32, f64, () } [INFO] [stdout] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `primitive_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/set.rs:12:59 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'a, K: Diffable<'a> + Eq + $key_constraint + 'a> Diffable<'a> for $typ { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 12 | fn diff(&'a self, other: &'a Self) -> Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] ... [INFO] [stdout] 42 | / set_impl! { [INFO] [stdout] 43 | | (BTreeSet, Ord, BTreeMap), [INFO] [stdout] 44 | | (HashSet, Hash, HashMap) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `set_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/string.rs:9:53 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'a> Diffable<'a> for str { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 9 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/string.rs:30:53 [INFO] [stdout] | [INFO] [stdout] 27 | impl<'a> Diffable<'a> for String { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 30 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/collection.rs:12:65 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'a, T: Same + Diffable<'a> + 'a> Diffable<'a> for $typ { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 12 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] ... [INFO] [stdout] 36 | / collection_impl! { [INFO] [stdout] 37 | | BinaryHeap, LinkedList, Vec, VecDeque [INFO] [stdout] 38 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] = note: this warning originates in the macro `collection_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/map.rs:12:59 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'a, K: Eq + $key_constraint + 'a, V: Diffable<'a> + 'a> Diffable<'a> for $typ { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 12 | fn diff(&'a self, other: &'a Self) -> Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] ... [INFO] [stdout] 42 | / map_impl! { [INFO] [stdout] 43 | | (BTreeMap, Ord), [INFO] [stdout] 44 | | (HashMap, Hash) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `map_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/option.rs:9:53 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'a, T: Diffable<'a> + 'a> Diffable<'a> for Option { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 9 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/primitives.rs:9:65 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'a> Diffable<'a> for $typ { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 9 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] ... [INFO] [stdout] 22 | primitive_impl! { i64, i32, i16, i8, u64, u32, u16, u8, char, bool, isize, usize, f32, f64, () } [INFO] [stdout] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `primitive_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/set.rs:12:59 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'a, K: Diffable<'a> + Eq + $key_constraint + 'a> Diffable<'a> for $typ { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 12 | fn diff(&'a self, other: &'a Self) -> Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] ... [INFO] [stdout] 42 | / set_impl! { [INFO] [stdout] 43 | | (BTreeSet, Ord, BTreeMap), [INFO] [stdout] 44 | | (HashSet, Hash, HashMap) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `set_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/string.rs:9:53 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'a> Diffable<'a> for str { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 9 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/diffable_impls/string.rs:30:53 [INFO] [stdout] | [INFO] [stdout] 27 | impl<'a> Diffable<'a> for String { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 30 | fn diff(&'a self, other: &'a Self) -> edit::Edit { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lcs.rs:94:19 [INFO] [stdout] | [INFO] [stdout] 78 | let current_x = x.next(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let current_y = y.next(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | match (current_x, current_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lcs.rs:94:19 [INFO] [stdout] | [INFO] [stdout] 78 | let current_x = x.next(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let current_y = y.next(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | match (current_x, current_y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diffus` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/diffable_impls/borrow.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | if let edit::Edit::Change(diff) = Box::new(left).diff(&Box::new(right)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diffus` (lib test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "26a37a51e9dc11e5795931245cfe3418859eca2cc04ef44ac98400a3a6e33ccf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26a37a51e9dc11e5795931245cfe3418859eca2cc04ef44ac98400a3a6e33ccf", kill_on_drop: false }` [INFO] [stdout] 26a37a51e9dc11e5795931245cfe3418859eca2cc04ef44ac98400a3a6e33ccf