[INFO] fetching crate dictcc 0.1.1... [INFO] checking dictcc-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate dictcc 0.1.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate dictcc 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dictcc 0.1.1 [INFO] finished tweaking crates.io crate dictcc 0.1.1 [INFO] tweaked toml for crates.io crate dictcc 0.1.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 120 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (available: v1.1.3) [INFO] [stderr] Adding app_dirs v1.2.1 (available: v2.0.1) [INFO] [stderr] Adding arrayvec v0.5.2 (available: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding blake2b_simd v0.5.11 (available: v1.0.2) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding colored v1.9.4 (available: v2.1.0) [INFO] [stderr] Adding constant_time_eq v0.1.5 (available: v0.3.1) [INFO] [stderr] Adding csv v0.15.0 (available: v1.3.0) [INFO] [stderr] Adding dirs v1.0.5 (available: v5.0.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding errno v0.2.8 (available: v0.3.9) [INFO] [stderr] Adding getrandom v0.1.16 (available: v0.2.15) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.7.11 (available: v0.13.0) [INFO] [stderr] Adding lazy_static v0.2.11 (available: v1.5.0) [INFO] [stderr] Adding memchr v1.0.2 (available: v2.7.4) [INFO] [stderr] Adding nom v3.2.1 (available: v7.1.3) [INFO] [stderr] Adding pager v0.14.0 (available: v0.16.1) [INFO] [stderr] Adding prettytable-rs v0.6.7 (available: v0.10.0) [INFO] [stderr] Adding quote v0.3.15 (available: v1.0.37) [INFO] [stderr] Adding redox_syscall v0.1.57 (available: v0.5.6) [INFO] [stderr] Adding redox_users v0.3.5 (available: v0.4.6) [INFO] [stderr] Adding regex v0.2.11 (available: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (available: v0.8.4) [INFO] [stderr] Adding rust-argon2 v0.8.3 (available: v2.1.0) [INFO] [stderr] Adding simplelog v0.5.3 (available: v0.12.2) [INFO] [stderr] Adding strsim v0.8.0 (available: v0.11.1) [INFO] [stderr] Adding structopt v0.1.7 (available: v0.3.26) [INFO] [stderr] Adding structopt-derive v0.1.6 (available: v0.4.18) [INFO] [stderr] Adding syn v0.11.11 (available: v2.0.77) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] [stderr] Adding term v0.4.6 (available: v1.0.0) [INFO] [stderr] Adding term v0.5.2 (available: v1.0.0) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding thread_local v0.3.6 (available: v1.1.8) [INFO] [stderr] Adding toml v0.4.10 (available: v0.8.19) [INFO] [stderr] Adding ucd-util v0.1.10 (available: v0.2.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding unicode-xid v0.0.4 (available: v0.2.6) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (available: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1bfb215580c57d485d9d3bee7b82a8ae9e249074c7e96484255035973e1d50d [INFO] running `Command { std: "docker" "start" "-a" "e1bfb215580c57d485d9d3bee7b82a8ae9e249074c7e96484255035973e1d50d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1bfb215580c57d485d9d3bee7b82a8ae9e249074c7e96484255035973e1d50d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1bfb215580c57d485d9d3bee7b82a8ae9e249074c7e96484255035973e1d50d", kill_on_drop: false }` [INFO] [stdout] e1bfb215580c57d485d9d3bee7b82a8ae9e249074c7e96484255035973e1d50d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 11f1b9686f5fb8718d80b65ee1ce9d10349411e514c34df670d994f54f1d29a2 [INFO] running `Command { std: "docker" "start" "-a" "11f1b9686f5fb8718d80b65ee1ce9d10349411e514c34df670d994f54f1d29a2", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking term v0.4.6 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking pager v0.14.0 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking htmlescape v0.3.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking dictcc v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `failure::core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/dict/mod.rs:593:20 [INFO] [stdout] | [INFO] [stdout] 593 | Ok(match s.trim_right_matches('.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 593 | Ok(match s.trim_end_matches('.') { [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `failure::core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/dict/mod.rs:635:20 [INFO] [stdout] | [INFO] [stdout] 635 | Ok(match s.trim_right_matches('.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 635 | Ok(match s.trim_end_matches('.') { [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ReaderBuilder` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/raw_csv.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn get_csv_reader_from_path>(path: P) -> DictResult> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | csv::ReaderBuilder::new() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_DictError` [INFO] [stdout] 18 | pub enum DictError { [INFO] [stdout] | --------- `DictError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_DictError` [INFO] [stdout] 18 | pub enum DictError { [INFO] [stdout] | --------- `DictError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dictcc` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `failure::core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/dict/mod.rs:593:20 [INFO] [stdout] | [INFO] [stdout] 593 | Ok(match s.trim_right_matches('.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 593 | Ok(match s.trim_end_matches('.') { [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `failure::core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/dict/mod.rs:635:20 [INFO] [stdout] | [INFO] [stdout] 635 | Ok(match s.trim_right_matches('.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 635 | Ok(match s.trim_end_matches('.') { [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ReaderBuilder` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/raw_csv.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn get_csv_reader_from_path>(path: P) -> DictResult> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | csv::ReaderBuilder::new() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_DictError` [INFO] [stdout] 18 | pub enum DictError { [INFO] [stdout] | --------- `DictError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_DictError` [INFO] [stdout] 18 | pub enum DictError { [INFO] [stdout] | --------- `DictError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dictcc` (lib) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "11f1b9686f5fb8718d80b65ee1ce9d10349411e514c34df670d994f54f1d29a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11f1b9686f5fb8718d80b65ee1ce9d10349411e514c34df670d994f54f1d29a2", kill_on_drop: false }` [INFO] [stdout] 11f1b9686f5fb8718d80b65ee1ce9d10349411e514c34df670d994f54f1d29a2