[INFO] fetching crate deno_config 0.35.0... [INFO] checking deno_config-0.35.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate deno_config 0.35.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate deno_config 0.35.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate deno_config 0.35.0 [INFO] finished tweaking crates.io crate deno_config 0.35.0 [INFO] tweaked toml for crates.io crate deno_config 0.35.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a612814fe2d39b308acd9f18239ce94db5e4db8c896beb429a32304e931f840e [INFO] running `Command { std: "docker" "start" "-a" "a612814fe2d39b308acd9f18239ce94db5e4db8c896beb429a32304e931f840e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a612814fe2d39b308acd9f18239ce94db5e4db8c896beb429a32304e931f840e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a612814fe2d39b308acd9f18239ce94db5e4db8c896beb429a32304e931f840e", kill_on_drop: false }` [INFO] [stdout] a612814fe2d39b308acd9f18239ce94db5e4db8c896beb429a32304e931f840e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ca6fa79e815bd4e1ee8a5942491a4dd969542aba7df24a8e5e3b6ab48aba5b7 [INFO] running `Command { std: "docker" "start" "-a" "5ca6fa79e815bd4e1ee8a5942491a4dd969542aba7df24a8e5e3b6ab48aba5b7", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking monch v0.5.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking globset v0.4.15 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking ignore v0.4.23 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking deno_semver v0.5.13 [INFO] [stderr] Checking deno_package_json v0.1.2 [INFO] [stderr] Checking import_map v0.20.1 [INFO] [stderr] Checking jsonc-parser v0.23.0 [INFO] [stderr] Checking deno_config v0.35.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(std::option::Option>, std::option::Option>>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/mod.rs:1859:9 [INFO] [stdout] | [INFO] [stdout] 1848 | opts: CombineOptionVecsWithOverride, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1859 | match (root, opts.member) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deno_config` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `resolver::MappedResolution<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/resolver.rs:1031:11 [INFO] [stdout] | [INFO] [stdout] 1012 | let workspace_dir = workspace_at_start_dir(&fs, &root_dir()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1013 | let resolver = workspace_dir [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1031 | match resolver [INFO] [stdout] | ___________^ [INFO] [stdout] 1032 | | .resolve("b", &root.join("main.ts").unwrap()) [INFO] [stdout] 1033 | | .unwrap() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `resolver::MappedResolution<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/resolver.rs:1121:11 [INFO] [stdout] | [INFO] [stdout] 1089 | let workspace_dir = workspace_at_start_dir(&fs, &root_dir()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1090 | let resolver = workspace_dir [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1121 | match resolver [INFO] [stdout] | ___________^ [INFO] [stdout] 1122 | | .resolve("jsr:@scope/patch@2", &root.join("main.ts").unwrap()) [INFO] [stdout] 1123 | | .unwrap() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `resolver::MappedResolution<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/resolver.rs:1184:11 [INFO] [stdout] | [INFO] [stdout] 1162 | let workspace_dir = workspace_at_start_dir(&fs, &root_dir()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1163 | let resolver = workspace_dir [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1184 | match resolver [INFO] [stdout] | ___________^ [INFO] [stdout] 1185 | | .resolve("jsr:@scope/patch@12", &root.join("main.ts").unwrap()) [INFO] [stdout] 1186 | | .unwrap() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `resolver::MappedResolution<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/resolver.rs:1244:11 [INFO] [stdout] | [INFO] [stdout] 1212 | let workspace_dir = workspace_at_start_dir(&fs, &root_dir()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1213 | let resolver = workspace_dir [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1244 | match resolver [INFO] [stdout] | ___________^ [INFO] [stdout] 1245 | | .resolve("jsr:@scope/member@2", &root.join("main.ts").unwrap()) [INFO] [stdout] 1246 | | .unwrap() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `resolver::MappedResolution<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/resolver.rs:1332:11 [INFO] [stdout] | [INFO] [stdout] 1300 | let workspace_dir = workspace_at_start_dir(&fs, &root_dir()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1301 | let resolver = workspace_dir [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1332 | match resolver [INFO] [stdout] | ___________^ [INFO] [stdout] 1333 | | .resolve("@std/fs", &root.join("../patch/member/mod.ts").unwrap()) [INFO] [stdout] 1334 | | .unwrap() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>, std::option::Option>>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/mod.rs:1859:9 [INFO] [stdout] | [INFO] [stdout] 1848 | opts: CombineOptionVecsWithOverride, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1859 | match (root, opts.member) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `workspace::WorkspaceDirectory` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/mod.rs:2202:11 [INFO] [stdout] | [INFO] [stdout] 2136 | let workspace_dir = WorkspaceDirectory::discover( [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2147 | let root_deno_json = Some(WorkspaceMemberTasksConfigFile { [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2157 | let root = Some(WorkspaceMemberTasksConfig { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2202 | let member_dir = workspace_dir.workspace.resolve_member_dir( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `workspace::WorkspaceDiscoverErrorKind` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/mod.rs:3273:11 [INFO] [stdout] | [INFO] [stdout] 3258 | let pkg = json!({ [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3273 | match err.into_kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `indexmap::IndexMap, glob::FilePatterns>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/mod.rs:4514:11 [INFO] [stdout] | [INFO] [stdout] 4247 | let workspace_dir = workspace_at_start_dir(&fs, &root_dir()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4514 | let split = workspace_dir.workspace.split_cli_args_by_deno_json_folder( [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `indexmap::IndexMap, glob::FilePatterns>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/mod.rs:4551:11 [INFO] [stdout] | [INFO] [stdout] 4545 | let workspace_dir = workspace_at_start_dir(&fs, &root_dir()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4551 | let split = workspace_dir.workspace.split_cli_args_by_deno_json_folder( [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `workspace::WorkspaceDirectory` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/mod.rs:5056:11 [INFO] [stdout] | [INFO] [stdout] 5048 | let deno_json_cache = DenoJsonMemCache::default(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 5049 | let pkg_json_cache = PkgJsonMemCache::default(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 5050 | let workspace_cache = WorkspaceMemCache::default(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 5056 | let workspace_dir = WorkspaceDirectory::discover( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `workspace::WorkspaceDirectory` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/mod.rs:5095:11 [INFO] [stdout] | [INFO] [stdout] 5087 | let deno_json_cache = DenoJsonMemCache::default(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 5088 | let pkg_json_cache = PkgJsonMemCache::default(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 5089 | let workspace_cache = WorkspaceMemCache::default(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 5095 | let workspace_dir = WorkspaceDirectory::discover( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deno_config` (lib test) due to 13 previous errors [INFO] running `Command { std: "docker" "inspect" "5ca6fa79e815bd4e1ee8a5942491a4dd969542aba7df24a8e5e3b6ab48aba5b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ca6fa79e815bd4e1ee8a5942491a4dd969542aba7df24a8e5e3b6ab48aba5b7", kill_on_drop: false }` [INFO] [stdout] 5ca6fa79e815bd4e1ee8a5942491a4dd969542aba7df24a8e5e3b6ab48aba5b7