[INFO] fetching crate ddsavelib 0.1.1... [INFO] checking ddsavelib-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ddsavelib 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ddsavelib 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ddsavelib 0.1.1 [INFO] finished tweaking crates.io crate ddsavelib 0.1.1 [INFO] tweaked toml for crates.io crate ddsavelib 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding dtoa v0.4.8 (available: v1.0.9) [INFO] [stderr] Adding itoa v0.4.8 (available: v1.0.11) [INFO] [stderr] Adding phf_shared v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e922abb4ad5bbf958174b8121c91293eaf5d56962b16e6e5202cc9d3b77eedf [INFO] running `Command { std: "docker" "start" "-a" "5e922abb4ad5bbf958174b8121c91293eaf5d56962b16e6e5202cc9d3b77eedf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e922abb4ad5bbf958174b8121c91293eaf5d56962b16e6e5202cc9d3b77eedf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e922abb4ad5bbf958174b8121c91293eaf5d56962b16e6e5202cc9d3b77eedf", kill_on_drop: false }` [INFO] [stdout] 5e922abb4ad5bbf958174b8121c91293eaf5d56962b16e6e5202cc9d3b77eedf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b13b17cae3c55ba4e8c00a43fd8273b8c34af9dd4b28b6b699ec9fd2f2715790 [INFO] running `Command { std: "docker" "start" "-a" "b13b17cae3c55ba4e8c00a43fd8273b8c34af9dd4b28b6b699ec9fd2f2715790", kill_on_drop: false }` [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking ddsavelib v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `or_patterns` has been stable since 1.53.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | #![feature(or_patterns)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `try_reserve` has been stable since 1.57.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | #![feature(try_reserve)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `or_patterns` has been stable since 1.53.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | #![feature(or_patterns)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `try_reserve` has been stable since 1.57.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | #![feature(try_reserve)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/bin.rs:539:39 [INFO] [stdout] | [INFO] [stdout] 394 | std::io::copy(&mut $r.by_ref().take($num as u64), &mut std::io::sink())?; [INFO] [stdout] | ------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 539 | } else if let Some(mut val) = hardcoded_type(name_trace, name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/bin.rs:539:39 [INFO] [stdout] | [INFO] [stdout] 394 | std::io::copy(&mut $r.by_ref().take($num as u64), &mut std::io::sink())?; [INFO] [stdout] | ------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 539 | } else if let Some(mut val) = hardcoded_type(name_trace, name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/json.rs:393:32 [INFO] [stdout] | [INFO] [stdout] 387 | / tok.dat.parse::<$t>().map_err(|_| { [INFO] [stdout] 388 | | FromJsonError::LiteralFormat($err.to_owned(), lex.span().first, lex.span().end) [INFO] [stdout] 389 | | })? [INFO] [stdout] | | - [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | | if let Some(mut val) = hardcoded_type(name_stack, name) { [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/json.rs:393:32 [INFO] [stdout] | [INFO] [stdout] 387 | / tok.dat.parse::<$t>().map_err(|_| { [INFO] [stdout] 388 | | FromJsonError::LiteralFormat($err.to_owned(), lex.span().first, lex.span().end) [INFO] [stdout] 389 | | })? [INFO] [stdout] | | - [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | | if let Some(mut val) = hardcoded_type(name_stack, name) { [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ddsavelib` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ddsavelib` (lib) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b13b17cae3c55ba4e8c00a43fd8273b8c34af9dd4b28b6b699ec9fd2f2715790", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b13b17cae3c55ba4e8c00a43fd8273b8c34af9dd4b28b6b699ec9fd2f2715790", kill_on_drop: false }` [INFO] [stdout] b13b17cae3c55ba4e8c00a43fd8273b8c34af9dd4b28b6b699ec9fd2f2715790