[INFO] fetching crate dashmap_with_out_t_map_trait 5.0.0... [INFO] checking dashmap_with_out_t_map_trait-5.0.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate dashmap_with_out_t_map_trait 5.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate dashmap_with_out_t_map_trait 5.0.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate dashmap_with_out_t_map_trait 5.0.0 [INFO] finished tweaking crates.io crate dashmap_with_out_t_map_trait 5.0.0 [INFO] tweaked toml for crates.io crate dashmap_with_out_t_map_trait 5.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding parking_lot v0.11.2 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (available: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (available: v0.5.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 85ec1093aa28fe64401c46e2c2c846bd0d749415b0f269eeeed25c78da5ebbb4 [INFO] running `Command { std: "docker" "start" "-a" "85ec1093aa28fe64401c46e2c2c846bd0d749415b0f269eeeed25c78da5ebbb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "85ec1093aa28fe64401c46e2c2c846bd0d749415b0f269eeeed25c78da5ebbb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85ec1093aa28fe64401c46e2c2c846bd0d749415b0f269eeeed25c78da5ebbb4", kill_on_drop: false }` [INFO] [stdout] 85ec1093aa28fe64401c46e2c2c846bd0d749415b0f269eeeed25c78da5ebbb4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a76a32bc44b1308cd4cfc0e35ebe43fb40ce79f5511a62505b308f79a66b0042 [INFO] running `Command { std: "docker" "start" "-a" "a76a32bc44b1308cd4cfc0e35ebe43fb40ce79f5511a62505b308f79a66b0042", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking dashmap_with_out_t_map_trait v5.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:838:30 [INFO] [stdout] | [INFO] [stdout] 833 | fn _alter(&self, key: &Q, f: impl FnOnce(&K, V) -> V) [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 838 | if let Some(mut r) = self.get_mut(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dashmap_with_out_t_map_trait` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Map, {closure@src/read_only.rs:174:35: 174:42}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read_only.rs:174:20 [INFO] [stdout] | [INFO] [stdout] 170 | let map = construct_sample_map(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | [INFO] [stdout] 172 | let view = map.clone().into_read_only(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | [INFO] [stdout] 174 | for key in map.iter().map(|entry| *entry.key()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:838:30 [INFO] [stdout] | [INFO] [stdout] 833 | fn _alter(&self, key: &Q, f: impl FnOnce(&K, V) -> V) [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 838 | if let Some(mut r) = self.get_mut(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mapref::one::Ref<'_, i32, T0>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1087:28 [INFO] [stdout] | [INFO] [stdout] 1075 | let dm = DashMap::new(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1087 | assert_eq!(&t, dm.get(&i).unwrap().value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mapref::one::Ref<'_, u32, u32>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1099:28 [INFO] [stdout] | [INFO] [stdout] 1093 | let dm_hm_default: DashMap = [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1099 | assert_eq!(i, *dm_hm_default.get(&i).unwrap().value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dashmap_with_out_t_map_trait` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "a76a32bc44b1308cd4cfc0e35ebe43fb40ce79f5511a62505b308f79a66b0042", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a76a32bc44b1308cd4cfc0e35ebe43fb40ce79f5511a62505b308f79a66b0042", kill_on_drop: false }` [INFO] [stdout] a76a32bc44b1308cd4cfc0e35ebe43fb40ce79f5511a62505b308f79a66b0042