[INFO] fetching crate cxx-build 1.0.128... [INFO] checking cxx-build-1.0.128 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate cxx-build 1.0.128 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate cxx-build 1.0.128 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cxx-build 1.0.128 [INFO] finished tweaking crates.io crate cxx-build 1.0.128 [INFO] tweaked toml for crates.io crate cxx-build 1.0.128 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d3ca97fcdbc70571ba8f1e905bbc6b85912ddda96b926c4b3eea287f7dfa1c8e [INFO] running `Command { std: "docker" "start" "-a" "d3ca97fcdbc70571ba8f1e905bbc6b85912ddda96b926c4b3eea287f7dfa1c8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d3ca97fcdbc70571ba8f1e905bbc6b85912ddda96b926c4b3eea287f7dfa1c8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3ca97fcdbc70571ba8f1e905bbc6b85912ddda96b926c4b3eea287f7dfa1c8e", kill_on_drop: false }` [INFO] [stdout] d3ca97fcdbc70571ba8f1e905bbc6b85912ddda96b926c4b3eea287f7dfa1c8e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 011aada14a9fca151f05271a1a4c11170ce4573d7bdc029be6aeff0fee4d24a4 [INFO] running `Command { std: "docker" "start" "-a" "011aada14a9fca151f05271a1a4c11170ce4573d7bdc029be6aeff0fee4d24a4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.13 [INFO] [stderr] Compiling link-cplusplus v1.0.9 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling cxxbridge-flags v1.0.128 [INFO] [stderr] Compiling scratch v1.0.7 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking pkg-config v0.3.31 [INFO] [stderr] Compiling cxx v1.0.128 [INFO] [stderr] Checking cc v1.1.21 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking cxx-gen v0.7.128 [INFO] [stderr] Checking cxx-build v1.0.128 (/opt/rustwide/workdir) [INFO] [stderr] Compiling cxxbridge-macro v1.0.128 [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/fs.rs:50:11 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) fn copy(from: impl AsRef, to: impl AsRef) -> Result { [INFO] [stdout] | ---- -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | match std::fs::copy(from, to) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/fs.rs:58:11 [INFO] [stdout] | [INFO] [stdout] 56 | pub(crate) fn create_dir_all(path: impl AsRef) -> Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let path = path.as_ref(); [INFO] [stdout] 58 | match std::fs::create_dir_all(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/fs.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) fn exists(path: impl AsRef) -> bool { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | std::fs::symlink_metadata(path).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/fs.rs:80:11 [INFO] [stdout] | [INFO] [stdout] 78 | pub(crate) fn read(path: impl AsRef) -> Result> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let path = path.as_ref(); [INFO] [stdout] 80 | match std::fs::read(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/fs.rs:96:11 [INFO] [stdout] | [INFO] [stdout] 94 | pub(crate) fn remove_file(path: impl AsRef) -> Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let path = path.as_ref(); [INFO] [stdout] 96 | match std::fs::remove_file(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/fs.rs:104:11 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) fn remove_dir(path: impl AsRef) -> Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let path = path.as_ref(); [INFO] [stdout] 104 | match std::fs::remove_dir(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/fs.rs:168:11 [INFO] [stdout] | [INFO] [stdout] 166 | pub(crate) fn write(path: impl AsRef, contents: impl AsRef<[u8]>) -> Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let path = path.as_ref(); [INFO] [stdout] 168 | match std::fs::write(path, contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), gen::fs::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/out.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn write(path: impl AsRef, content: &[u8]) -> Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | let mut create_dir_error = None; [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | match fs::write(path, content) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), gen::fs::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/out.rs:86:11 [INFO] [stdout] | [INFO] [stdout] 84 | parent_directory_error: Option, [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | ) -> Result<()> { [INFO] [stdout] 86 | match paths::symlink_or_copy(path_for_symlink, path_for_copy, link) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), gen::fs::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/out.rs:113:11 [INFO] [stdout] | [INFO] [stdout] 111 | parent_directory_error: Option, [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | ) -> Result<()> { [INFO] [stdout] 113 | match fs::symlink_dir(path_for_symlink, link) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cxx-build` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "011aada14a9fca151f05271a1a4c11170ce4573d7bdc029be6aeff0fee4d24a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "011aada14a9fca151f05271a1a4c11170ce4573d7bdc029be6aeff0fee4d24a4", kill_on_drop: false }` [INFO] [stdout] 011aada14a9fca151f05271a1a4c11170ce4573d7bdc029be6aeff0fee4d24a4