[INFO] fetching crate crux_core 0.9.0... [INFO] checking crux_core-0.9.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate crux_core 0.9.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate crux_core 0.9.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crux_core 0.9.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate crux_core 0.9.0 [INFO] tweaked toml for crates.io crate crux_core 0.9.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 124 packages to latest compatible versions [INFO] [stderr] Adding heck v0.3.3 (available: v0.5.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding include_dir v0.6.2 (available: v0.7.4) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding phf v0.10.1 (available: v0.11.2) [INFO] [stderr] Adding phf_generator v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding phf_macros v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding phf_shared v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding termtree v0.4.1 (available: v0.5.1) [INFO] [stderr] Adding textwrap v0.13.4 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dba12a7fa0daa2b93a796779106ba64f9a5287b31d2f2ad6163c14a6ff6f2aa6 [INFO] running `Command { std: "docker" "start" "-a" "dba12a7fa0daa2b93a796779106ba64f9a5287b31d2f2ad6163c14a6ff6f2aa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dba12a7fa0daa2b93a796779106ba64f9a5287b31d2f2ad6163c14a6ff6f2aa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dba12a7fa0daa2b93a796779106ba64f9a5287b31d2f2ad6163c14a6ff6f2aa6", kill_on_drop: false }` [INFO] [stdout] dba12a7fa0daa2b93a796779106ba64f9a5287b31d2f2ad6163c14a6ff6f2aa6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8cad5c6a7c2d29e3a9fa87379e1249cb0d0bf507f73df11e15e21aee743d7981 [INFO] running `Command { std: "docker" "start" "-a" "8cad5c6a7c2d29e3a9fa87379e1249cb0d0bf507f73df11e15e21aee743d7981", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling crux_macros v0.4.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking globset v0.4.15 [INFO] [stderr] Checking ignore v0.4.23 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking assert_fs v1.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking crux_core v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capability/shell_request.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 29 | let mut shared_state = self.shared_state.lock().unwrap(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | match shared_state.result.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capability/shell_request.rs:86:34 [INFO] [stdout] | [INFO] [stdout] 75 | let Some(shared_state) = callback_shared_state.upgrade() else { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut shared_state = shared_state.lock().unwrap(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | if let Some(waker) = shared_state.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, ()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capability/shell_stream.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 28 | let mut shared_state = self.shared_state.lock().unwrap(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | match shared_state.receiver.try_receive() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capability/shell_request.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 29 | let mut shared_state = self.shared_state.lock().unwrap(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | match shared_state.result.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crux_core` (lib) due to 4 previous errors [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capability/shell_request.rs:86:34 [INFO] [stdout] | [INFO] [stdout] 75 | let Some(shared_state) = callback_shared_state.upgrade() else { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut shared_state = shared_state.lock().unwrap(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | if let Some(waker) = shared_state.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result, ()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/capability/shell_stream.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 28 | let mut shared_state = self.shared_state.lock().unwrap(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | match shared_state.receiver.try_receive() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crux_core` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "8cad5c6a7c2d29e3a9fa87379e1249cb0d0bf507f73df11e15e21aee743d7981", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8cad5c6a7c2d29e3a9fa87379e1249cb0d0bf507f73df11e15e21aee743d7981", kill_on_drop: false }` [INFO] [stdout] 8cad5c6a7c2d29e3a9fa87379e1249cb0d0bf507f73df11e15e21aee743d7981