[INFO] fetching crate crsh 0.0.1... [INFO] checking crsh-0.0.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate crsh 0.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate crsh 0.0.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crsh 0.0.1 [INFO] finished tweaking crates.io crate crsh 0.0.1 [INFO] tweaked toml for crates.io crate crsh 0.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate crsh 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f760bf37d7753a25220a09f926fa39c00c5604f358e98748eedc5d1d38f8063 [INFO] running `Command { std: "docker" "start" "-a" "5f760bf37d7753a25220a09f926fa39c00c5604f358e98748eedc5d1d38f8063", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f760bf37d7753a25220a09f926fa39c00c5604f358e98748eedc5d1d38f8063", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f760bf37d7753a25220a09f926fa39c00c5604f358e98748eedc5d1d38f8063", kill_on_drop: false }` [INFO] [stdout] 5f760bf37d7753a25220a09f926fa39c00c5604f358e98748eedc5d1d38f8063 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eadfcebdc5d62233b647becc6ee32c4b052859ed43ecc3d33d7cdaaeb102174d [INFO] running `Command { std: "docker" "start" "-a" "eadfcebdc5d62233b647becc6ee32c4b052859ed43ecc3d33d7cdaaeb102174d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling crsh v0.0.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking os_pipe v1.2.0 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Compiling logos-codegen v0.14.0 [INFO] [stderr] Compiling logos-derive v0.14.0 [INFO] [stderr] Checking logos v0.14.0 [INFO] [stdout] error: this value of type `Option Fn(&'a [&'b str]) -> Result, String>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/execution.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 21 | fn execute_simple(&mut self, ctx: Option, keyword: &str, args: &[&str]) -> i32 { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let mut io = match ctx { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | if let Some(builder) = Self::get_builtin_builder(keyword) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/execution.rs:126:15 [INFO] [stdout] | [INFO] [stdout] 85 | fn execute_pipeline(&mut self, ctx: Option, cmds: &[Command]) -> i32 { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let io = match ctx { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let mut pipes = Vec::new(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | match results.last() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option Fn(&'a [&'b str]) -> Result, String>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/execution.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 21 | fn execute_simple(&mut self, ctx: Option, keyword: &str, args: &[&str]) -> i32 { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let mut io = match ctx { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | if let Some(builder) = Self::get_builtin_builder(keyword) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell/execution.rs:126:15 [INFO] [stdout] | [INFO] [stdout] 85 | fn execute_pipeline(&mut self, ctx: Option, cmds: &[Command]) -> i32 { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let io = match ctx { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let mut pipes = Vec::new(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | match results.last() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ps2` and `ps4` are never read [INFO] [stdout] --> src/shell/common_env.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct CommonEnv { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub ps2: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | pub ps4: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ps2` and `ps4` are never read [INFO] [stdout] --> src/shell/common_env.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct CommonEnv { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub ps2: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | pub ps4: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crsh` (bin "crsh") due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `crsh` (bin "crsh" test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "eadfcebdc5d62233b647becc6ee32c4b052859ed43ecc3d33d7cdaaeb102174d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eadfcebdc5d62233b647becc6ee32c4b052859ed43ecc3d33d7cdaaeb102174d", kill_on_drop: false }` [INFO] [stdout] eadfcebdc5d62233b647becc6ee32c4b052859ed43ecc3d33d7cdaaeb102174d