[INFO] fetching crate crony 0.3.1... [INFO] checking crony-0.3.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate crony 0.3.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate crony 0.3.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crony 0.3.1 [INFO] finished tweaking crates.io crate crony 0.3.1 [INFO] tweaked toml for crates.io crate crony 0.3.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate crony 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0afa713c234fa9b5d09762d97e2512aadc852e37b2b497f635273065a3f1389c [INFO] running `Command { std: "docker" "start" "-a" "0afa713c234fa9b5d09762d97e2512aadc852e37b2b497f635273065a3f1389c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0afa713c234fa9b5d09762d97e2512aadc852e37b2b497f635273065a3f1389c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0afa713c234fa9b5d09762d97e2512aadc852e37b2b497f635273065a3f1389c", kill_on_drop: false }` [INFO] [stdout] 0afa713c234fa9b5d09762d97e2512aadc852e37b2b497f635273065a3f1389c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d55fecf46605240e1aa071b4b3b7ab9b8965697ae73f4fec6eca6a6899598556 [INFO] running `Command { std: "docker" "start" "-a" "d55fecf46605240e1aa071b4b3b7ab9b8965697ae73f4fec6eca6a6899598556", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking cron v0.12.0 [INFO] [stderr] Checking crony v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:247:31 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn stop(mut self) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | if let Some(thread) = self.thread.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:278:11 [INFO] [stdout] | [INFO] [stdout] 275 | fn spawn(runner: Runner, working: Arc) -> JhTx { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | let (tx, rx): TxRx = mpsc::channel(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | [INFO] [stdout] 278 | match Builder::new() [INFO] [stdout] | ___________^ [INFO] [stdout] 279 | | .name(String::from("cron-runner-thread")) [INFO] [stdout] 280 | | .spawn(move || { [INFO] [stdout] 281 | | let jobs = runner.jobs; [INFO] [stdout] ... | [INFO] [stdout] 359 | | } [INFO] [stdout] 360 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crony` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:247:31 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn stop(mut self) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | if let Some(thread) = self.thread.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:278:11 [INFO] [stdout] | [INFO] [stdout] 275 | fn spawn(runner: Runner, working: Arc) -> JhTx { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | let (tx, rx): TxRx = mpsc::channel(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | [INFO] [stdout] 278 | match Builder::new() [INFO] [stdout] | ___________^ [INFO] [stdout] 279 | | .name(String::from("cron-runner-thread")) [INFO] [stdout] 280 | | .spawn(move || { [INFO] [stdout] 281 | | let jobs = runner.jobs; [INFO] [stdout] ... | [INFO] [stdout] 359 | | } [INFO] [stdout] 360 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crony` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "d55fecf46605240e1aa071b4b3b7ab9b8965697ae73f4fec6eca6a6899598556", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d55fecf46605240e1aa071b4b3b7ab9b8965697ae73f4fec6eca6a6899598556", kill_on_drop: false }` [INFO] [stdout] d55fecf46605240e1aa071b4b3b7ab9b8965697ae73f4fec6eca6a6899598556