[INFO] fetching crate crate-index 0.1.0... [INFO] checking crate-index-0.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate crate-index 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate crate-index 0.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate crate-index 0.1.0 [INFO] finished tweaking crates.io crate crate-index 0.1.0 [INFO] tweaked toml for crates.io crate crate-index 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 110 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (available: v2.3.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding event-listener v2.5.3 (available: v5.3.1) [INFO] [stderr] Adding git2 v0.11.0 (available: v0.19.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding itertools v0.8.2 (available: v0.13.0) [INFO] [stderr] Adding libgit2-sys v0.10.0 (available: v0.17.0+1.8.1) [INFO] [stderr] Adding libssh2-sys v0.2.23 (available: v0.3.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding semver v0.9.0 (available: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (available: v0.10.2) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding test-case v1.2.3 (available: v3.3.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c33b241947d76da59ea7dd8cbe72ebc3d3d48e190b5afdda70f78954e5175951 [INFO] running `Command { std: "docker" "start" "-a" "c33b241947d76da59ea7dd8cbe72ebc3d3d48e190b5afdda70f78954e5175951", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c33b241947d76da59ea7dd8cbe72ebc3d3d48e190b5afdda70f78954e5175951", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c33b241947d76da59ea7dd8cbe72ebc3d3d48e190b5afdda70f78954e5175951", kill_on_drop: false }` [INFO] [stdout] c33b241947d76da59ea7dd8cbe72ebc3d3d48e190b5afdda70f78954e5175951 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b068a53fc446265796089b094ece13e320fe97ab29c37783928a91f898481966 [INFO] running `Command { std: "docker" "start" "-a" "b068a53fc446265796089b094ece13e320fe97ab29c37783928a91f898481966", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling test-case v1.2.3 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-std v1.13.0 [INFO] [stderr] Checking git2 v0.11.0 [INFO] [stderr] Checking crate-index v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `git2::Config` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/git.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn set_username(&self, username: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | self.repo.config()?.set_str("user.name", username.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `git2::Config` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/git.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn set_email(&self, email: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.repo.config()?.set_str("user.email", email.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `git2::Index` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/git.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn add_path(&self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | self.repo.index()?.add_path(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crate-index` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result<(), error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/file.rs:362:19 [INFO] [stdout] | [INFO] [stdout] 347 | let temp_dir = tempfile::tempdir().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | let mut index_file = IndexFile::open(root.clone(), initial_metadata.name()) [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | match index_file.yank(&version).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/tree.rs:381:19 [INFO] [stdout] | [INFO] [stdout] 365 | let temp_dir = tempfile::tempdir().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | let mut tree = Tree::initialise(root.clone(), download) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 381 | match tree.yank(crate_name, &version).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `git2::Config` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/git.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn set_username(&self, username: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | self.repo.config()?.set_str("user.name", username.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `git2::Config` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/git.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn set_email(&self, email: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.repo.config()?.set_str("user.email", email.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `git2::Index` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/git.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn add_path(&self, path: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | self.repo.index()?.add_path(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/index/file.rs:353:54 [INFO] [stdout] | [INFO] [stdout] 353 | let mut index_file = IndexFile::open(root.clone(), initial_metadata.name()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 353 - let mut index_file = IndexFile::open(root.clone(), initial_metadata.name()) [INFO] [stdout] 353 + let mut index_file = IndexFile::open(root, initial_metadata.name()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/index/tree.rs:343:49 [INFO] [stdout] | [INFO] [stdout] 343 | let mut tree = Tree::initialise(root.clone(), download) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 343 - let mut tree = Tree::initialise(root.clone(), download) [INFO] [stdout] 343 + let mut tree = Tree::initialise(root, download) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/index/tree.rs:372:49 [INFO] [stdout] | [INFO] [stdout] 372 | let mut tree = Tree::initialise(root.clone(), download) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 372 - let mut tree = Tree::initialise(root.clone(), download) [INFO] [stdout] 372 + let mut tree = Tree::initialise(root, download) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `crate-index` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b068a53fc446265796089b094ece13e320fe97ab29c37783928a91f898481966", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b068a53fc446265796089b094ece13e320fe97ab29c37783928a91f898481966", kill_on_drop: false }` [INFO] [stdout] b068a53fc446265796089b094ece13e320fe97ab29c37783928a91f898481966